test: add default case when no arguments provided to a rule (#1140)

test/argument_limit_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestArgumentLimitDefault(t *testing.T) {
+	testRule(t, "argument_limit_default", &rule.ArgumentsLimitRule{}, &lint.RuleConfig{})
+}
+
 func TestArgumentLimit(t *testing.T) {
 	testRule(t, "argument_limit", &rule.ArgumentsLimitRule{}, &lint.RuleConfig{
 		Arguments: []any{int64(3)},

test/banned_characters_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestBannedCharactersDefault(t *testing.T) {
+	testRule(t, "banned_characters_default", &rule.BannedCharsRule{}, &lint.RuleConfig{})
+}
+
 // Test banned characters in a const, var and func names.
 // One banned character is in the comment and should not be checked.
 // One banned character from the list is not present in the fixture file.

test/cognitive_complexity_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestCognitiveComplexityDefault(t *testing.T) {
+	testRule(t, "cognitive_complexity_default", &rule.CognitiveComplexityRule{}, &lint.RuleConfig{})
+}
+
 func TestCognitiveComplexity(t *testing.T) {
 	testRule(t, "cognitive_complexity", &rule.CognitiveComplexityRule{}, &lint.RuleConfig{
 		Arguments: []any{int64(0)},

test/context_as_argument_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestContextAsArgumentDefault(t *testing.T) {
+	testRule(t, "context_as_argument_default", &rule.ContextAsArgumentRule{}, &lint.RuleConfig{})
+}
+
 func TestContextAsArgument(t *testing.T) {
 	testRule(t, "context_as_argument", &rule.ContextAsArgumentRule{}, &lint.RuleConfig{
 		Arguments: []any{

test/cyclomatic_test.go

@@ -7,7 +7,12 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestCyclomaticDefault(t *testing.T) {
+	testRule(t, "cyclomatic_default", &rule.CyclomaticRule{}, &lint.RuleConfig{})
+}
+
 func TestCyclomatic(t *testing.T) {
+	testRule(t, "cyclomatic_default", &rule.CyclomaticRule{}, &lint.RuleConfig{})
 	testRule(t, "cyclomatic", &rule.CyclomaticRule{}, &lint.RuleConfig{
 		Arguments: []any{int64(1)},
 	})

test/dot_imports_test.go

@@ -7,12 +7,14 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
-func TestDotImports(t *testing.T) {
-	args := []any{map[string]any{
-		"allowedPackages": []any{"errors", "context", "github.com/BurntSushi/toml"},
-	}}
+func TestDotImportsDefault(t *testing.T) {
+	testRule(t, "dot_imports_default", &rule.DotImportsRule{}, &lint.RuleConfig{})
+}
 
-	testRule(t, "import_dot", &rule.DotImportsRule{}, &lint.RuleConfig{
-		Arguments: args,
+func TestDotImports(t *testing.T) {
+	testRule(t, "dot_imports", &rule.DotImportsRule{}, &lint.RuleConfig{
+		Arguments: []any{map[string]any{
+			"allowedPackages": []any{"errors", "context", "github.com/BurntSushi/toml"},
+		}},
 	})
 }

test/enforce_repeated_arg_type_style_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestEnforceRepeatedArgTypeStyleDefault(t *testing.T) {
+	testRule(t, "enforce_repeated_arg_type_style_default", &rule.EnforceRepeatedArgTypeStyleRule{}, &lint.RuleConfig{})
+}
+
 func TestEnforceRepeatedArgTypeStyleShort(t *testing.T) {
 	testRule(t, "enforce_repeated_arg_type_style_short_args", &rule.EnforceRepeatedArgTypeStyleRule{}, &lint.RuleConfig{
 		Arguments: []any{"short"},

test/file_header_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestLintFileHeaderDefault(t *testing.T) {
+	testRule(t, "lint_file_header_default", &rule.FileHeaderRule{}, &lint.RuleConfig{})
+}
+
 func TestLintFileHeader(t *testing.T) {
 	testRule(t, "lint_file_header1", &rule.FileHeaderRule{}, &lint.RuleConfig{
 		Arguments: []any{"foobar"},

test/function_length_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestFuncLengthDefault(t *testing.T) {
+	testRule(t, "function_length_default", &rule.FunctionLength{}, &lint.RuleConfig{})
+}
+
 func TestFuncLengthLimitsStatements(t *testing.T) {
 	testRule(t, "function_length1", &rule.FunctionLength{}, &lint.RuleConfig{
 		Arguments: []any{int64(2), int64(100)},

test/line_length_limit_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestLineLengthLimitDefault(t *testing.T) {
+	testRule(t, "line_length_limit_default", &rule.LineLengthLimitRule{}, &lint.RuleConfig{})
+}
+
 func TestLineLengthLimit(t *testing.T) {
 	testRule(t, "line_length_limit", &rule.LineLengthLimitRule{}, &lint.RuleConfig{
 		Arguments: []any{int64(100)},

test/max_control_nesting_test.go

@@ -7,6 +7,10 @@ import (
 	"github.com/mgechev/revive/rule"
 )
 
+func TestMaxControlNestingDefault(t *testing.T) {
+	testRule(t, "max_control_nesting_default", &rule.MaxControlNestingRule{}, &lint.RuleConfig{})
+}
+
 func TestMaxControlNesting(t *testing.T) {
 	testRule(t, "max_control_nesting", &rule.MaxControlNestingRule{}, &lint.RuleConfig{
 		Arguments: []any{int64(2)}},

testdata/argument_limit_default.go

@@ -0,0 +1,7 @@
+package fixtures
+
+func foo(a, b, c, d, e, f, g, h int) {
+}
+
+func bar(a, b, c, d, e, f, g, h, i int64) { // MATCH /maximum number of arguments per function exceeded; max 8 but got 9/
+}

testdata/banned_characters_default.go

@@ -0,0 +1,3 @@
+package fixtures
+
+const Ω = "Omega"

testdata/cognitive_complexity_default.go

@@ -0,0 +1,13 @@
+package pkg
+
+func l() { // MATCH /function l has cognitive complexity 8 (> max enabled 7)/
+	for i := 1; i <= max; i++ {
+		for j := 2; j < i; j++ {
+			if (i%j == 0) || (i%j == 1) {
+				continue
+			}
+			total += i
+		}
+	}
+	return total && max
+}

testdata/context_as_argument_default.go

@@ -0,0 +1,9 @@
+package foo
+
+import (
+	"context"
+	"testing"
+)
+
+func x(_ AllowedBeforePtrStruct, ctx context.Context) { // MATCH /context.Context should be the first parameter of a function/
+}

testdata/cyclomatic_default.go

@@ -0,0 +1,19 @@
+package pkg
+
+import "log"
+
+func f(x int) bool { // MATCH /function f has cyclomatic complexity 11 (> max enabled 10)/
+	if x > 0 && true || false {
+		return true
+	} else {
+		log.Printf("non-positive x: %d", x)
+	}
+	switch x {
+	case 1:
+	case 2:
+	case 3:
+	case 4:
+	default:
+	}
+	return true || true && true
+}

testdata/dot_imports_default.go

@@ -0,0 +1,5 @@
+package fixtures
+
+import (
+	. "context" // MATCH /should not use dot imports/
+)

testdata/enforce_repeated_arg_type_style_default.go

@@ -0,0 +1,21 @@
+package fixtures
+
+func compliantFunc(a, b int, c string) {}
+
+func nonCompliantFunc1(a int, b int, c string) {}
+func nonCompliantFunc2(a int, b, c int)        {}
+
+type myStruct struct{}
+
+func (m myStruct) compliantMethod(a, b int, c string) {}
+
+func (m myStruct) nonCompliantMethod1(a int, b int, c string) {}
+func (m myStruct) nonCompliantMethod2(a int, b, c int)        {}
+
+func variadicFunction(a int, b ...int) {}
+
+func singleArgFunction(a int) {}
+
+func multiTypeArgs(a int, b string, c float64) {}
+
+func mixedCompliance(a, b int, c int, d string) {}

testdata/function_length3.go

@@ -21,4 +21,289 @@ func funLengthA() (a int) {
 	println()
 	println()
 	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
 }

testdata/function_length_default.go

@@ -0,0 +1,134 @@
+package fixtures
+
+func funLengthA() (a int) { // MATCH /maximum number of statements per function exceeded; max 50 but got 51/
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+	println()
+}
+
+func funLengthB(file *ast.File, fset *token.FileSet, lineLimit, stmtLimit int) []Message { // MATCH /maximum number of lines per function exceeded; max 75 but got 76/
+	if true {
+		a = b
+		if false {
+			c = d
+			for _, f := range list {
+				_, ok := f.(int64)
+				if !ok {
+					continue
+				}
+			}
+		}
+	}
+	if true {
+		a = b
+		if false {
+			c = d
+			for _, f := range list {
+				_, ok := f.(int64)
+				if !ok {
+					continue
+				}
+			}
+			switch a {
+			case 1:
+				println()
+			case 2:
+				println()
+				println()
+			default:
+				println()
+
+			}
+		}
+	}
+	if true {
+		a = b
+		if false {
+			c = d
+			for _, f := range list {
+				_, ok := f.(int64)
+				if !ok {
+					continue
+				}
+			}
+			switch a {
+			case 1:
+				println()
+			case 2:
+				println()
+				println()
+			default:
+				println()
+
+			}
+		}
+	}
+	if true {
+		a = b
+		if false {
+			c = d
+			for _, f := range list {
+				_, ok := f.(int64)
+				if !ok {
+					continue
+				}
+			}
+			switch a {
+			case 1:
+				println()
+			default:
+				println()
+
+			}
+		}
+	}
+	return
+}

testdata/line_length_limit_default.go

@@ -0,0 +1,9 @@
+package fixtures
+
+import "fmt"
+
+func foo(a, b int) {
+	fmt.Printf("loooooooooooooooooooooooooooooooooooooooooong line out of limit")
+}
+
+// MATCH:6 /line is 81 characters, out of limit 80/

testdata/lint_file_header_default.go

@@ -0,0 +1 @@
+package fixtures

testdata/max_control_nesting_default.go

@@ -0,0 +1,16 @@
+package fixtures
+
+func mcn() {
+	if true {
+		if true {
+			if true {
+				if true {
+					if true {
+						if true { // MATCH /control flow nesting exceeds 5/
+						}
+					}
+				}
+			}
+		}
+	}
+}