go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-10-30 23:37:49 +02:00
Code Issues Releases Activity

fix: var-naming rule extraBadPackageNames type (#1404)

Browse Source
This commit is contained in:
Ludovic Fernandez
2025-06-16 22:04:53 +02:00
committed by GitHub
parent 04983a692f
commit 24c008dd00
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rule/var_naming.go
View File

@@ -83,7 +83,7 @@ func (r *VarNamingRule) Configure(arguments lint.Arguments) error {
case isRuleOption(k, "skipPackageNameChecks"):
r.skipPackageNameChecks = fmt.Sprint(v) == "true"
case isRuleOption(k, "extraBadPackageNames"):
extraBadPackageNames, ok := v.([]string)
extraBadPackageNames, ok := v.([]any)
if !ok {
return fmt.Errorf("invalid third argument to the var-naming rule. Expecting extraBadPackageNames of type slice of strings, but %T", v)
}
@@ -91,7 +91,7 @@ func (r *VarNamingRule) Configure(arguments lint.Arguments) error {
if r.extraBadPackageNames == nil {
r.extraBadPackageNames = map[string]struct{}{}
}
r.extraBadPackageNames[strings.ToLower(name)] = struct{}{}
r.extraBadPackageNames[strings.ToLower(name.(string))] = struct{}{}
}
}
}

6
rule/var_naming_test.go
View File

@@ -36,7 +36,7 @@ func TestVarNamingRule_Configure(t *testing.T) {
[]any{map[string]any{
"upperCaseConst": true,
"skipPackageNameChecks": true,
"extraBadPackageNames": []string{"helpers", "models"},
"extraBadPackageNames": []any{"helpers", "models"},
}},
},
wantErr: nil,
@@ -54,7 +54,7 @@ func TestVarNamingRule_Configure(t *testing.T) {
[]any{map[string]any{
"uppercaseconst": true,
"skippackagenamechecks": true,
"extrabadpackagenames": []string{"helpers", "models"},
"extrabadpackagenames": []any{"helpers", "models"},
}},
},
wantErr: nil,
@@ -72,7 +72,7 @@ func TestVarNamingRule_Configure(t *testing.T) {
[]any{map[string]any{
"upper-case-const": true,
"skip-package-name-checks": true,
"extra-bad-package-names": []string{"helpers", "models"},
"extra-bad-package-names": []any{"helpers", "models"},
}},
},
wantErr: nil,

2
test/var_naming_test.go
View File

@@ -37,7 +37,7 @@ func TestVarNaming(t *testing.T) {
})
testRule(t, "var_naming_bad_package_name", &rule.VarNamingRule{}, &lint.RuleConfig{
Arguments: []any{[]any{}, []any{},
[]any{map[string]any{"skip-package-name-checks": false, "extra-bad-package-names": []string{"helpers"}}},
[]any{map[string]any{"skip-package-name-checks": false, "extra-bad-package-names": []any{"helpers"}}},
},
})
}