go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-02-07 13:31:42 +02:00
Code Issues Releases Activity

range-val-address: improve detection (#514)

Browse Source 
range-val-address: improve detection
This commit is contained in:
Bernhard Reisenberger 2021-05-03 14:22:35 +02:00 committed by GitHub
parent e84dbc623d
commit 3bac05c7a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
rule/range-val-address.go
View File

@ -77,7 +77,7 @@ func (bw rangeBodyVisitor) Visit(node ast.Node) ast.Visitor {
for _, exp := range asgmt.Rhs {
switch e := exp.(type) {
case *ast.UnaryExpr: // e.g. ...&value
case *ast.UnaryExpr: // e.g. ...&value, ...&value.id
if bw.isAccessingRangeValueAddress(e) {
bw.onFailure(bw.newFailure(e))
}
@ -100,8 +100,21 @@ func (bw rangeBodyVisitor) isAccessingRangeValueAddress(exp ast.Expr) bool {
return false
}
if u.Op != token.AND {
return false
}
v, ok := u.X.(*ast.Ident)
return ok && u.Op == token.AND && v.Obj == bw.valueID
if !ok {
var s *ast.SelectorExpr
s, ok = u.X.(*ast.SelectorExpr)
if !ok {
return false
}
v, ok = s.X.(*ast.Ident)
}
return ok && v.Obj == bw.valueID
}
func (bw rangeBodyVisitor) newFailure(node ast.Node) lint.Failure {

3
rule/string-format.go
View File

@ -30,11 +30,12 @@ func (r *StringFormatRule) Apply(file *lint.File, arguments lint.Arguments) []li
return failures
}
// Name returns the rule name.
func (r *StringFormatRule) Name() string {
return "string-format"
}
// Public wrapper around w.parseArguments used for testing, returns the error message provided to panic, or nil if no error was encountered
// ParseArgumentsTest is a public wrapper around w.parseArguments used for testing. Returns the error message provided to panic, or nil if no error was encountered
func (r *StringFormatRule) ParseArgumentsTest(arguments lint.Arguments) *string {
w := lintStringFormatRule{}
c := make(chan interface{})

12
testdata/range-val-address.go vendored
View File

@ -45,3 +45,15 @@ func rangeValAddress5() {
m[&value] = value // MATCH /suspicious assignment of 'value'. range-loop variables always have the same address/
}
}
func rangeValAddress6() {
type v struct {
id string
}
m := []*string{}
mySlice := []v{{id: "A"}, {id: "B"}, {id: "C"}}
for _, value := range mySlice {
m = append(m, &value.id) // MATCH /suspicious assignment of 'value'. range-loop variables always have the same address/
}
}