go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

fix #1032 by comparing string representations of types (#1049)

Browse Source
This commit is contained in:
chavacava
2024-09-24 11:29:20 +02:00
committed by GitHub
parent 3249a5ef06
commit 4c3641ebc3
6 changed files with 22 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testdata/enforce-repeated-arg-type-style-mixed-full-short.go vendored
View File

@@ -2,5 +2,5 @@ package fixtures
func compliantFunc(a int, b int, c string) (x, y int, z string) // Must not match - compliant with rule
func nonCompliantFunc1(a int, b int, c string) (x int, y int, z string) { panic("implement me") } // MATCH /repeated return type can be omitted/
func nonCompliantFunc1(a int, b int, c string) (x int, y int, z string) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/
func nonCompliantFunc2(a, b int, c string) (x, y int, z string) { panic("implement me") } // MATCH /argument types should not be omitted/

2
testdata/enforce-repeated-arg-type-style-mixed-short-full.go vendored
View File

@@ -3,4 +3,4 @@ package fixtures
func compliantFunc(a, b int, c string) (x int, y int, z string) // Must not match - compliant with rule
func nonCompliantFunc1(a, b int, c string) (x, y int, z string) { panic("implement me") } // MATCH /return types should not be omitted/
func nonCompliantFunc2(a int, b int, c string) (x int, y int, z string) { panic("implement me") } // MATCH /repeated argument type can be omitted/
func nonCompliantFunc2(a int, b int, c string) (x int, y int, z string) { panic("implement me") } // MATCH /repeated argument type "int" can be omitted/

10
testdata/enforce-repeated-arg-type-style-short-args.go vendored
View File

@@ -2,15 +2,15 @@ package fixtures
func compliantFunc(a, b int, c string) {} // Must not match - compliant with rule
func nonCompliantFunc1(a int, b int, c string) {} // MATCH /repeated argument type can be omitted/
func nonCompliantFunc2(a int, b, c int) {} // MATCH /repeated argument type can be omitted/
func nonCompliantFunc1(a int, b int, c string) {} // MATCH /repeated argument type "int" can be omitted/
func nonCompliantFunc2(a int, b, c int) {} // MATCH /repeated argument type "int" can be omitted/
type myStruct struct{}
func (m myStruct) compliantMethod(a, b int, c string) {} // Must not match - compliant with rule
func (m myStruct) nonCompliantMethod1(a int, b int, c string) {} // MATCH /repeated argument type can be omitted/
func (m myStruct) nonCompliantMethod2(a int, b, c int) {} // MATCH /repeated argument type can be omitted/
func (m myStruct) nonCompliantMethod1(a int, b int, c string) {} // MATCH /repeated argument type "int" can be omitted/
func (m myStruct) nonCompliantMethod2(a int, b, c int) {} // MATCH /repeated argument type "int" can be omitted/
func variadicFunction(a int, b ...int) {} // Must not match - variadic parameters are a special case
@@ -18,4 +18,4 @@ func singleArgFunction(a int) {} // Must not match - only one argument
func multiTypeArgs(a int, b string, c float64) {} // Must not match - different types for each argument
func mixedCompliance(a, b int, c int, d string) {} // MATCH /repeated argument type can be omitted/ - 'c int' could be combined with 'a, b int'
func mixedCompliance(a, b int, c int, d string) {} // MATCH /repeated argument type "int" can be omitted/ - 'c int' could be combined with 'a, b int'

10
testdata/enforce-repeated-arg-type-style-short-return.go vendored
View File

@@ -3,18 +3,18 @@ package fixtures
func compliantFunc() (a, b int, c string) { panic("implement me") } // Must not match - compliant with rule
func compliantFunc2() (int, int, string) // Must not match - compliant with rule
func nonCompliantFunc1() (a int, b int, c string) { panic("implement me") } // MATCH /repeated return type can be omitted/
func nonCompliantFunc2() (a int, b, c int) { panic("implement me") } // MATCH /repeated return type can be omitted/
func nonCompliantFunc1() (a int, b int, c string) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/
func nonCompliantFunc2() (a int, b, c int) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/
type myStruct struct{}
func (m myStruct) compliantMethod() (a, b int, c string) { panic("implement me") } // Must not match - compliant with rule
func (m myStruct) nonCompliantMethod1() (a int, b int, c string) { panic("implement me") } // MATCH /repeated return type can be omitted/
func (m myStruct) nonCompliantMethod2() (a int, b, c int) { panic("implement me") } // MATCH /repeated return type can be omitted/
func (m myStruct) nonCompliantMethod1() (a int, b int, c string) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/
func (m myStruct) nonCompliantMethod2() (a int, b, c int) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/
func singleArgFunction() (a int) { panic("implement me") } // Must not match - only one return
func multiTypeArgs() (a int, b string, c float64) { panic("implement me") } // Must not match - different types for each return
func mixedCompliance() (a, b int, c int, d string) { panic("implement me") } // MATCH /repeated return type can be omitted/ - 'c int' could be combined with 'a, b int'
func mixedCompliance() (a, b int, c int, d string) { panic("implement me") } // MATCH /repeated return type "int" can be omitted/ - 'c int' could be combined with 'a, b int'