go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

Add optimize-operands-order rule (#599) (#603)

Browse Source 
Co-authored-by: SalvadorC <salvadorcavadini+github@gmail.com>
This commit is contained in:
doniacld
2021-10-23 09:29:14 +02:00
committed by GitHub
parent 8a3653ca49
commit 5d04216294
7 changed files with 139 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
testdata/optimize-operands-order.go vendored Normal file
View File

@@ -0,0 +1,32 @@
package fixtures
func conditionalExpr(x, y bool) bool {
equal := x == y // should not match, not AND or OR operators
if x || y { // should not match, no caller
return true
}
or := caller(x, y) || y // MATCH /for better performance 'caller(x, y) || y' might be rewritten as 'y || caller(x, y)'/
if caller(x, y) || y { // MATCH /for better performance 'caller(x, y) || y' might be rewritten as 'y || caller(x, y)'/
return true
}
switch {
case x == y:
return y
case caller(x, y) && y: // MATCH /for better performance 'caller(x, y) && y' might be rewritten as 'y && caller(x, y)'/
return x
}
complexExpr := caller(caller(x, y) && y, y) || y
// MATCH:20 /for better performance 'caller(caller(x, y) && y, y) || y' might be rewritten as 'y || caller(caller(x, y) && y, y)'/
// MATCH:20 /for better performance 'caller(x, y) && y' might be rewritten as 'y && caller(x, y)'/
noSwap := caller(x, y) || (x && caller(y, x)) // should not match, caller in the right operand
callRight := caller(x, y) && (x && caller(y, x)) // should not match, caller in the right operand
return caller(x, y) && y // MATCH /for better performance 'caller(x, y) && y' might be rewritten as 'y && caller(x, y)'/
}
func caller(x, y bool) bool {
return true
}