go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Code Issues Releases Activity

fix: error-strings custom funcs overwrites defaults (#1249)

Browse Source
This commit is contained in:
Oleksandr Redko
2025-02-26 23:16:06 +02:00
committed by GitHub
parent 9177f5044a
commit 67d0a61a1b
4 changed files with 98 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
rule/error_strings.go
View File

@@ -37,14 +37,19 @@ func (r *ErrorStringsRule) Configure(arguments lint.Arguments) error {
var invalidCustomFunctions []string
for _, argument := range arguments {
if functionName, ok := argument.(string); ok {
fields := strings.Split(strings.TrimSpace(functionName), ".")
if len(fields) != 2 || len(fields[0]) == 0 || len(fields[1]) == 0 {
invalidCustomFunctions = append(invalidCustomFunctions, functionName)
continue
}
r.errorFunctions[fields[0]] = map[string]struct{}{fields[1]: {}}
pkgFunction, ok := argument.(string)
if !ok {
continue
}
pkg, function, ok := strings.Cut(strings.TrimSpace(pkgFunction), ".")
if !ok || pkg == "" || function == "" {
invalidCustomFunctions = append(invalidCustomFunctions, pkgFunction)
continue
}
if _, ok := r.errorFunctions[pkg]; !ok {
r.errorFunctions[pkg] = map[string]struct{}{}
}
r.errorFunctions[pkg][function] = struct{}{}
}
if len(invalidCustomFunctions) != 0 {
return fmt.Errorf("found invalid custom function: %s", strings.Join(invalidCustomFunctions, ","))