go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-07-05 00:28:53 +02:00
Code Issues Releases Activity

Add revive linting action and fix linting errors (#455)

Browse Source
This commit is contained in:
Minko Gechev
2020-08-15 00:50:13 +03:00
committed by GitHub
parent 0aef3046fa
commit 688024a5ca
7 changed files with 36 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
rule/unconditional-recursion.go
View File

@ -28,12 +28,12 @@ func (r *UnconditionalRecursionRule) Name() string {
}
type funcDesc struct {
reciverId *ast.Ident
reciverID *ast.Ident
id *ast.Ident
}
func (fd *funcDesc) equal(other *funcDesc) bool {
receiversAreEqual := (fd.reciverId == nil && other.reciverId == nil) || fd.reciverId != nil && other.reciverId != nil && fd.reciverId.Name == other.reciverId.Name
receiversAreEqual := (fd.reciverID == nil && other.reciverID == nil) || fd.reciverID != nil && other.reciverID != nil && fd.reciverID.Name == other.reciverID.Name
idsAreEqual := (fd.id == nil && other.id == nil) || fd.id.Name == other.id.Name
return receiversAreEqual && idsAreEqual
@ -69,26 +69,26 @@ func (w lintUnconditionalRecursionRule) Visit(node ast.Node) ast.Visitor {
w.currentFunc = &funcStatus{&funcDesc{rec, n.Name}, false}
case *ast.CallExpr:
var funcId *ast.Ident
var funcID *ast.Ident
var selector *ast.Ident
switch c := n.Fun.(type) {
case *ast.Ident:
selector = nil
funcId = c
funcID = c
case *ast.SelectorExpr:
var ok bool
selector, ok = c.X.(*ast.Ident)
if !ok { // a.b....Foo()
return nil
}
funcId = c.Sel
funcID = c.Sel
default:
return w
}
if w.currentFunc != nil && // not in a func body
!w.currentFunc.seenConditionalExit && // there is a conditional exit in the function
w.currentFunc.funcDesc.equal(&funcDesc{selector, funcId}) {
w.currentFunc.funcDesc.equal(&funcDesc{selector, funcID}) {
w.onFailure(lint.Failure{
Category: "logic",
Confidence: 1,