From 6db615d0bbf2b624783be7abf6602571bbe6e16c Mon Sep 17 00:00:00 2001 From: mgechev Date: Sun, 27 Aug 2017 21:03:59 -0700 Subject: [PATCH] Refactor --- defaultrules/no-else-return-rule.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/defaultrules/no-else-return-rule.go b/defaultrules/no-else-return-rule.go index 526b66d..c15893c 100644 --- a/defaultrules/no-else-return-rule.go +++ b/defaultrules/no-else-return-rule.go @@ -9,7 +9,10 @@ import ( "github.com/mgechev/revive/visitors" ) -const ruleName = "no-else-return" +const ( + ruleName = "no-else-return" + failure = "if block ends with a return statement, so drop this else and outdent its block" +) // LintElseRule lints given else constructs. type LintElseRule struct { @@ -48,7 +51,7 @@ func (w *lintElseVisitor) VisitIfStmt(node *ast.IfStmt) { lastStmt := node.Body.List[len(node.Body.List)-1] if _, ok := lastStmt.(*ast.ReturnStmt); ok { w.AddFailure(rules.Failure{ - Failure: "if block ends with a return statement, so drop this else and outdent its block", + Failure: failure, Type: rules.FailureTypeWarning, Position: w.GetPosition(node.Else.Pos(), node.Else.End()), })