go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Code Issues Releases Activity

feature: new rule unnecessary-if (#1520)

Browse Source
This commit is contained in:
chavacava
2025-09-22 19:07:45 +02:00
committed by GitHub
parent 3220c1f04e
commit 79e63ae064
6 changed files with 403 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

153
testdata/unnecessary_if.go vendored Normal file
View File

@@ -0,0 +1,153 @@
package fixtures
func unnecessaryIf() bool {
var cond bool
var id bool
// test return replacements
if cond { // MATCH /replace this conditional by: return cond/
return true
} else {
return false
}
if cond { // MATCH /replace this conditional by: return !(cond)/
return false
} else {
return true
}
// test assignment replacements
if cond { // MATCH /replace this conditional by: id = cond/
id = true
} else {
id = false
}
if cond { // MATCH /replace this conditional by: id = !(cond)/
id = false
} else {
id = true
}
// test suggestions for (in)equalities
//// assignments
if cond == id { // MATCH /replace this conditional by: id = cond == id/
id = true
} else {
id = false
}
if cond == id { // MATCH /replace this conditional by: id = cond != id/
id = false
} else {
id = true
}
if cond != id { // MATCH /replace this conditional by: id = cond != id/
id = true
} else {
id = false
}
if cond != id { // MATCH /replace this conditional by: id = cond == id/
id = false
} else {
id = true
}
//// return
if cond == id { // MATCH /replace this conditional by: return cond == id/
return true
} else {
return false
}
if cond == id { // MATCH /replace this conditional by: return cond != id/
return false
} else {
return true
}
if cond != id { // MATCH /replace this conditional by: return cond != id/
return true
} else {
return false
}
if cond != id { // MATCH /replace this conditional by: return cond == id/
return false
} else {
return true
}
//// assignments
if cond <= id { // MATCH /replace this conditional by: id = cond <= id/
id = true
} else {
id = false
}
if cond <= id { // MATCH /replace this conditional by: id = cond > id/
id = false
} else {
id = true
}
if cond >= id { // MATCH /replace this conditional by: id = cond >= id/
id = true
} else {
id = false
}
if cond >= id { // MATCH /replace this conditional by: id = cond < id/
id = false
} else {
id = true
}
if cond > id { // MATCH /replace this conditional by: id = cond > id/
id = true
} else {
id = false
}
if cond > id { // MATCH /replace this conditional by: id = cond <= id/
id = false
} else {
id = true
}
if cond < id { // MATCH /replace this conditional by: id = cond < id/
id = true
} else {
id = false
}
if cond < id { // MATCH /replace this conditional by: id = cond >= id/
id = false
} else {
id = true
}
if (something > 0) && (!id) || (something+10 <= 0) { // MATCH /replace this conditional by: id = !((something > 0) && (!id) || (something+10 <= 0))/
id = false
} else {
id = true
}
// conditionals with initialization
if cond := false; cond {
return true
} else {
return false
}
if cond := false; cond {
id = true
} else {
id = false
}
return id == id
}