diff --git a/rule/modifies-value-receiver.go b/rule/modifies-value-receiver.go index ae260a9..e9e64b9 100644 --- a/rule/modifies-value-receiver.go +++ b/rule/modifies-value-receiver.go @@ -78,11 +78,6 @@ func (w lintModifiesValRecRule) Visit(node ast.Node) ast.Visitor { if name == "" || name != receiverName { continue } - - if w.skipType(ast.Expr(e.Sel)) { - continue - } - case *ast.Ident: // receiver := ... if e.Name != receiverName { continue diff --git a/testdata/modifies-value-receiver.go b/testdata/modifies-value-receiver.go index e7355a4..b5ae877 100644 --- a/testdata/modifies-value-receiver.go +++ b/testdata/modifies-value-receiver.go @@ -9,5 +9,6 @@ type data struct { func (this data) vmethod() { this.num = 8 // MATCH /suspicious assignment to a by-value method receiver/ *this.key = "v.key" + this.items = make(map[string]bool) // MATCH /suspicious assignment to a by-value method receiver/ this.items["vmethod"] = true }