From 2474f6cecbdc5cb5c507a237972211e48851970a Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Sun, 21 Apr 2019 19:13:03 +0200 Subject: [PATCH 01/74] simpler and more efficient implementation of unused-parameter (#121) --- rule/unused-param.go | 236 ++++++++------------------------------ test/unused-param_test.go | 7 ++ 2 files changed, 55 insertions(+), 188 deletions(-) diff --git a/rule/unused-param.go b/rule/unused-param.go index f4de228..60df908 100644 --- a/rule/unused-param.go +++ b/rule/unused-param.go @@ -3,7 +3,6 @@ package rule import ( "fmt" "go/ast" - "go/token" "github.com/mgechev/revive/lint" ) @@ -38,205 +37,66 @@ type lintUnusedParamRule struct { func (w lintUnusedParamRule) Visit(node ast.Node) ast.Visitor { switch n := node.(type) { case *ast.FuncDecl: - fv := newFuncVisitor(retrieveNamedParams(n.Type.Params.List)) - if n.Body != nil { - ast.Walk(fv, n.Body) - checkUnusedParams(w, fv.params, n) + params := retrieveNamedParams(n.Type.Params) + if len(params) < 1 { + return nil // skip, func without parameters } - return nil + + if n.Body == nil { + return nil // skip, is a function prototype + } + + // inspect the func body looking for references to parameters + fselect := func(n ast.Node) bool { + ident, isAnID := n.(*ast.Ident) + + if !isAnID { + return false + } + + _, isAParam := params[ident.Obj] + if isAParam { + params[ident.Obj] = false // mark as used + } + + return false + } + _ = pick(n.Body, fselect, nil) + + for _, p := range n.Type.Params.List { + for _, n := range p.Names { + if params[n.Obj] { + w.onFailure(lint.Failure{ + Confidence: 1, + Node: n, + Category: "bad practice", + Failure: fmt.Sprintf("parameter '%s' seems to be unused, consider removing or renaming it as _", n.Name), + }) + } + } + } + + return nil // full method body already inspected } return w } -type scope struct { - vars map[string]bool -} - -func newScope() scope { - return scope{make(map[string]bool, 0)} -} - -func (s *scope) addVars(exps []ast.Expr) { - for _, e := range exps { - if id, ok := e.(*ast.Ident); ok { - s.vars[id.Name] = true - } - } -} - -type scopeStack struct { - stk []scope -} - -func (s *scopeStack) openScope() { - s.stk = append(s.stk, newScope()) -} - -func (s *scopeStack) closeScope() { - if len(s.stk) > 0 { - s.stk = s.stk[:len(s.stk)-1] - } -} - -func (s *scopeStack) currentScope() scope { - if len(s.stk) > 0 { - return s.stk[len(s.stk)-1] +func retrieveNamedParams(params *ast.FieldList) map[*ast.Object]bool { + result := map[*ast.Object]bool{} + if params.List == nil { + return result } - panic("no current scope") -} - -func newScopeStack() scopeStack { - return scopeStack{make([]scope, 0)} -} - -type funcVisitor struct { - sStk scopeStack - params map[string]bool -} - -func newFuncVisitor(params map[string]bool) funcVisitor { - return funcVisitor{sStk: newScopeStack(), params: params} -} - -func walkStmtList(v ast.Visitor, list []ast.Stmt) { - for _, s := range list { - ast.Walk(v, s) - } -} - -func (v funcVisitor) Visit(node ast.Node) ast.Visitor { - varSelector := func(n ast.Node) bool { - id, ok := n.(*ast.Ident) - return ok && id.Obj != nil && id.Obj.Kind.String() == "var" - } - switch n := node.(type) { - case *ast.BlockStmt: - v.sStk.openScope() - walkStmtList(v, n.List) - v.sStk.closeScope() - return nil - case *ast.AssignStmt: - var uses []ast.Node - if isOpAssign(n.Tok) { // Case of id += expr - uses = append(uses, pickFromExpList(n.Lhs, varSelector, nil)...) - } else { // Case of id[expr] = expr - indexSelector := func(n ast.Node) bool { - _, ok := n.(*ast.IndexExpr) - return ok - } - f := func(n ast.Node) []ast.Node { - ie, ok := n.(*ast.IndexExpr) - if !ok { // not possible - return nil - } - - return pick(ie.Index, varSelector, nil) - } - - uses = append(uses, pickFromExpList(n.Lhs, indexSelector, f)...) - } - - uses = append(uses, pickFromExpList(n.Rhs, varSelector, nil)...) - - markParamListAsUsed(uses, v) - cs := v.sStk.currentScope() - cs.addVars(n.Lhs) - case *ast.Ident: - if n.Obj != nil { - if n.Obj.Kind.String() == "var" { - markParamAsUsed(n, v) - } - } - case *ast.ForStmt: - v.sStk.openScope() - if n.Init != nil { - ast.Walk(v, n.Init) - } - uses := pickFromExpList([]ast.Expr{n.Cond}, varSelector, nil) - markParamListAsUsed(uses, v) - ast.Walk(v, n.Body) - v.sStk.closeScope() - return nil - case *ast.SwitchStmt: - v.sStk.openScope() - if n.Init != nil { - ast.Walk(v, n.Init) - } - uses := pickFromExpList([]ast.Expr{n.Tag}, varSelector, nil) - markParamListAsUsed(uses, v) - // Analyze cases (they are not BlockStmt but a list of Stmt) - cases := n.Body.List - for _, c := range cases { - cc, ok := c.(*ast.CaseClause) - if !ok { + for _, p := range params.List { + for _, n := range p.Names { + if n.Name == "_" { continue } - uses := pickFromExpList(cc.List, varSelector, nil) - markParamListAsUsed(uses, v) - v.sStk.openScope() - for _, stmt := range cc.Body { - ast.Walk(v, stmt) - } - v.sStk.closeScope() - } - v.sStk.closeScope() - return nil - } - - return v -} - -func retrieveNamedParams(pl []*ast.Field) map[string]bool { - result := make(map[string]bool, len(pl)) - for _, p := range pl { - for _, n := range p.Names { - if n.Name != "_" { - result[n.Name] = true - } + result[n.Obj] = true } } + return result } - -func checkUnusedParams(w lintUnusedParamRule, params map[string]bool, n *ast.FuncDecl) { - for k, v := range params { - if v { - w.onFailure(lint.Failure{ - Confidence: 0.8, // confidence is not 1.0 because of shadow variables - Node: n, - Category: "bad practice", - Failure: fmt.Sprintf("parameter '%s' seems to be unused, consider removing or renaming it as _", k), - }) - } - } - -} - -func markParamListAsUsed(ids []ast.Node, v funcVisitor) { - for _, id := range ids { - markParamAsUsed(id.(*ast.Ident), v) - } -} - -func markParamAsUsed(id *ast.Ident, v funcVisitor) { // TODO: constraint parameters to receive just a list of params and a scope stack - for _, s := range v.sStk.stk { - if s.vars[id.Name] { - return - } - } - - if v.params[id.Name] { - v.params[id.Name] = false - } -} - -func isOpAssign(aTok token.Token) bool { - return aTok == token.ADD_ASSIGN || aTok == token.AND_ASSIGN || - aTok == token.MUL_ASSIGN || aTok == token.OR_ASSIGN || - aTok == token.QUO_ASSIGN || aTok == token.REM_ASSIGN || - aTok == token.SHL_ASSIGN || aTok == token.SHR_ASSIGN || - aTok == token.SUB_ASSIGN || aTok == token.XOR_ASSIGN -} diff --git a/test/unused-param_test.go b/test/unused-param_test.go index c8b706b..7b6472c 100644 --- a/test/unused-param_test.go +++ b/test/unused-param_test.go @@ -9,3 +9,10 @@ import ( func TestUnusedParam(t *testing.T) { testRule(t, "unused-param", &rule.UnusedParamRule{}) } + +func BenchmarkUnusedParam(b *testing.B) { + var t *testing.T + for i := 0; i <= b.N; i++ { + testRule(t, "unused-param", &rule.UnusedParamRule{}) + } +} From e8c1baf8ac0e6b6cfbd041b0d10ea6aa93f654e6 Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Mon, 22 Apr 2019 19:58:02 +0200 Subject: [PATCH 02/74] optimizes import-blacklist (#123) --- rule/imports-blacklist.go | 49 ++++++++++++----------------------- test/import-blacklist_test.go | 10 +++++++ 2 files changed, 26 insertions(+), 33 deletions(-) diff --git a/rule/imports-blacklist.go b/rule/imports-blacklist.go index 3732083..31ef901 100644 --- a/rule/imports-blacklist.go +++ b/rule/imports-blacklist.go @@ -2,7 +2,6 @@ package rule import ( "fmt" - "go/ast" "github.com/mgechev/revive/lint" ) @@ -13,6 +12,11 @@ type ImportsBlacklistRule struct{} // Apply applies the rule to given file. func (r *ImportsBlacklistRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure { var failures []lint.Failure + + if file.IsTest() { + return failures // skip, test file + } + blacklist := make(map[string]bool, len(arguments)) for _, arg := range arguments { @@ -20,25 +24,25 @@ func (r *ImportsBlacklistRule) Apply(file *lint.File, arguments lint.Arguments) if !ok { panic(fmt.Sprintf("Invalid argument to the imports-blacklist rule. Expecting a string, got %T", arg)) } - // we add quotes if nt present, because when parsed, the value of the AST node, will be quoted + // we add quotes if not present, because when parsed, the value of the AST node, will be quoted if len(argStr) > 2 && argStr[0] != '"' && argStr[len(argStr)-1] != '"' { argStr = fmt.Sprintf(`"%s"`, argStr) } blacklist[argStr] = true } - fileAst := file.AST - walker := blacklistedImports{ - file: file, - fileAst: fileAst, - onFailure: func(failure lint.Failure) { - failures = append(failures, failure) - }, - blacklist: blacklist, + for _, is := range file.AST.Imports { + path := is.Path + if path != nil && blacklist[path.Value] { + failures = append(failures, lint.Failure{ + Confidence: 1, + Failure: "should not use the following blacklisted import: " + path.Value, + Node: is, + Category: "imports", + }) + } } - ast.Walk(walker, fileAst) - return failures } @@ -46,24 +50,3 @@ func (r *ImportsBlacklistRule) Apply(file *lint.File, arguments lint.Arguments) func (r *ImportsBlacklistRule) Name() string { return "imports-blacklist" } - -type blacklistedImports struct { - file *lint.File - fileAst *ast.File - onFailure func(lint.Failure) - blacklist map[string]bool -} - -func (w blacklistedImports) Visit(_ ast.Node) ast.Visitor { - for _, is := range w.fileAst.Imports { - if is.Path != nil && !w.file.IsTest() && w.blacklist[is.Path.Value] { - w.onFailure(lint.Failure{ - Confidence: 1, - Failure: fmt.Sprintf("should not use the following blacklisted import: %s", is.Path.Value), - Node: is, - Category: "imports", - }) - } - } - return nil -} diff --git a/test/import-blacklist_test.go b/test/import-blacklist_test.go index 6132b7b..d427f0b 100644 --- a/test/import-blacklist_test.go +++ b/test/import-blacklist_test.go @@ -14,3 +14,13 @@ func TestImportsBlacklist(t *testing.T) { Arguments: args, }) } + +func BenchmarkImportsBlacklist(b *testing.B) { + args := []interface{}{"crypto/md5", "crypto/sha1"} + var t *testing.T + for i := 0; i <= b.N; i++ { + testRule(t, "imports-blacklist", &rule.ImportsBlacklistRule{}, &lint.RuleConfig{ + Arguments: args, + }) + } +} From 8aa0cd8bd4e3a0b46e1ac64a2a5efd36b625ad24 Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Sun, 28 Apr 2019 04:23:17 +0200 Subject: [PATCH 03/74] unhandled-error (new rule) (#124) * unhandled-error (new rule) * better failure msg * encapsulates error type detection --- README.md | 1 + RULES_DESCRIPTIONS.md | 7 +++ config.go | 1 + fixtures/unhandled-error.go | 19 +++++++ rule/unhandled-error.go | 100 +++++++++++++++++++++++++++++++++++ test/unhandled-error_test.go | 11 ++++ 6 files changed, 139 insertions(+) create mode 100644 fixtures/unhandled-error.go create mode 100644 rule/unhandled-error.go create mode 100644 test/unhandled-error_test.go diff --git a/README.md b/README.md index 6301a34..2db1957 100644 --- a/README.md +++ b/README.md @@ -300,6 +300,7 @@ List of all available rules. The rules ported from `golint` are left unchanged a | [`import-shadowing`](./RULES_DESCRIPTIONS.md#import-shadowing) | n/a | Spots identifiers that shadow an import | no | no | | [`bare-return`](./RULES_DESCRIPTIONS#bare-return) | n/a | Warns on bare returns | no | no | | [`unused-receiver`](./RULES_DESCRIPTIONS.md#unused-receiver) | n/a | Suggests to rename or remove unused method receivers | no | no | +| [`unhandled-error`](./RULES_DESCRIPTIONS.md#unhandled-error) | n/a | Warns on unhandled errors returned by funcion calls | no | yes | ## Configurable rules diff --git a/RULES_DESCRIPTIONS.md b/RULES_DESCRIPTIONS.md index e4d6225..3c40712 100644 --- a/RULES_DESCRIPTIONS.md +++ b/RULES_DESCRIPTIONS.md @@ -51,6 +51,7 @@ List of all available rules. - [var-naming](#var-naming) - [var-declaration](#var-declaration) - [unexported-return](#unexported-return) + - [unhandled-error](#unhandled-error) - [unnecessary-stmt](#unnecessary-stmt) - [unreachable-code](#unreachable-code) - [unused-parameter](#unused-parameter) @@ -434,6 +435,12 @@ _Description_: This rule warns when an exported function or method returns a val _Configuration_: N/A +## unhandled-error + +_Description_: This rule warns when errors returned by a function are not explicitly handled on the caller side. + +_Configuration_: N/A + ## unnecessary-stmt _Description_: This rule suggests to remove redundant statements like a `break` at the end of a case block, for improving the code's readability. diff --git a/config.go b/config.go index f874326..a577641 100644 --- a/config.go +++ b/config.go @@ -77,6 +77,7 @@ var allRules = append([]lint.Rule{ &rule.ImportShadowingRule{}, &rule.BareReturnRule{}, &rule.UnusedReceiverRule{}, + &rule.UnhandledErrorRule{}, }, defaultRules...) var allFormatters = []lint.Formatter{ diff --git a/fixtures/unhandled-error.go b/fixtures/unhandled-error.go new file mode 100644 index 0000000..d3e9a45 --- /dev/null +++ b/fixtures/unhandled-error.go @@ -0,0 +1,19 @@ +package fixtures + +import ( + "fmt" + "os" +) + +func unhandledError1(a int) (int, error) { + return a, nil +} + +func unhandledError2() error { + _, err := unhandledError1(1) + unhandledError1(1) // MATCH /Unhandled error in call to function unhandledError1/ + fmt.Fprintf(nil, "") // MATCH /Unhandled error in call to function fmt.Fprintf/ + os.Chdir("..") // MATCH /Unhandled error in call to function os.Chdir/ + _ = os.Chdir("..") + return err +} diff --git a/rule/unhandled-error.go b/rule/unhandled-error.go new file mode 100644 index 0000000..8fc925d --- /dev/null +++ b/rule/unhandled-error.go @@ -0,0 +1,100 @@ +package rule + +import ( + "fmt" + "go/ast" + "go/types" + + "github.com/mgechev/revive/lint" +) + +// UnhandledErrorRule lints given else constructs. +type UnhandledErrorRule struct{} + +// Apply applies the rule to given file. +func (r *UnhandledErrorRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure { + var failures []lint.Failure + + walker := &lintUnhandledErrors{ + pkg: file.Pkg, + onFailure: func(failure lint.Failure) { + failures = append(failures, failure) + }, + } + + file.Pkg.TypeCheck() + ast.Walk(walker, file.AST) + + return failures +} + +// Name returns the rule name. +func (r *UnhandledErrorRule) Name() string { + return "unhandled-error" +} + +type lintUnhandledErrors struct { + pkg *lint.Package + onFailure func(lint.Failure) +} + +// Visit looks for statements that are function calls. +// If the called function returns a value of type error a failure will be created. +func (w *lintUnhandledErrors) Visit(node ast.Node) ast.Visitor { + switch n := node.(type) { + case *ast.ExprStmt: + fCall, ok := n.X.(*ast.CallExpr) + if !ok { + return nil // not a function call + } + + funcType := w.pkg.TypeOf(fCall) + if funcType == nil { + return nil // skip, type info not available + } + + switch t := funcType.(type) { + case *types.Named: + if !w.isTypeError(t) { + return nil // func call does not return an error + } + + w.addFailure(fCall) + default: + retTypes, ok := funcType.Underlying().(*types.Tuple) + if !ok { + return nil // skip, unable to retrieve return type of the called function + } + + if w.returnsAnError(retTypes) { + w.addFailure(fCall) + } + } + } + return w +} + +func (w *lintUnhandledErrors) addFailure(n *ast.CallExpr) { + w.onFailure(lint.Failure{ + Category: "bad practice", + Confidence: 1, + Node: n, + Failure: fmt.Sprintf("Unhandled error in call to function %v", gofmt(n.Fun)), + }) +} + +func (*lintUnhandledErrors) isTypeError(t *types.Named) bool { + const errorTypeName = "_.error" + + return t.Obj().Id() == errorTypeName +} + +func (w *lintUnhandledErrors) returnsAnError(tt *types.Tuple) bool { + for i := 0; i < tt.Len(); i++ { + nt, ok := tt.At(i).Type().(*types.Named) + if ok && w.isTypeError(nt) { + return true + } + } + return false +} diff --git a/test/unhandled-error_test.go b/test/unhandled-error_test.go new file mode 100644 index 0000000..7cef462 --- /dev/null +++ b/test/unhandled-error_test.go @@ -0,0 +1,11 @@ +package test + +import ( + "testing" + + "github.com/mgechev/revive/rule" +) + +func TestUnhandledError(t *testing.T) { + testRule(t, "unhandled-error", &rule.UnhandledErrorRule{}) +} From dbcb21608aba5244070a0900e4b3c1e59ef703f3 Mon Sep 17 00:00:00 2001 From: Pascal Masschelier Date: Mon, 29 Apr 2019 05:07:52 +0200 Subject: [PATCH 04/74] added sklearn to "Who uses revive" (#126) added line - [`sklearn`](https://github.com/pa-m/sklearn) - A partial port of scikit-learn written in Go --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 2db1957..c148292 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,7 @@ Here's how `revive` is different from `golint`: - [`aurora`](https://github.com/xuri/aurora) - aurora is a web-based Beanstalk queue server console written in Go - [`soar`](https://github.com/XiaoMi/soar) - SQL Optimizer And Rewriter - [`gorush`](https://github.com/appleboy/gorush) - A push notification server written in Go (Golang) +- [`sklearn`](https://github.com/pa-m/sklearn) - A partial port of scikit-learn written in Go *Open a PR to add your project*. From c8ee35a500c24a237840027c3b2695344fea93e5 Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Tue, 30 Apr 2019 04:56:12 +0200 Subject: [PATCH 05/74] adds blacklist to unhandled-error (#128) * adds blacklist for unhandled-error * uses ignoreList in place of blackList --- README.md | 2 +- RULES_DESCRIPTIONS.md | 8 ++++++- fixtures/unhandled-error-w-ignorelist.go | 19 +++++++++++++++ rule/unhandled-error.go | 30 ++++++++++++++++++++---- test/unhandled-error_test.go | 7 ++++++ 5 files changed, 59 insertions(+), 7 deletions(-) create mode 100644 fixtures/unhandled-error-w-ignorelist.go diff --git a/README.md b/README.md index c148292..374edfc 100644 --- a/README.md +++ b/README.md @@ -301,7 +301,7 @@ List of all available rules. The rules ported from `golint` are left unchanged a | [`import-shadowing`](./RULES_DESCRIPTIONS.md#import-shadowing) | n/a | Spots identifiers that shadow an import | no | no | | [`bare-return`](./RULES_DESCRIPTIONS#bare-return) | n/a | Warns on bare returns | no | no | | [`unused-receiver`](./RULES_DESCRIPTIONS.md#unused-receiver) | n/a | Suggests to rename or remove unused method receivers | no | no | -| [`unhandled-error`](./RULES_DESCRIPTIONS.md#unhandled-error) | n/a | Warns on unhandled errors returned by funcion calls | no | yes | +| [`unhandled-error`](./RULES_DESCRIPTIONS.md#unhandled-error) | []string | Warns on unhandled errors returned by funcion calls | no | yes | ## Configurable rules diff --git a/RULES_DESCRIPTIONS.md b/RULES_DESCRIPTIONS.md index 3c40712..8121ac1 100644 --- a/RULES_DESCRIPTIONS.md +++ b/RULES_DESCRIPTIONS.md @@ -439,8 +439,14 @@ _Configuration_: N/A _Description_: This rule warns when errors returned by a function are not explicitly handled on the caller side. -_Configuration_: N/A +_Configuration_: function names to ignore +Example: + +```toml +[unhandled-error] + arguments =["fmt.Printf", "myFunction"] +``` ## unnecessary-stmt _Description_: This rule suggests to remove redundant statements like a `break` at the end of a case block, for improving the code's readability. diff --git a/fixtures/unhandled-error-w-ignorelist.go b/fixtures/unhandled-error-w-ignorelist.go new file mode 100644 index 0000000..e157a83 --- /dev/null +++ b/fixtures/unhandled-error-w-ignorelist.go @@ -0,0 +1,19 @@ +package fixtures + +import ( + "fmt" + "os" +) + +func unhandledError1(a int) (int, error) { + return a, nil +} + +func unhandledError2() error { + _, err := unhandledError1(1) + unhandledError1(1) + fmt.Fprintf(nil, "") // MATCH /Unhandled error in call to function fmt.Fprintf/ + os.Chdir("..") + _ = os.Chdir("..") + return err +} diff --git a/rule/unhandled-error.go b/rule/unhandled-error.go index 8fc925d..0e2f628 100644 --- a/rule/unhandled-error.go +++ b/rule/unhandled-error.go @@ -11,12 +11,26 @@ import ( // UnhandledErrorRule lints given else constructs. type UnhandledErrorRule struct{} +type ignoreListType map[string]struct{} + // Apply applies the rule to given file. -func (r *UnhandledErrorRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure { +func (r *UnhandledErrorRule) Apply(file *lint.File, args lint.Arguments) []lint.Failure { var failures []lint.Failure + ignoreList := make(ignoreListType, len(args)) + + for _, arg := range args { + argStr, ok := arg.(string) + if !ok { + panic(fmt.Sprintf("Invalid argument to the unhandled-error rule. Expecting a string, got %T", arg)) + } + + ignoreList[argStr] = struct{}{} + } + walker := &lintUnhandledErrors{ - pkg: file.Pkg, + ignoreList: ignoreList, + pkg: file.Pkg, onFailure: func(failure lint.Failure) { failures = append(failures, failure) }, @@ -34,8 +48,9 @@ func (r *UnhandledErrorRule) Name() string { } type lintUnhandledErrors struct { - pkg *lint.Package - onFailure func(lint.Failure) + ignoreList ignoreListType + pkg *lint.Package + onFailure func(lint.Failure) } // Visit looks for statements that are function calls. @@ -75,11 +90,16 @@ func (w *lintUnhandledErrors) Visit(node ast.Node) ast.Visitor { } func (w *lintUnhandledErrors) addFailure(n *ast.CallExpr) { + funcName := gofmt(n.Fun) + if _, mustIgnore := w.ignoreList[funcName]; mustIgnore { + return + } + w.onFailure(lint.Failure{ Category: "bad practice", Confidence: 1, Node: n, - Failure: fmt.Sprintf("Unhandled error in call to function %v", gofmt(n.Fun)), + Failure: fmt.Sprintf("Unhandled error in call to function %v", funcName), }) } diff --git a/test/unhandled-error_test.go b/test/unhandled-error_test.go index 7cef462..a3a5cc3 100644 --- a/test/unhandled-error_test.go +++ b/test/unhandled-error_test.go @@ -3,9 +3,16 @@ package test import ( "testing" + "github.com/mgechev/revive/lint" "github.com/mgechev/revive/rule" ) func TestUnhandledError(t *testing.T) { testRule(t, "unhandled-error", &rule.UnhandledErrorRule{}) } + +func TestUnhandledErrorWithBlacklist(t *testing.T) { + args := []interface{}{"os.Chdir", "unhandledError1"} + + testRule(t, "unhandled-error-w-ignorelist", &rule.UnhandledErrorRule{}, &lint.RuleConfig{Arguments: args}) +} From 22b849f28677c27f97b9798a30a32f50ece6e81c Mon Sep 17 00:00:00 2001 From: Minko Gechev Date: Sat, 4 May 2019 19:35:21 -0600 Subject: [PATCH 06/74] docs: update the list of contributors --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 374edfc..7d34732 100644 --- a/README.md +++ b/README.md @@ -442,13 +442,13 @@ Currently, type checking is enabled by default. If you want to run the linter wi :---: |:---: |:---: |:---: |:---: |:---: | [mgechev](https://github.com/mgechev) |[chavacava](https://github.com/chavacava) |[xuri](https://github.com/xuri) |[gsamokovarov](https://github.com/gsamokovarov) |[morphy2k](https://github.com/morphy2k) |[tamird](https://github.com/tamird) | -[AragurDEV](https://github.com/AragurDEV) |[yangdiangzb](https://github.com/yangdiangzb) |[jamesmaidment](https://github.com/jamesmaidment) |[mapreal19](https://github.com/mapreal19) |[markelog](https://github.com/markelog) |[paul-at-start](https://github.com/paul-at-start) | +[AragurDEV](https://github.com/AragurDEV) |[yangdiangzb](https://github.com/yangdiangzb) |[jamesmaidment](https://github.com/jamesmaidment) |[mapreal19](https://github.com/mapreal19) |[markelog](https://github.com/markelog) |[pa-m](https://github.com/pa-m) | :---: |:---: |:---: |:---: |:---: |:---: | -[AragurDEV](https://github.com/AragurDEV) |[yangdiangzb](https://github.com/yangdiangzb) |[jamesmaidment](https://github.com/jamesmaidment) |[mapreal19](https://github.com/mapreal19) |[markelog](https://github.com/markelog) |[paul-at-start](https://github.com/paul-at-start) | +[AragurDEV](https://github.com/AragurDEV) |[yangdiangzb](https://github.com/yangdiangzb) |[jamesmaidment](https://github.com/jamesmaidment) |[mapreal19](https://github.com/mapreal19) |[markelog](https://github.com/markelog) |[pa-m](https://github.com/pa-m) | -[psapezhko](https://github.com/psapezhko) |[ridvansumset](https://github.com/ridvansumset) |[Jarema](https://github.com/Jarema) |[vkrol](https://github.com/vkrol) |[haya14busa](https://github.com/haya14busa) | -:---: |:---: |:---: |:---: |:---: | -[psapezhko](https://github.com/psapezhko) |[ridvansumset](https://github.com/ridvansumset) |[Jarema](https://github.com/Jarema) |[vkrol](https://github.com/vkrol) |[haya14busa](https://github.com/haya14busa) | +[paul-at-start](https://github.com/paul-at-start) |[psapezhko](https://github.com/psapezhko) |[ridvansumset](https://github.com/ridvansumset) |[Jarema](https://github.com/Jarema) |[vkrol](https://github.com/vkrol) |[haya14busa](https://github.com/haya14busa) | +:---: |:---: |:---: |:---: |:---: |:---: | +[paul-at-start](https://github.com/paul-at-start) |[psapezhko](https://github.com/psapezhko) |[ridvansumset](https://github.com/ridvansumset) |[Jarema](https://github.com/Jarema) |[vkrol](https://github.com/vkrol) |[haya14busa](https://github.com/haya14busa) | ## License From c967fd68eaa0c5a2c728586d1cf7f3ca8b528d32 Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Sat, 1 Jun 2019 10:34:43 +0200 Subject: [PATCH 07/74] struct-tag warns on private fields with tags (#131) --- fixtures/struct-tag.go | 4 ++++ rule/struct-tag.go | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/fixtures/struct-tag.go b/fixtures/struct-tag.go index 86f2447..b53c883 100644 --- a/fixtures/struct-tag.go +++ b/fixtures/struct-tag.go @@ -1,5 +1,7 @@ package fixtures +import "time" + type decodeAndValidateRequest struct { // BEAWRE : the flag of URLParam should match the const string URLParam URLParam string `json:"-" path:"url_param" validate:"numeric"` @@ -17,6 +19,8 @@ type decodeAndValidateRequest struct { MandatoryStruct4 mandatoryStruct `json:"mandatoryStruct" required:"false"` OptionalStruct *optionalStruct `json:"optionalStruct,omitempty"` OptionalQuery string `json:"-" querystring:"queryfoo"` + optionalQuery string `json:"-" querystring:"queryfoo"` // MATCH /tag on not-exported field optionalQuery/ + } type RangeAllocation struct { diff --git a/rule/struct-tag.go b/rule/struct-tag.go index 2ed1410..8335e0d 100644 --- a/rule/struct-tag.go +++ b/rule/struct-tag.go @@ -2,11 +2,12 @@ package rule import ( "fmt" - "github.com/fatih/structtag" - "github.com/mgechev/revive/lint" "go/ast" "strconv" "strings" + + "github.com/fatih/structtag" + "github.com/mgechev/revive/lint" ) // StructTagRule lints struct tags. @@ -58,6 +59,10 @@ func (w lintStructTagRule) Visit(node ast.Node) ast.Visitor { // checkTaggedField checks the tag of the given field. // precondition: the field has a tag func (w lintStructTagRule) checkTaggedField(f *ast.Field) { + if len(f.Names) > 0 && !f.Names[0].IsExported() { + w.addFailure(f, "tag on not-exported field "+f.Names[0].Name) + } + tags, err := structtag.Parse(strings.Trim(f.Tag.Value, "`")) if err != nil || tags == nil { w.addFailure(f.Tag, "malformed tag") From f1d75c05f5864ba031ab1180ff84030a17932ddf Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Mon, 3 Jun 2019 14:25:59 +0200 Subject: [PATCH 08/74] chore(deps): add renovate.json (#132) --- renovate.json | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 renovate.json diff --git a/renovate.json b/renovate.json new file mode 100644 index 0000000..f45d8f1 --- /dev/null +++ b/renovate.json @@ -0,0 +1,5 @@ +{ + "extends": [ + "config:base" + ] +} From c5e9877a561d0cac008fd5365042d35de7f8778b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Mon, 3 Jun 2019 14:36:28 +0200 Subject: [PATCH 09/74] chore(deps): update github.com/mgechev/dots commit hash to 18fa4c4 (#133) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 48b56cf..f81c26b 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/mattn/go-colorable v0.0.9 // indirect github.com/mattn/go-isatty v0.0.4 // indirect github.com/mattn/go-runewidth v0.0.3 // indirect - github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757 + github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc github.com/pkg/errors v0.8.0 golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e // indirect diff --git a/go.sum b/go.sum index 3f3de89..9f31098 100644 --- a/go.sum +++ b/go.sum @@ -12,6 +12,8 @@ github.com/mattn/go-runewidth v0.0.3 h1:a+kO+98RDGEfo6asOGMmpodZq4FNtnGP54yps8Bz github.com/mattn/go-runewidth v0.0.3/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU= github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757 h1:KTwJ7Lo3KDKMknRYN5JEFRGIM4IkG59QjFFM2mxsMEU= github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757/go.mod h1:KQ7+USdGKfpPjXk4Ga+5XxQM4Lm4e3gAogrreFAYpOg= +github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc h1:ErGdrZWM/CrAz0FVwcznlAScsmr2pdSMMPMwFL9TNmw= +github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc/go.mod h1:KQ7+USdGKfpPjXk4Ga+5XxQM4Lm4e3gAogrreFAYpOg= github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc h1:rQ1O4ZLYR2xXHXgBCCfIIGnuZ0lidMQw2S5n1oOv+Wg= github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc/go.mod h1:vsDQFd/mU46D+Z4whnwzcISnGGzXWMclvtLoiIKAKIo= github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw= From 8056651f8f932c6f1171e2dd09c971696fbacd37 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Mon, 3 Jun 2019 14:41:57 +0200 Subject: [PATCH 10/74] chore(deps): update golang.org/x/sys commit hash to 4c4f7f3 (#134) --- go.mod | 2 +- go.sum | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index f81c26b..f8926d1 100644 --- a/go.mod +++ b/go.mod @@ -10,6 +10,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc github.com/pkg/errors v0.8.0 - golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e // indirect + golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 ) diff --git a/go.sum b/go.sum index 9f31098..fe2a8b8 100644 --- a/go.sum +++ b/go.sum @@ -20,5 +20,6 @@ github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e h1:o3PsSEY8E4eXWkXrIP9YJALUkVZqzHJT5DOasTyn8Vs= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From de6c8e5f22fe321934fc4484fc6be0bba7d081cf Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 01:10:22 +0200 Subject: [PATCH 11/74] chore(deps): update module pkg/errors to v0.8.1 (#141) --- go.mod | 2 +- go.sum | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index f8926d1..eb5f4c6 100644 --- a/go.mod +++ b/go.mod @@ -9,7 +9,7 @@ require ( github.com/mattn/go-runewidth v0.0.3 // indirect github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc - github.com/pkg/errors v0.8.0 + github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 ) diff --git a/go.sum b/go.sum index fe2a8b8..09998b5 100644 --- a/go.sum +++ b/go.sum @@ -18,6 +18,7 @@ github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc h1:rQ1O4ZLY github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc/go.mod h1:vsDQFd/mU46D+Z4whnwzcISnGGzXWMclvtLoiIKAKIo= github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= +github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e h1:o3PsSEY8E4eXWkXrIP9YJALUkVZqzHJT5DOasTyn8Vs= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= From e221038ef3c6c8f42af98eeeb9187e77a9487687 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 01:10:43 +0200 Subject: [PATCH 12/74] chore(deps): update module mattn/go-colorable to v0.1.2 (#137) --- go.mod | 3 +-- go.sum | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/go.mod b/go.mod index eb5f4c6..3ac8b40 100644 --- a/go.mod +++ b/go.mod @@ -4,8 +4,7 @@ require ( github.com/BurntSushi/toml v0.3.0 github.com/fatih/color v1.7.0 github.com/fatih/structtag v1.0.0 - github.com/mattn/go-colorable v0.0.9 // indirect - github.com/mattn/go-isatty v0.0.4 // indirect + github.com/mattn/go-colorable v0.1.2 // indirect github.com/mattn/go-runewidth v0.0.3 // indirect github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc diff --git a/go.sum b/go.sum index 09998b5..eebced5 100644 --- a/go.sum +++ b/go.sum @@ -6,8 +6,12 @@ github.com/fatih/structtag v1.0.0 h1:pTHj65+u3RKWYPSGaU290FpI/dXxTaHdVwVwbcPKmEc github.com/fatih/structtag v1.0.0/go.mod h1:IKitwq45uXL/yqi5mYghiD3w9H6eTOvI9vnk8tXMphA= github.com/mattn/go-colorable v0.0.9 h1:UVL0vNpWh04HeJXV0KLcaT7r06gOH2l4OW6ddYRUIY4= github.com/mattn/go-colorable v0.0.9/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaOChaDxuIBZU= +github.com/mattn/go-colorable v0.1.2 h1:/bC9yWikZXAL9uJdulbSfyVNIR3n3trXl+v8+1sx8mU= +github.com/mattn/go-colorable v0.1.2/go.mod h1:U0ppj6V5qS13XJ6of8GYAs25YV2eR4EVcfRqFIhoBtE= github.com/mattn/go-isatty v0.0.4 h1:bnP0vzxcAdeI1zdubAl5PjU6zsERjGZb7raWodagDYs= github.com/mattn/go-isatty v0.0.4/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4= +github.com/mattn/go-isatty v0.0.8 h1:HLtExJ+uU2HOZ+wI0Tt5DtUDrx8yhUqDcp7fYERX4CE= +github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s= github.com/mattn/go-runewidth v0.0.3 h1:a+kO+98RDGEfo6asOGMmpodZq4FNtnGP54yps8BzLR4= github.com/mattn/go-runewidth v0.0.3/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU= github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757 h1:KTwJ7Lo3KDKMknRYN5JEFRGIM4IkG59QjFFM2mxsMEU= @@ -21,6 +25,8 @@ github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e h1:o3PsSEY8E4eXWkXrIP9YJALUkVZqzHJT5DOasTyn8Vs= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed h1:Lf5SX+bXEwoj3Y6Nfu5qtffzOXhPQA9REb2R5W4nGP8= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From f5dadd67341f9e55cf5aa17f81d01614cd70b8bf Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 09:16:53 +0200 Subject: [PATCH 13/74] chore(deps): update golang.org/x/tools commit hash to 8aaa148 (#135) --- go.mod | 2 +- go.sum | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3ac8b40..c43fa66 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect - golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 + golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 ) diff --git a/go.sum b/go.sum index eebced5..760e74e 100644 --- a/go.sum +++ b/go.sum @@ -23,10 +23,17 @@ github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc/go.mod h1:v github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= +golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= +golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e h1:o3PsSEY8E4eXWkXrIP9YJALUkVZqzHJT5DOasTyn8Vs= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed h1:Lf5SX+bXEwoj3Y6Nfu5qtffzOXhPQA9REb2R5W4nGP8= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= +golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 h1:VULJh5DQg4Inr1Xiypf4pj72xB4lPJdiUgV2Ra5M8og= +golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From a9c3669cb93163b5b57f4da4694d76e3c4edf27e Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 09:17:17 +0200 Subject: [PATCH 14/74] chore(deps): update module mattn/go-runewidth to v0.0.4 (#139) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c43fa66..85e8193 100644 --- a/go.mod +++ b/go.mod @@ -5,7 +5,7 @@ require ( github.com/fatih/color v1.7.0 github.com/fatih/structtag v1.0.0 github.com/mattn/go-colorable v0.1.2 // indirect - github.com/mattn/go-runewidth v0.0.3 // indirect + github.com/mattn/go-runewidth v0.0.4 // indirect github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc github.com/pkg/errors v0.8.1 diff --git a/go.sum b/go.sum index 760e74e..8ff03b2 100644 --- a/go.sum +++ b/go.sum @@ -14,6 +14,8 @@ github.com/mattn/go-isatty v0.0.8 h1:HLtExJ+uU2HOZ+wI0Tt5DtUDrx8yhUqDcp7fYERX4CE github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s= github.com/mattn/go-runewidth v0.0.3 h1:a+kO+98RDGEfo6asOGMmpodZq4FNtnGP54yps8BzLR4= github.com/mattn/go-runewidth v0.0.3/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU= +github.com/mattn/go-runewidth v0.0.4 h1:2BvfKmzob6Bmd4YsL0zygOqfdFnK7GR4QL06Do4/p7Y= +github.com/mattn/go-runewidth v0.0.4/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU= github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757 h1:KTwJ7Lo3KDKMknRYN5JEFRGIM4IkG59QjFFM2mxsMEU= github.com/mgechev/dots v0.0.0-20180605013149-8e09d8ea2757/go.mod h1:KQ7+USdGKfpPjXk4Ga+5XxQM4Lm4e3gAogrreFAYpOg= github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc h1:ErGdrZWM/CrAz0FVwcznlAScsmr2pdSMMPMwFL9TNmw= From 7e63bbd126e9788d59083788cee2d8672c44c09d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 09:17:44 +0200 Subject: [PATCH 15/74] chore(deps): update module burntsushi/toml to v0.3.1 (#136) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 85e8193..8a088a5 100644 --- a/go.mod +++ b/go.mod @@ -1,7 +1,7 @@ module github.com/mgechev/revive require ( - github.com/BurntSushi/toml v0.3.0 + github.com/BurntSushi/toml v0.3.1 github.com/fatih/color v1.7.0 github.com/fatih/structtag v1.0.0 github.com/mattn/go-colorable v0.1.2 // indirect diff --git a/go.sum b/go.sum index 8ff03b2..d31b046 100644 --- a/go.sum +++ b/go.sum @@ -1,5 +1,7 @@ github.com/BurntSushi/toml v0.3.0 h1:e1/Ivsx3Z0FVTV0NSOv/aVgbUWyQuzj7DDnFblkRvsY= github.com/BurntSushi/toml v0.3.0/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= +github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ= +github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys= github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4= github.com/fatih/structtag v1.0.0 h1:pTHj65+u3RKWYPSGaU290FpI/dXxTaHdVwVwbcPKmEc= From fde2ca1939621ba79fc8b081818c09365dec0f34 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 4 Jun 2019 09:22:31 +0200 Subject: [PATCH 16/74] chore(deps): update module olekukonko/tablewriter to v0.0.1 (#140) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 8a088a5..b321028 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/mattn/go-colorable v0.1.2 // indirect github.com/mattn/go-runewidth v0.0.4 // indirect github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc - github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc + github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 diff --git a/go.sum b/go.sum index d31b046..78316f2 100644 --- a/go.sum +++ b/go.sum @@ -24,6 +24,8 @@ github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc h1:ErGdrZWM/CrAz0FVwc github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc/go.mod h1:KQ7+USdGKfpPjXk4Ga+5XxQM4Lm4e3gAogrreFAYpOg= github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc h1:rQ1O4ZLYR2xXHXgBCCfIIGnuZ0lidMQw2S5n1oOv+Wg= github.com/olekukonko/tablewriter v0.0.0-20180912035003-be2c049b30cc/go.mod h1:vsDQFd/mU46D+Z4whnwzcISnGGzXWMclvtLoiIKAKIo= +github.com/olekukonko/tablewriter v0.0.1 h1:b3iUnf1v+ppJiOfNX4yxxqfWKMQPZR5yoh8urCTFX88= +github.com/olekukonko/tablewriter v0.0.1/go.mod h1:vsDQFd/mU46D+Z4whnwzcISnGGzXWMclvtLoiIKAKIo= github.com/pkg/errors v0.8.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= From 7ac9a99486e9b4b8534779c48f24b8c8b3f11a73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mario=20P=C3=A9rez=20Alarc=C3=B3n?= Date: Wed, 5 Jun 2019 14:00:45 +0200 Subject: [PATCH 17/74] docs(readme): Fixes links in rules --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7d34732..0570b37 100644 --- a/README.md +++ b/README.md @@ -297,9 +297,9 @@ List of all available rules. The rules ported from `golint` are left unchanged a | [`empty-lines`](./RULES_DESCRIPTIONS.md#empty-lines) | n/a | Warns when there are heading or trailing newlines in a block | no | no | | [`line-length-limit`](./RULES_DESCRIPTIONS.md#line-length-limit) | int | Specifies the maximum number of characters in a line | no | no | | [`call-to-gc`](./RULES_DESCRIPTIONS.md#call-to-gc) | n/a | Warns on explicit call to the garbage collector | no | no | -| [`duplicated-imports`](./RULES_DESCRIPTIONS#duplicated-imports) | n/a | Looks for packages that are imported two or more times | no | no | +| [`duplicated-imports`](./RULES_DESCRIPTIONS.md#duplicated-imports) | n/a | Looks for packages that are imported two or more times | no | no | | [`import-shadowing`](./RULES_DESCRIPTIONS.md#import-shadowing) | n/a | Spots identifiers that shadow an import | no | no | -| [`bare-return`](./RULES_DESCRIPTIONS#bare-return) | n/a | Warns on bare returns | no | no | +| [`bare-return`](./RULES_DESCRIPTIONS.md#bare-return) | n/a | Warns on bare returns | no | no | | [`unused-receiver`](./RULES_DESCRIPTIONS.md#unused-receiver) | n/a | Suggests to rename or remove unused method receivers | no | no | | [`unhandled-error`](./RULES_DESCRIPTIONS.md#unhandled-error) | []string | Warns on unhandled errors returned by funcion calls | no | yes | From 1ebfe8b325ec48c7d73c1e094a97705d83ad80e6 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Thu, 6 Jun 2019 13:28:59 +0200 Subject: [PATCH 18/74] chore(deps): update golang.org/x/tools commit hash to 4d9ae51 (#143) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index b321028..13d5cd2 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect - golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 + golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 ) diff --git a/go.sum b/go.sum index 78316f2..0641e78 100644 --- a/go.sum +++ b/go.sum @@ -43,3 +43,5 @@ golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ER golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 h1:VULJh5DQg4Inr1Xiypf4pj72xB4lPJdiUgV2Ra5M8og= golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 h1:ousb8Vkhj77qYml3n9BuPuYaR6LnZyLh5LXB2qq8wzI= +golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From bf2da941c036913b145071ab4a2bcaa4f0a69f21 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Thu, 6 Jun 2019 15:20:19 +0200 Subject: [PATCH 19/74] chore(deps): update golang.org/x/sys commit hash to 79a91cf (#145) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 13d5cd2..6555879 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed // indirect + golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4 // indirect golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 ) diff --git a/go.sum b/go.sum index 0641e78..ca52938 100644 --- a/go.sum +++ b/go.sum @@ -38,6 +38,8 @@ golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5h golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed h1:Lf5SX+bXEwoj3Y6Nfu5qtffzOXhPQA9REb2R5W4nGP8= golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4 h1:HWs74PINelUuEfUbwnBO+1N52oVhkjuLqpbUmyrFA1s= +golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 5f5d33a4aab11fe41e7d860c6078865c8a8997b8 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Fri, 7 Jun 2019 15:04:39 +0200 Subject: [PATCH 20/74] chore(deps): update golang.org/x/sys commit hash to 7fc4e5e (#147) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 6555879..10c60b2 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4 // indirect + golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444 // indirect golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 ) diff --git a/go.sum b/go.sum index ca52938..de67b1f 100644 --- a/go.sum +++ b/go.sum @@ -40,6 +40,8 @@ golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed h1:Lf5SX+bXEwoj3Y6Nfu5qtffzO golang.org/x/sys v0.0.0-20190603122648-4c4f7f33c9ed/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4 h1:HWs74PINelUuEfUbwnBO+1N52oVhkjuLqpbUmyrFA1s= golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444 h1:U3H/lfsEYy6ld4rCevWA3QgxHlZLiFUfuBFIEc/Ifyo= +golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 614718608751157d9ebe7f3e08be2b1db3024d0a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Sat, 8 Jun 2019 15:09:21 +0200 Subject: [PATCH 21/74] chore(deps): update golang.org/x/sys commit hash to 5b15430 (#148) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 10c60b2..2ccc64f 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444 // indirect + golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 // indirect golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 ) diff --git a/go.sum b/go.sum index de67b1f..36338c3 100644 --- a/go.sum +++ b/go.sum @@ -42,6 +42,8 @@ golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4 h1:HWs74PINelUuEfUbwnBO+1N52 golang.org/x/sys v0.0.0-20190606125941-79a91cf218c4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444 h1:U3H/lfsEYy6ld4rCevWA3QgxHlZLiFUfuBFIEc/Ifyo= golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 h1:vzXBGBUiVyR0q7D4t89HsaY0TYhmviZBVOVUyvyMBjU= +golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 0bbba3fafdee013ad1a4b867aac0791b95371acf Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Fri, 14 Jun 2019 09:15:18 -0700 Subject: [PATCH 22/74] chore(deps): update golang.org/x/tools commit hash to 1edc8e8 (#146) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 2ccc64f..5539485 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 // indirect - golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 + golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897 ) diff --git a/go.sum b/go.sum index 36338c3..9481ad3 100644 --- a/go.sum +++ b/go.sum @@ -51,3 +51,5 @@ golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10 h1:VULJh5DQg4Inr1Xiypf4pj7 golang.org/x/tools v0.0.0-20190604003109-8aaa1484dc10/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 h1:ousb8Vkhj77qYml3n9BuPuYaR6LnZyLh5LXB2qq8wzI= golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897 h1:Tcg4xXCU7bSKi8WaBg3N7lJTHwLv45zG+LXHG6WxorM= +golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From ff90a675ea494c0fc68a79c3e557addd7e03242f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Fri, 14 Jun 2019 12:09:44 -0700 Subject: [PATCH 23/74] chore(deps): update golang.org/x/tools commit hash to d1d6cdd (#150) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5539485..ed679dd 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 // indirect - golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897 + golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e ) diff --git a/go.sum b/go.sum index 9481ad3..424a8df 100644 --- a/go.sum +++ b/go.sum @@ -53,3 +53,5 @@ golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468 h1:ousb8Vkhj77qYml3n9BuPuY golang.org/x/tools v0.0.0-20190606052759-4d9ae51c2468/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897 h1:Tcg4xXCU7bSKi8WaBg3N7lJTHwLv45zG+LXHG6WxorM= golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e h1:bZRjbS2OsoCz4Whw4o7b1Il1obBuaKSM0FXMfFrRut4= +golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 633630be5a830b18a8a663cdfe26d2844690319d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Fri, 14 Jun 2019 14:54:18 -0700 Subject: [PATCH 24/74] chore(deps): update golang.org/x/tools commit hash to 5aca471 (#151) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index ed679dd..f756580 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 // indirect - golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e + golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 ) diff --git a/go.sum b/go.sum index 424a8df..92ff976 100644 --- a/go.sum +++ b/go.sum @@ -55,3 +55,5 @@ golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897 h1:Tcg4xXCU7bSKi8WaBg3N7lJ golang.org/x/tools v0.0.0-20190614153353-1edc8e83c897/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e h1:bZRjbS2OsoCz4Whw4o7b1Il1obBuaKSM0FXMfFrRut4= golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 h1:rBGSbLsDaYExWFDBn79o7jc1xpwfxSofsWJNihAfWto= +golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 79ba46ca293475cefe4aba5f30faa54acad8e2e2 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Sat, 15 Jun 2019 14:34:47 -0700 Subject: [PATCH 25/74] chore(deps): update golang.org/x/sys commit hash to b47fdc9 (#149) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index f756580..7427e5c 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 // indirect + golang.org/x/sys v0.0.0-20190614215434-b47fdc937951 // indirect golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 ) diff --git a/go.sum b/go.sum index 92ff976..103928b 100644 --- a/go.sum +++ b/go.sum @@ -44,6 +44,8 @@ golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444 h1:U3H/lfsEYy6ld4rCevWA3QgxH golang.org/x/sys v0.0.0-20190606203914-7fc4e5ec1444/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 h1:vzXBGBUiVyR0q7D4t89HsaY0TYhmviZBVOVUyvyMBjU= golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190614215434-b47fdc937951 h1:pGVEuw9fHbMpaZlMbLwssX14J35+8blxkNxbyMcO/qE= +golang.org/x/sys v0.0.0-20190614215434-b47fdc937951/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From fe6c60c5b99e030510c5838b61f4b3ff2b0bb799 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Sun, 16 Jun 2019 09:15:46 -0700 Subject: [PATCH 26/74] chore(deps): update golang.org/x/sys commit hash to 15dcb6c (#152) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 7427e5c..cfab32d 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190614215434-b47fdc937951 // indirect + golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f // indirect golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 ) diff --git a/go.sum b/go.sum index 103928b..2961c40 100644 --- a/go.sum +++ b/go.sum @@ -46,6 +46,8 @@ golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3 h1:vzXBGBUiVyR0q7D4t89HsaY0T golang.org/x/sys v0.0.0-20190608055321-5b15430b70e3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190614215434-b47fdc937951 h1:pGVEuw9fHbMpaZlMbLwssX14J35+8blxkNxbyMcO/qE= golang.org/x/sys v0.0.0-20190614215434-b47fdc937951/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f h1:bWC5mWiwVGXbr7P6ugM+hu6QytMFEjbwt+SO2r1M2+o= +golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 6b655960fa2ac6016a4dad830bee1e3f05f84f49 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Mon, 17 Jun 2019 10:58:03 -0700 Subject: [PATCH 27/74] chore(deps): update golang.org/x/tools commit hash to 6fea9ef (#153) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index cfab32d..a798c4b 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f // indirect - golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 + golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a ) diff --git a/go.sum b/go.sum index 2961c40..5fed050 100644 --- a/go.sum +++ b/go.sum @@ -61,3 +61,5 @@ golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e h1:bZRjbS2OsoCz4Whw4o7b1Il golang.org/x/tools v0.0.0-20190614185444-d1d6cdd8a67e/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 h1:rBGSbLsDaYExWFDBn79o7jc1xpwfxSofsWJNihAfWto= golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a h1:gdHr3XuwwcWiVcNwFFdaMAXkLC9SGW3+yn63Pol+wL0= +golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From f399fe4409bc50599a9c80e177294a688710a27b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 18 Jun 2019 10:30:25 -0700 Subject: [PATCH 28/74] chore(deps): update golang.org/x/tools commit hash to da514ac (#154) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index a798c4b..c302bde 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f // indirect - golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a + golang.org/x/tools v0.0.0-20190617192825-da514acc4774 ) diff --git a/go.sum b/go.sum index 5fed050..98b6022 100644 --- a/go.sum +++ b/go.sum @@ -63,3 +63,5 @@ golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59 h1:rBGSbLsDaYExWFDBn79o7jc golang.org/x/tools v0.0.0-20190614215004-5aca471b1d59/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a h1:gdHr3XuwwcWiVcNwFFdaMAXkLC9SGW3+yn63Pol+wL0= golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190617192825-da514acc4774 h1:hL3a3nRZsZm7FQGehfRB1w5y8mbrLyMSAgki4j0z3I0= +golang.org/x/tools v0.0.0-20190617192825-da514acc4774/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 0027ec683f302bb2aaa95aa255401183b65f37fa Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Tue, 18 Jun 2019 13:48:47 -0700 Subject: [PATCH 29/74] chore(deps): update golang.org/x/tools commit hash to fdf1049 (#156) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c302bde..85ee2dd 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f // indirect - golang.org/x/tools v0.0.0-20190617192825-da514acc4774 + golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a ) diff --git a/go.sum b/go.sum index 98b6022..21d2521 100644 --- a/go.sum +++ b/go.sum @@ -65,3 +65,5 @@ golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a h1:gdHr3XuwwcWiVcNwFFdaMAX golang.org/x/tools v0.0.0-20190617174016-6fea9ef05e7a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190617192825-da514acc4774 h1:hL3a3nRZsZm7FQGehfRB1w5y8mbrLyMSAgki4j0z3I0= golang.org/x/tools v0.0.0-20190617192825-da514acc4774/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a h1:UYXkp2zG6yfcsx4WdMshPebv30sUsSXURy1nWiwy0oc= +golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 602438bd4bbc2b0621f249e6689dd52aeefe7f12 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" Date: Wed, 19 Jun 2019 16:30:30 -0700 Subject: [PATCH 30/74] chore(deps): update golang.org/x/sys commit hash to 17bc616 (#155) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 85ee2dd..176ef8e 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f // indirect + golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4 // indirect golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a ) diff --git a/go.sum b/go.sum index 21d2521..61d40f2 100644 --- a/go.sum +++ b/go.sum @@ -48,6 +48,8 @@ golang.org/x/sys v0.0.0-20190614215434-b47fdc937951 h1:pGVEuw9fHbMpaZlMbLwssX14J golang.org/x/sys v0.0.0-20190614215434-b47fdc937951/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f h1:bWC5mWiwVGXbr7P6ugM+hu6QytMFEjbwt+SO2r1M2+o= golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4 h1:wlKUlj5/boPTVWT2ysl97FAXePcoaV9FNqFOzsNuwpk= +golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From e7e99479897cd316744c9b3e9340ce715efeb7d2 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 22 Jun 2019 18:39:50 -0700 Subject: [PATCH 31/74] chore(deps): update golang.org/x/sys commit hash to d432491 (#158) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 176ef8e..df79c19 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4 // indirect + golang.org/x/sys v0.0.0-20190621215844-d432491b9138 // indirect golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a ) diff --git a/go.sum b/go.sum index 61d40f2..8a9bee8 100644 --- a/go.sum +++ b/go.sum @@ -50,6 +50,8 @@ golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f h1:bWC5mWiwVGXbr7P6ugM+hu6Qy golang.org/x/sys v0.0.0-20190616132722-15dcb6c0061f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4 h1:wlKUlj5/boPTVWT2ysl97FAXePcoaV9FNqFOzsNuwpk= golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190621215844-d432491b9138 h1:mOtS9UBYWoZzbGWv3/XJz0cxMw8MTBbNKy3pRvP2Mjk= +golang.org/x/sys v0.0.0-20190621215844-d432491b9138/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 5969b4c5983b2a1754392e8b742ea8bdca9a180a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 23 Jun 2019 14:24:32 -0700 Subject: [PATCH 32/74] chore(deps): update golang.org/x/tools commit hash to 6e04913 (#157) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index df79c19..b12b408 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190621215844-d432491b9138 // indirect - golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a + golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac ) diff --git a/go.sum b/go.sum index 8a9bee8..6bf8e56 100644 --- a/go.sum +++ b/go.sum @@ -71,3 +71,5 @@ golang.org/x/tools v0.0.0-20190617192825-da514acc4774 h1:hL3a3nRZsZm7FQGehfRB1w5 golang.org/x/tools v0.0.0-20190617192825-da514acc4774/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a h1:UYXkp2zG6yfcsx4WdMshPebv30sUsSXURy1nWiwy0oc= golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac h1:p4rf0zoHymrHSlKS+xG2PhJOtxOEWC9nu4NamWffoY0= +golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 799a5d3748ea19fd98c3a5a8349aa4cd79d988ef Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 24 Jun 2019 11:06:00 -0700 Subject: [PATCH 33/74] chore(deps): update golang.org/x/sys commit hash to c5567b4 (#160) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index b12b408..247d437 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190621215844-d432491b9138 // indirect + golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 // indirect golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac ) diff --git a/go.sum b/go.sum index 6bf8e56..91fb58b 100644 --- a/go.sum +++ b/go.sum @@ -52,6 +52,8 @@ golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4 h1:wlKUlj5/boPTVWT2ysl97FAXe golang.org/x/sys v0.0.0-20190619193031-17bc6164aac4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190621215844-d432491b9138 h1:mOtS9UBYWoZzbGWv3/XJz0cxMw8MTBbNKy3pRvP2Mjk= golang.org/x/sys v0.0.0-20190621215844-d432491b9138/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 h1:z1lZzI4A4GjnM80wHx8Yrjtcr56DRJ6VJnipc0bbG3o= +golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 477e7ba4f9a72b409b0c9f18249ec053c8bfece8 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 25 Jun 2019 09:44:15 -0700 Subject: [PATCH 34/74] chore(deps): update golang.org/x/tools commit hash to a101b04 (#161) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 247d437..7280fa0 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 // indirect - golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac + golang.org/x/tools v0.0.0-20190624225754-a101b041ded4 ) diff --git a/go.sum b/go.sum index 91fb58b..54d5a8e 100644 --- a/go.sum +++ b/go.sum @@ -75,3 +75,5 @@ golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a h1:UYXkp2zG6yfcsx4WdMshPeb golang.org/x/tools v0.0.0-20190618173119-fdf1049a943a/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac h1:p4rf0zoHymrHSlKS+xG2PhJOtxOEWC9nu4NamWffoY0= golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190624225754-a101b041ded4 h1:3Yme/SSFE6mHkvIIhjjiTrlmOsy6m0aNnyTDZPYJIy4= +golang.org/x/tools v0.0.0-20190624225754-a101b041ded4/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 5643339fed8b1c9ba4d5a16fd54902241b2524d4 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 26 Jun 2019 10:26:20 -0700 Subject: [PATCH 35/74] chore(deps): update golang.org/x/tools commit hash to 252024b (#162) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 7280fa0..6490bd9 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 // indirect - golang.org/x/tools v0.0.0-20190624225754-a101b041ded4 + golang.org/x/tools v0.0.0-20190625183255-252024b82959 ) diff --git a/go.sum b/go.sum index 54d5a8e..acf8633 100644 --- a/go.sum +++ b/go.sum @@ -77,3 +77,5 @@ golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac h1:p4rf0zoHymrHSlKS+xG2PhJ golang.org/x/tools v0.0.0-20190623014052-6e04913cbbac/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190624225754-a101b041ded4 h1:3Yme/SSFE6mHkvIIhjjiTrlmOsy6m0aNnyTDZPYJIy4= golang.org/x/tools v0.0.0-20190624225754-a101b041ded4/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190625183255-252024b82959 h1:icB3Kx/bolKriEovlxmFvvEBA1b24q6lQkwGLiO7Kgo= +golang.org/x/tools v0.0.0-20190625183255-252024b82959/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= From 5a7bfb53b11d87b4fb817ef7edbca6d0988508e8 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 29 Jun 2019 13:53:08 -0700 Subject: [PATCH 36/74] chore(deps): update golang.org/x/tools commit hash to fb37f6b (#164) --- go.mod | 2 +- go.sum | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 6490bd9..9a0664f 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 // indirect - golang.org/x/tools v0.0.0-20190625183255-252024b82959 + golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 ) diff --git a/go.sum b/go.sum index acf8633..9838c97 100644 --- a/go.sum +++ b/go.sum @@ -31,6 +31,7 @@ github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e h1:o3PsSEY8E4eXWkXrIP9YJALUkVZqzHJT5DOasTyn8Vs= golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= @@ -79,3 +80,5 @@ golang.org/x/tools v0.0.0-20190624225754-a101b041ded4 h1:3Yme/SSFE6mHkvIIhjjiTrl golang.org/x/tools v0.0.0-20190624225754-a101b041ded4/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190625183255-252024b82959 h1:icB3Kx/bolKriEovlxmFvvEBA1b24q6lQkwGLiO7Kgo= golang.org/x/tools v0.0.0-20190625183255-252024b82959/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= +golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 h1:D/pylchHpGxucPHRiQsXXfyk9R4ywTUoH6FaZx0R0Q0= +golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 6694b249e8427dbc8ce6e24507a87a4c11d3df21 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 30 Jun 2019 16:29:47 -0700 Subject: [PATCH 37/74] chore(deps): update golang.org/x/sys commit hash to 04f50cd (#163) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 9a0664f..1d8d0fa 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 // indirect + golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 ) diff --git a/go.sum b/go.sum index 9838c97..002feb2 100644 --- a/go.sum +++ b/go.sum @@ -55,6 +55,8 @@ golang.org/x/sys v0.0.0-20190621215844-d432491b9138 h1:mOtS9UBYWoZzbGWv3/XJz0cxM golang.org/x/sys v0.0.0-20190621215844-d432491b9138/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 h1:z1lZzI4A4GjnM80wHx8Yrjtcr56DRJ6VJnipc0bbG3o= golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb h1:IeU57h/r0+/v829dDR8bskefuF1Cx4KAxce1Cn0LFvE= +golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From f7d2524ff650169c45967546f5ed517b56656e06 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 1 Jul 2019 15:20:39 -0700 Subject: [PATCH 38/74] chore(deps): update golang.org/x/tools commit hash to 38ae2c8 (#166) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 1d8d0fa..3267e5e 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 + golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412 ) diff --git a/go.sum b/go.sum index 002feb2..4d1877b 100644 --- a/go.sum +++ b/go.sum @@ -84,3 +84,5 @@ golang.org/x/tools v0.0.0-20190625183255-252024b82959 h1:icB3Kx/bolKriEovlxmFvvE golang.org/x/tools v0.0.0-20190625183255-252024b82959/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc= golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 h1:D/pylchHpGxucPHRiQsXXfyk9R4ywTUoH6FaZx0R0Q0= golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412 h1:eiOZ97iLROr9dsoElIcgpaBTnypaUM6FklHaTH1WCUQ= +golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From cf3705f1b27111d8b7bb00fa2e226a2c9cf3500f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 2 Jul 2019 09:29:33 -0700 Subject: [PATCH 39/74] chore(deps): update golang.org/x/tools commit hash to 7e72c71 (#167) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3267e5e..9e07e50 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412 + golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f ) diff --git a/go.sum b/go.sum index 4d1877b..6625526 100644 --- a/go.sum +++ b/go.sum @@ -86,3 +86,5 @@ golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261 h1:D/pylchHpGxucPHRiQsXXfy golang.org/x/tools v0.0.0-20190628234000-fb37f6ba8261/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412 h1:eiOZ97iLROr9dsoElIcgpaBTnypaUM6FklHaTH1WCUQ= golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f h1:XEee/4s6OPmxKNwnku3HeR9yvHS+DfiMUBnZRvGYKsc= +golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From f8734a4f68a3310f5b104b40632c995fe1cd37b7 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 3 Jul 2019 08:29:32 -0700 Subject: [PATCH 40/74] chore(deps): update golang.org/x/tools commit hash to 44aeb8b (#168) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 9e07e50..31b9929 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f + golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377 ) diff --git a/go.sum b/go.sum index 6625526..60d4f0f 100644 --- a/go.sum +++ b/go.sum @@ -88,3 +88,5 @@ golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412 h1:eiOZ97iLROr9dsoElIcgpaB golang.org/x/tools v0.0.0-20190701204812-38ae2c8f6412/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f h1:XEee/4s6OPmxKNwnku3HeR9yvHS+DfiMUBnZRvGYKsc= golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377 h1:ImzDLDLqRaKKO5JeKsrJF73YTtC/UGJYXQfnhCykd1U= +golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From b70717f5395a29c099e82291e6fdf6168642faac Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 3 Jul 2019 12:15:15 -0700 Subject: [PATCH 41/74] chore(deps): update golang.org/x/tools commit hash to 063514c (#169) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 31b9929..716aa3f 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377 + golang.org/x/tools v0.0.0-20190703183741-063514c48b26 ) diff --git a/go.sum b/go.sum index 60d4f0f..f96f333 100644 --- a/go.sum +++ b/go.sum @@ -90,3 +90,5 @@ golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f h1:XEee/4s6OPmxKNwnku3HeR9 golang.org/x/tools v0.0.0-20190702152726-7e72c71c505f/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377 h1:ImzDLDLqRaKKO5JeKsrJF73YTtC/UGJYXQfnhCykd1U= golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190703183741-063514c48b26 h1:RSQtTb58BibjAu/zvYqkvmSd3hCVrxUHtxtJgdmlo8U= +golang.org/x/tools v0.0.0-20190703183741-063514c48b26/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From aef3db71b0eb74ac8bb066d3671ac36f4206c6e0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 8 Jul 2019 09:41:06 -0700 Subject: [PATCH 42/74] chore(deps): update golang.org/x/tools commit hash to 60762fc (#170) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 716aa3f..05ddda4 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190703183741-063514c48b26 + golang.org/x/tools v0.0.0-20190708153032-60762fc531e6 ) diff --git a/go.sum b/go.sum index f96f333..620f31d 100644 --- a/go.sum +++ b/go.sum @@ -92,3 +92,5 @@ golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377 h1:ImzDLDLqRaKKO5JeKsrJF73 golang.org/x/tools v0.0.0-20190702203059-44aeb8b7c377/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190703183741-063514c48b26 h1:RSQtTb58BibjAu/zvYqkvmSd3hCVrxUHtxtJgdmlo8U= golang.org/x/tools v0.0.0-20190703183741-063514c48b26/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190708153032-60762fc531e6 h1:+09ssZLX5m87DAU4ovA5R2dT8+rxQJOSrnvJ08dNOvI= +golang.org/x/tools v0.0.0-20190708153032-60762fc531e6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 0a1679d8df86d6e522910762c23f05e3540d2724 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2019 07:50:18 -0700 Subject: [PATCH 43/74] chore(deps): update golang.org/x/tools commit hash to c885524 (#171) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 05ddda4..20424e9 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190708153032-60762fc531e6 + golang.org/x/tools v0.0.0-20190708212629-c8855242db9c ) diff --git a/go.sum b/go.sum index 620f31d..6c6b61e 100644 --- a/go.sum +++ b/go.sum @@ -94,3 +94,5 @@ golang.org/x/tools v0.0.0-20190703183741-063514c48b26 h1:RSQtTb58BibjAu/zvYqkvmS golang.org/x/tools v0.0.0-20190703183741-063514c48b26/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190708153032-60762fc531e6 h1:+09ssZLX5m87DAU4ovA5R2dT8+rxQJOSrnvJ08dNOvI= golang.org/x/tools v0.0.0-20190708153032-60762fc531e6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190708212629-c8855242db9c h1:61VlnXlxJ8ZQ0ScNJLbv0lMvy2zxMOMtmqgczqTjoSw= +golang.org/x/tools v0.0.0-20190708212629-c8855242db9c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 004c78fec9d5f82810ab10cb40f9488036c0b091 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2019 14:38:07 -0700 Subject: [PATCH 44/74] chore(deps): update golang.org/x/tools commit hash to f82b303 (#172) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 20424e9..5434075 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190708212629-c8855242db9c + golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7 ) diff --git a/go.sum b/go.sum index 6c6b61e..0880eef 100644 --- a/go.sum +++ b/go.sum @@ -96,3 +96,5 @@ golang.org/x/tools v0.0.0-20190708153032-60762fc531e6 h1:+09ssZLX5m87DAU4ovA5R2d golang.org/x/tools v0.0.0-20190708153032-60762fc531e6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190708212629-c8855242db9c h1:61VlnXlxJ8ZQ0ScNJLbv0lMvy2zxMOMtmqgczqTjoSw= golang.org/x/tools v0.0.0-20190708212629-c8855242db9c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7 h1:POOqS8nIAlVjiggJspEagLTIm7FecjZ3zjL+UXqxaeo= +golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 5a9154b01725e57dc06867a081d9847c15474b75 Mon Sep 17 00:00:00 2001 From: mgechev Date: Tue, 9 Jul 2019 21:51:26 -0700 Subject: [PATCH 45/74] Update readme --- README.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 0570b37..7b2ae7d 100644 --- a/README.md +++ b/README.md @@ -34,8 +34,13 @@ Here's how `revive` is different from `golint`: - [`excelize`](https://github.com/360EntSecGroup-Skylar/excelize) - Go library for reading and writing Microsoft Excel™ (XLSX) files - [`aurora`](https://github.com/xuri/aurora) - aurora is a web-based Beanstalk queue server console written in Go - [`soar`](https://github.com/XiaoMi/soar) - SQL Optimizer And Rewriter -- [`gorush`](https://github.com/appleboy/gorush) - A push notification server written in Go (Golang) +- [`gorush`](https://github.com/appleboy/gorush) - A push notification server written in Go (Golang)a +- [`go-echarts`](https://github.com/chenjiandongx/go-echarts) - The adorable charts library for Golang +- [`reviewdog`](https://github.com/reviewdog/reviewdog) - Automated code review tool integrated with any code analysis tools regardless of programming language - [`sklearn`](https://github.com/pa-m/sklearn) - A partial port of scikit-learn written in Go +- [`lorawan-stack`](https://github.com/TheThingsNetwork/lorawan-stack) - The Things Network Stack for LoRaWAN V3 +- [`gofight`](https://github.com/appleboy/gofight) - Testing API Handler written in Golang. +- [`ggz`](https://github.com/go-ggz/ggz) - An URL shortener service written in Golang *Open a PR to add your project*. @@ -48,6 +53,7 @@ Here's how `revive` is different from `golint`: - [revive](#revive) - [Usage](#usage) - [Text Editors](#text-editors) + - [Bazel](#bazel) - [Installation](#installation) - [Command Line Flags](#command-line-flags) - [Sample Invocations](#sample-invocations) @@ -81,6 +87,10 @@ Here's how `revive` is different from `golint`: Since the default behavior of `revive` is compatible with `golint`, without providing any additional flags, the only difference you'd notice is faster execution. +### Bazel + +If you want to use revive with Bazel, take a look at the [rules](https://github.com/atlassian/bazel-tools/tree/master/gorevive) that Atlassian maintains. + ### Text Editors - Support for VSCode in [vscode-go](https://github.com/Microsoft/vscode-go/pull/1699). From 4721dcd00ce51e313e5638a090ba4bd630d3fae9 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2019 07:18:51 -0700 Subject: [PATCH 46/74] chore(deps): update golang.org/x/tools commit hash to 7b25e35 (#173) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5434075..0ea363a 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect - golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7 + golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e ) diff --git a/go.sum b/go.sum index 0880eef..75876a0 100644 --- a/go.sum +++ b/go.sum @@ -98,3 +98,5 @@ golang.org/x/tools v0.0.0-20190708212629-c8855242db9c h1:61VlnXlxJ8ZQ0ScNJLbv0lM golang.org/x/tools v0.0.0-20190708212629-c8855242db9c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7 h1:POOqS8nIAlVjiggJspEagLTIm7FecjZ3zjL+UXqxaeo= golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e h1:KLE9RrAWtdmIWsb/E0ljAvXMM5lZf4Gtr3HYCEE4FIE= +golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From bb1c6ed1972fdeafe4088e9857e0253b2660d19b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2019 10:00:08 -0700 Subject: [PATCH 47/74] chore(deps): update golang.org/x/sys commit hash to 6ec70d6 (#174) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 0ea363a..3067cba 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb // indirect + golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 // indirect golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e ) diff --git a/go.sum b/go.sum index 75876a0..4a6c6fe 100644 --- a/go.sum +++ b/go.sum @@ -57,6 +57,8 @@ golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0 h1:z1lZzI4A4GjnM80wHx8Yrjtcr golang.org/x/sys v0.0.0-20190624145334-c5567b49c5d0/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb h1:IeU57h/r0+/v829dDR8bskefuF1Cx4KAxce1Cn0LFvE= golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 h1:PNYRbnC8XRk0bAINQCfprVc169PXbLRG2HI1HXbUEg8= +golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 05a0567aced17ce9337d0f4544394c1f1b51d69b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 10 Jul 2019 14:59:43 -0700 Subject: [PATCH 48/74] chore(deps): update golang.org/x/tools commit hash to 2868181 (#175) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 3067cba..65f88d0 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 // indirect - golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e + golang.org/x/tools v0.0.0-20190710195507-286818132824 ) diff --git a/go.sum b/go.sum index 4a6c6fe..f5b6a3f 100644 --- a/go.sum +++ b/go.sum @@ -102,3 +102,5 @@ golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7 h1:POOqS8nIAlVjiggJspEagLT golang.org/x/tools v0.0.0-20190709205837-f82b303b69d7/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e h1:KLE9RrAWtdmIWsb/E0ljAvXMM5lZf4Gtr3HYCEE4FIE= golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190710195507-286818132824 h1:2492BvYnJkin59SmTIFBH3mlkrNxeIKPJuM3GrK/gYo= +golang.org/x/tools v0.0.0-20190710195507-286818132824/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 739839bfc624d63bf2440390545351bab320afca Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 12 Jul 2019 08:30:49 -0700 Subject: [PATCH 49/74] chore(deps): update golang.org/x/sys commit hash to fae7ac5 (#177) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 65f88d0..92892a0 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 // indirect + golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect golang.org/x/tools v0.0.0-20190710195507-286818132824 ) diff --git a/go.sum b/go.sum index f5b6a3f..ef4cb30 100644 --- a/go.sum +++ b/go.sum @@ -59,6 +59,8 @@ golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb h1:IeU57h/r0+/v829dDR8bskefu golang.org/x/sys v0.0.0-20190629205408-04f50cda93cb/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 h1:PNYRbnC8XRk0bAINQCfprVc169PXbLRG2HI1HXbUEg8= golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 h1:kj9oKJYzWQH5MvoBhxb9WQn/LqYor42sKTvsrUCCu7g= +golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 5067f561891dbbaa12a61c81f61bcb1d2c13543a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 13 Jul 2019 15:02:03 -0700 Subject: [PATCH 50/74] chore(deps): update golang.org/x/tools commit hash to 8b92790 (#176) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 92892a0..a7808b1 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190710195507-286818132824 + golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d ) diff --git a/go.sum b/go.sum index ef4cb30..01baad1 100644 --- a/go.sum +++ b/go.sum @@ -106,3 +106,5 @@ golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e h1:KLE9RrAWtdmIWsb/E0ljAvX golang.org/x/tools v0.0.0-20190709213823-7b25e351ac0e/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190710195507-286818132824 h1:2492BvYnJkin59SmTIFBH3mlkrNxeIKPJuM3GrK/gYo= golang.org/x/tools v0.0.0-20190710195507-286818132824/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d h1:KlQeLUDWg+cWfoNyo2obro62ANg9Ain//HXb8aKT2jg= +golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 6fb42170acbc9a947fe5d42678ec1ae9eaeb6aed Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Jul 2019 08:32:08 -0700 Subject: [PATCH 51/74] chore(deps): update golang.org/x/tools commit hash to 607ca05 (#178) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index a7808b1..e8af52b 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d + golang.org/x/tools v0.0.0-20190715053316-607ca053a137 ) diff --git a/go.sum b/go.sum index 01baad1..9ac3263 100644 --- a/go.sum +++ b/go.sum @@ -108,3 +108,5 @@ golang.org/x/tools v0.0.0-20190710195507-286818132824 h1:2492BvYnJkin59SmTIFBH3m golang.org/x/tools v0.0.0-20190710195507-286818132824/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d h1:KlQeLUDWg+cWfoNyo2obro62ANg9Ain//HXb8aKT2jg= golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190715053316-607ca053a137 h1:JD/hG/8Cy1uTpUou5cTdh88WzXO985+ykk+/kD2B6Og= +golang.org/x/tools v0.0.0-20190715053316-607ca053a137/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 969a832b5746bc89b05f21bfbd3586a6443a4b59 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Jul 2019 10:53:56 -0700 Subject: [PATCH 52/74] chore(deps): update golang.org/x/tools commit hash to 9e48ab1 (#179) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index e8af52b..0f72336 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190715053316-607ca053a137 + golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd ) diff --git a/go.sum b/go.sum index 9ac3263..a015bde 100644 --- a/go.sum +++ b/go.sum @@ -110,3 +110,5 @@ golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d h1:KlQeLUDWg+cWfoNyo2obro6 golang.org/x/tools v0.0.0-20190712214651-8b927904ee0d/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190715053316-607ca053a137 h1:JD/hG/8Cy1uTpUou5cTdh88WzXO985+ykk+/kD2B6Og= golang.org/x/tools v0.0.0-20190715053316-607ca053a137/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd h1:WtY90UqL9QgrhtGZXkSuv3VgN9O2zchNuw7mCsy5EAo= +golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From aa12814931777cd575b3eef80e60070f5ab3a77a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Jul 2019 15:30:54 -0700 Subject: [PATCH 53/74] chore(deps): update golang.org/x/tools commit hash to 9b2cb0e (#180) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 0f72336..c25f53a 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd + golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602 ) diff --git a/go.sum b/go.sum index a015bde..f0be3d7 100644 --- a/go.sum +++ b/go.sum @@ -112,3 +112,5 @@ golang.org/x/tools v0.0.0-20190715053316-607ca053a137 h1:JD/hG/8Cy1uTpUou5cTdh88 golang.org/x/tools v0.0.0-20190715053316-607ca053a137/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd h1:WtY90UqL9QgrhtGZXkSuv3VgN9O2zchNuw7mCsy5EAo= golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602 h1:aPQ4URfBa5qpEffv7JQWB643/X9MIooR7AmSM4PhjbQ= +golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 524fec5f56442d285255aa9f4914d069ece3150b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 16 Jul 2019 07:43:18 -0700 Subject: [PATCH 54/74] chore(deps): update golang.org/x/tools commit hash to fefcef0 (#181) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c25f53a..b3e301b 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602 + golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1 ) diff --git a/go.sum b/go.sum index f0be3d7..b4f2c05 100644 --- a/go.sum +++ b/go.sum @@ -114,3 +114,5 @@ golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd h1:WtY90UqL9QgrhtGZXkSuv3V golang.org/x/tools v0.0.0-20190715174000-9e48ab1d90cd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602 h1:aPQ4URfBa5qpEffv7JQWB643/X9MIooR7AmSM4PhjbQ= golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1 h1:XTh+ATqTLtxlslz1/eewT2lc16Tn566b6TuHLllcamo= +golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From b79e27c46de48c533aac6e25a7054415478049da Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 16 Jul 2019 10:07:49 -0700 Subject: [PATCH 55/74] chore(deps): update golang.org/x/tools commit hash to 919acb9 (#182) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index b3e301b..a088969 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1 + golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd ) diff --git a/go.sum b/go.sum index b4f2c05..5d2e577 100644 --- a/go.sum +++ b/go.sum @@ -116,3 +116,5 @@ golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602 h1:aPQ4URfBa5qpEffv7JQWB64 golang.org/x/tools v0.0.0-20190715222530-9b2cb0e5f602/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1 h1:XTh+ATqTLtxlslz1/eewT2lc16Tn566b6TuHLllcamo= golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd h1:awSISWvdxEIWPMBRrxodeas3r6hNs3R7fSCAKsN+2eg= +golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 4effe7464232029b5d13f6b9ea5ab47ae184d44c Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 16 Jul 2019 12:51:10 -0700 Subject: [PATCH 56/74] chore(deps): update golang.org/x/tools commit hash to 0b5a7f8 (#183) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index a088969..d6c78a2 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd + golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50 ) diff --git a/go.sum b/go.sum index 5d2e577..db9043e 100644 --- a/go.sum +++ b/go.sum @@ -118,3 +118,5 @@ golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1 h1:XTh+ATqTLtxlslz1/eewT2l golang.org/x/tools v0.0.0-20190716023037-fefcef05abb1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd h1:awSISWvdxEIWPMBRrxodeas3r6hNs3R7fSCAKsN+2eg= golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50 h1:MjNb67gYViBJS2G0qlnUyUvz01HpvT0hWbRK6+CVeB4= +golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From a81a35d23ea5d8ac3bbd5959ff4f78113e2897d0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 19 Jul 2019 08:40:47 -0700 Subject: [PATCH 57/74] chore(deps): update golang.org/x/tools commit hash to e377ae9 (#184) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index d6c78a2..5ca1aef 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50 + golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386 ) diff --git a/go.sum b/go.sum index db9043e..9009e60 100644 --- a/go.sum +++ b/go.sum @@ -120,3 +120,5 @@ golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd h1:awSISWvdxEIWPMBRrxodeas golang.org/x/tools v0.0.0-20190716155013-919acb9f1ffd/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50 h1:MjNb67gYViBJS2G0qlnUyUvz01HpvT0hWbRK6+CVeB4= golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386 h1:XYHge1yfBqxAoAUYFNfgQBUM/pLA4cVgBCxSVP4SFM8= +golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 34164a8526f90a72951cb6341829c2bb31809d83 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 22 Jul 2019 19:45:30 -0700 Subject: [PATCH 58/74] chore(deps): update golang.org/x/tools commit hash to 8bb11ff (#185) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5ca1aef..381e821 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386 + golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca ) diff --git a/go.sum b/go.sum index 9009e60..2e4ff1b 100644 --- a/go.sum +++ b/go.sum @@ -122,3 +122,5 @@ golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50 h1:MjNb67gYViBJS2G0qlnUyUv golang.org/x/tools v0.0.0-20190716192744-0b5a7f81db50/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386 h1:XYHge1yfBqxAoAUYFNfgQBUM/pLA4cVgBCxSVP4SFM8= golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca h1:jxUITcp9Zck5mo94NnK9nxKhcrCHHu3Uxn3zT/Ab6GQ= +golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 0fbf639be70a648a85aa727fb432dfb319382e37 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 24 Jul 2019 12:42:42 -0700 Subject: [PATCH 59/74] chore(deps): update golang.org/x/tools commit hash to 8aa4eac (#186) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 381e821..25191f9 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca + golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1 ) diff --git a/go.sum b/go.sum index 2e4ff1b..0777280 100644 --- a/go.sum +++ b/go.sum @@ -124,3 +124,5 @@ golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386 h1:XYHge1yfBqxAoAUYFNfgQBU golang.org/x/tools v0.0.0-20190719014327-e377ae9d6386/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca h1:jxUITcp9Zck5mo94NnK9nxKhcrCHHu3Uxn3zT/Ab6GQ= golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1 h1:fUhbXHMxzVzne8fm8LoGbgb29YxdSR6sXVOA6M1+79c= +golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 152b498a52e190f90f23203d90a90dfefbd063e0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 25 Jul 2019 10:58:23 -0700 Subject: [PATCH 60/74] chore(deps): update golang.org/x/tools commit hash to 2e34cfc (#187) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 25191f9..ba09421 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect - golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1 + golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb ) diff --git a/go.sum b/go.sum index 0777280..d06396d 100644 --- a/go.sum +++ b/go.sum @@ -126,3 +126,5 @@ golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca h1:jxUITcp9Zck5mo94NnK9nxK golang.org/x/tools v0.0.0-20190723023520-8bb11ff117ca/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1 h1:fUhbXHMxzVzne8fm8LoGbgb29YxdSR6sXVOA6M1+79c= golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb h1:nCidYN5rpBq6eOoKgsg8OPyARFROWoopPyENOA1AADU= +golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From de49a7b6832f273282c023039f4fa953d0dfb892 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 25 Jul 2019 17:59:20 -0700 Subject: [PATCH 61/74] chore(deps): update golang.org/x/sys commit hash to 94b544f (#188) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index ba09421..960560b 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 // indirect + golang.org/x/sys v0.0.0-20190726004620-94b544f455ef // indirect golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb ) diff --git a/go.sum b/go.sum index d06396d..04ae248 100644 --- a/go.sum +++ b/go.sum @@ -61,6 +61,8 @@ golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542 h1:PNYRbnC8XRk0bAINQCfprVc16 golang.org/x/sys v0.0.0-20190710165549-6ec70d6a5542/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 h1:kj9oKJYzWQH5MvoBhxb9WQn/LqYor42sKTvsrUCCu7g= golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190726004620-94b544f455ef h1:pKfIZaaN+ipVf4Vz//s+8MRZkgZvBsds3BOAAYmXV/Y= +golang.org/x/sys v0.0.0-20190726004620-94b544f455ef/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From d3d301fa134e5aab45d1f86079de4ea01f322ab0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 26 Jul 2019 07:42:29 -0700 Subject: [PATCH 62/74] chore(deps): update golang.org/x/sys commit hash to fc99dfb (#189) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 960560b..ce9a573 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190726004620-94b544f455ef // indirect + golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb ) diff --git a/go.sum b/go.sum index 04ae248..2535646 100644 --- a/go.sum +++ b/go.sum @@ -63,6 +63,8 @@ golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7 h1:kj9oKJYzWQH5MvoBhxb9WQn/L golang.org/x/sys v0.0.0-20190712063909-fae7ac547cb7/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190726004620-94b544f455ef h1:pKfIZaaN+ipVf4Vz//s+8MRZkgZvBsds3BOAAYmXV/Y= golang.org/x/sys v0.0.0-20190726004620-94b544f455ef/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e h1:AhhcJML1FGXN10f3s4/WyoO5/8u7Rfb1ZyB47O8qp+s= +golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 6205a19da740784174f76a579c7c67a2ad85639e Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 26 Jul 2019 21:55:55 -0700 Subject: [PATCH 63/74] chore(deps): update golang.org/x/tools commit hash to 1bd5602 (#191) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index ce9a573..2c8c3f5 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect - golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb + golang.org/x/tools v0.0.0-20190727014933-1bd56024c620 ) diff --git a/go.sum b/go.sum index 2535646..fc68ff0 100644 --- a/go.sum +++ b/go.sum @@ -132,3 +132,5 @@ golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1 h1:fUhbXHMxzVzne8fm8LoGbgb golang.org/x/tools v0.0.0-20190724192812-8aa4eac1a7c1/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb h1:nCidYN5rpBq6eOoKgsg8OPyARFROWoopPyENOA1AADU= golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190727014933-1bd56024c620 h1:V0R1y3ny4Qty3oJpgixfc7BF1GqcBtG492UJDH4XNi4= +golang.org/x/tools v0.0.0-20190727014933-1bd56024c620/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From fd5694226cc9043a4b1ffc10198df6959f555a85 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 27 Jul 2019 13:23:18 -0700 Subject: [PATCH 64/74] chore(deps): update golang.org/x/tools commit hash to db2fa46 (#192) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 2c8c3f5..6c3262b 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect - golang.org/x/tools v0.0.0-20190727014933-1bd56024c620 + golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c ) diff --git a/go.sum b/go.sum index fc68ff0..93470f6 100644 --- a/go.sum +++ b/go.sum @@ -134,3 +134,5 @@ golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb h1:nCidYN5rpBq6eOoKgsg8OPy golang.org/x/tools v0.0.0-20190725162026-2e34cfcb95cb/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190727014933-1bd56024c620 h1:V0R1y3ny4Qty3oJpgixfc7BF1GqcBtG492UJDH4XNi4= golang.org/x/tools v0.0.0-20190727014933-1bd56024c620/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c h1:jOixaG4f/xPYap0HSnwlewCOTxw7qq5hqxvCyw5Kfvg= +golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 06322316722a2fd7acb84a0d772ebe8705c01c50 Mon Sep 17 00:00:00 2001 From: Minko Gechev Date: Sat, 27 Jul 2019 15:10:55 -0700 Subject: [PATCH 65/74] Set specific node version (#194) --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index b455d67..52aad3f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,5 +1,6 @@ language: go go: 1.11.x +node_js: 11.15.0 install: make install script: - make build From 36221bfc1f1818adb638dcdb91335283ae17c594 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 28 Jul 2019 10:28:29 -0700 Subject: [PATCH 66/74] chore(deps): update golang.org/x/tools commit hash to fc6e205 (#196) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 6c3262b..5105d22 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect - golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c + golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6 ) diff --git a/go.sum b/go.sum index 93470f6..9611989 100644 --- a/go.sum +++ b/go.sum @@ -136,3 +136,5 @@ golang.org/x/tools v0.0.0-20190727014933-1bd56024c620 h1:V0R1y3ny4Qty3oJpgixfc7B golang.org/x/tools v0.0.0-20190727014933-1bd56024c620/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c h1:jOixaG4f/xPYap0HSnwlewCOTxw7qq5hqxvCyw5Kfvg= golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6 h1:HwL5zE73Lj6ca2l3QvmH+z+mMQJp6w6/7zcxRJcGNRw= +golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 5ae9226dc5ceda6120e093cf8c726821464fd1ff Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 29 Jul 2019 08:58:49 -0700 Subject: [PATCH 67/74] chore(deps): update golang.org/x/tools commit hash to ff9f140 (#197) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5105d22..7f7eee5 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect - golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6 + golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a ) diff --git a/go.sum b/go.sum index 9611989..fd6cbdd 100644 --- a/go.sum +++ b/go.sum @@ -138,3 +138,5 @@ golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c h1:jOixaG4f/xPYap0HSnwlewC golang.org/x/tools v0.0.0-20190727174842-db2fa46ec33c/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6 h1:HwL5zE73Lj6ca2l3QvmH+z+mMQJp6w6/7zcxRJcGNRw= golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a h1:s5iVUvQeQogtT5N2UsrWTExwB/vujdgo2oRIoKqGHP0= +golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 03c3312c2c48c7eb82100205a3675600b069a307 Mon Sep 17 00:00:00 2001 From: Oleg Gaidarenko Date: Mon, 29 Jul 2019 21:55:35 +0300 Subject: [PATCH 68/74] fix: adhere to "Rule of Silence" (#198) Makes stylish formatter respect "Rule of Silence" See http://www.linfo.org/rule_of_silence.html Fixes #165 --- formatter/stylish.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/formatter/stylish.go b/formatter/stylish.go index 9d3286c..dd8e18b 100644 --- a/formatter/stylish.go +++ b/formatter/stylish.go @@ -82,7 +82,8 @@ func (f *Stylish) Format(failures <-chan lint.Failure, config lint.RulesConfig) } else if total > 0 && totalErrors == 0 { suffix = color.YellowString("\n ✖" + suffix) } else { - suffix = color.GreenString("\n" + suffix) + suffix, output = "", "" } + return output + suffix, nil } From 227ec43d09e022f7490137c0665f32d0d2ed4a3d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 30 Jul 2019 17:24:25 -0700 Subject: [PATCH 69/74] chore(deps): update golang.org/x/tools commit hash to ed3277d (#200) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 7f7eee5..7841280 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect - golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a + golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 ) diff --git a/go.sum b/go.sum index fd6cbdd..94212ac 100644 --- a/go.sum +++ b/go.sum @@ -140,3 +140,5 @@ golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6 h1:HwL5zE73Lj6ca2l3QvmH+z+ golang.org/x/tools v0.0.0-20190728085240-fc6e2057e7f6/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a h1:s5iVUvQeQogtT5N2UsrWTExwB/vujdgo2oRIoKqGHP0= golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 h1:QDcqPiPMwhOSeNS/65AYJQxAYb2HIYLFw6NRbGQUtSU= +golang.org/x/tools v0.0.0-20190730215743-ed3277de2799/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From aac29c74e32cd87c1c2462a0c2e1a22a7d1c2533 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 31 Jul 2019 10:41:54 -0700 Subject: [PATCH 70/74] chore(deps): update golang.org/x/sys commit hash to 1393eb0 (#199) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 7841280..830d9f9 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e // indirect + golang.org/x/sys v0.0.0-20190731002446-1393eb018365 // indirect golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 ) diff --git a/go.sum b/go.sum index 94212ac..ed6fcd2 100644 --- a/go.sum +++ b/go.sum @@ -65,6 +65,8 @@ golang.org/x/sys v0.0.0-20190726004620-94b544f455ef h1:pKfIZaaN+ipVf4Vz//s+8MRZk golang.org/x/sys v0.0.0-20190726004620-94b544f455ef/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e h1:AhhcJML1FGXN10f3s4/WyoO5/8u7Rfb1ZyB47O8qp+s= golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190731002446-1393eb018365 h1:skmasgLtLOsII4VBh/TRzNotE2cn3rMyPB9/A67wLDU= +golang.org/x/sys v0.0.0-20190731002446-1393eb018365/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 94c4cad31c01db0b0b428512bf5a78e04ef8cde5 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 31 Jul 2019 16:49:27 -0700 Subject: [PATCH 71/74] chore(deps): update golang.org/x/tools commit hash to 1e85ed8 (#201) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 830d9f9..5771fd1 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190731002446-1393eb018365 // indirect - golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 + golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa ) diff --git a/go.sum b/go.sum index ed6fcd2..25e4988 100644 --- a/go.sum +++ b/go.sum @@ -144,3 +144,5 @@ golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a h1:s5iVUvQeQogtT5N2UsrWTEx golang.org/x/tools v0.0.0-20190729094940-ff9f1409240a/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 h1:QDcqPiPMwhOSeNS/65AYJQxAYb2HIYLFw6NRbGQUtSU= golang.org/x/tools v0.0.0-20190730215743-ed3277de2799/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa h1:crSxYKs/4ckOznRS/ORDRJikUnqR5pcExM2Q9fNghbw= +golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= From 639585fb7966549ebdf5b925198d0286936f2462 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 1 Aug 2019 10:43:01 -0700 Subject: [PATCH 72/74] chore(deps): update golang.org/x/sys commit hash to cbf593c (#202) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5771fd1..09134be 100644 --- a/go.mod +++ b/go.mod @@ -9,6 +9,6 @@ require ( github.com/mgechev/dots v0.0.0-20190603122614-18fa4c4b71cc github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 - golang.org/x/sys v0.0.0-20190731002446-1393eb018365 // indirect + golang.org/x/sys v0.0.0-20190801053355-cbf593c0f2f3 // indirect golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa ) diff --git a/go.sum b/go.sum index 25e4988..d10bcc7 100644 --- a/go.sum +++ b/go.sum @@ -67,6 +67,8 @@ golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e h1:AhhcJML1FGXN10f3s4/WyoO5/ golang.org/x/sys v0.0.0-20190726093751-fc99dfbffb4e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190731002446-1393eb018365 h1:skmasgLtLOsII4VBh/TRzNotE2cn3rMyPB9/A67wLDU= golang.org/x/sys v0.0.0-20190731002446-1393eb018365/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= +golang.org/x/sys v0.0.0-20190801053355-cbf593c0f2f3 h1:sL449jA3eITt86CGRvhic5g9AuQEnaqaasKTT+ieDng= +golang.org/x/sys v0.0.0-20190801053355-cbf593c0f2f3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1 h1:dzEuQYa6+a3gROnSlgly5ERUm4SZKJt+dh+4iSbO+bI= golang.org/x/tools v0.0.0-20180911133044-677d2ff680c1/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= From 55cfae63e9c800f1412cd9704f3c79182b923544 Mon Sep 17 00:00:00 2001 From: SalvadorC Date: Fri, 2 Aug 2019 17:21:33 +0200 Subject: [PATCH 73/74] Conf reason rule disabling (#193) * adds support for comments when enabling/disabling * adds config flag to require disabling reason * Update lint/file.go adds code fmt suggestion by @mgechev Co-Authored-By: Minko Gechev * moves regexp compilation out of the function fix typo in condition * adds support for comments when enabling/disabling * skips incomplete directives and generate a failure * adds _directive_ concept to cope with specify-disable-reason * adds doc gofmt * fixes severity is ignored --- README.md | 26 ++++++++++++++++++-- config.go | 6 +++++ fixtures/disable-annotations2.go | 14 +++++++++++ formatter/checkstyle.go | 2 +- formatter/default.go | 2 +- formatter/friendly.go | 2 +- formatter/json.go | 2 +- formatter/ndjson.go | 2 +- formatter/plain.go | 2 +- formatter/severity.go | 7 ++++-- formatter/stylish.go | 2 +- formatter/unix.go | 2 +- lint/config.go | 15 +++++++++--- lint/file.go | 41 +++++++++++++++++++++++--------- lint/formatter.go | 2 +- main.go | 6 ++++- 16 files changed, 105 insertions(+), 28 deletions(-) diff --git a/README.md b/README.md index 7b2ae7d..4bc968b 100644 --- a/README.md +++ b/README.md @@ -140,7 +140,7 @@ revive -config revive.toml -exclude file1.go -exclude file2.go -formatter friend - The output will be formatted with the `friendly` formatter - The linter will analyze `github.com/mgechev/revive` and the files in `package` -### Comment Annotations +### Comment Directives Using comments, you can disable the linter for the entire file or only range of lines: @@ -167,6 +167,28 @@ func Public() private { This way, `revive` will not warn you for that you're returning an object of an unexported type, from an exported function. +You can document why you disable the linter by adding a trailing text in the directive, for example + +```go +//revive:disable Until the code is stable +``` +```go +//revive:disable:cyclomatic High complexity score but easy to understand +``` + +You can also configure `revive` to enforce documenting linter disabling directives by adding + +```toml +[directive.specify-disable-reason] +``` + +in the configuration. You can set the severity (defaults to _warning_) of the violation of this directive + +```toml +[directive.specify-disable-reason] + severity = "error" +``` + ### Configuration `revive` can be configured with a TOML file. Here's a sample configuration with explanation for the individual properties: @@ -399,7 +421,7 @@ Each formatter needs to implement the following interface: ```go type Formatter interface { - Format(<-chan Failure, RulesConfig) (string, error) + Format(<-chan Failure, Config) (string, error) Name() string } ``` diff --git a/config.go b/config.go index a577641..e6bb1af 100644 --- a/config.go +++ b/config.go @@ -142,6 +142,12 @@ func normalizeConfig(config *lint.Config) { } config.Rules[k] = v } + for k, v := range config.Directives { + if v.Severity == "" { + v.Severity = severity + } + config.Directives[k] = v + } } } diff --git a/fixtures/disable-annotations2.go b/fixtures/disable-annotations2.go index 36cd65b..d82a78f 100644 --- a/fixtures/disable-annotations2.go +++ b/fixtures/disable-annotations2.go @@ -6,6 +6,13 @@ func foo1() { var invalid_name2 = 1 //revive:disable-line:var-naming } +func foo11() { + //revive:disable-next-line:var-naming I'm an Eiffel programmer thus I like underscores + var invalid_name = 0 + var invalid_name2 = 1 //revive:disable-line:var-naming I'm an Eiffel programmer thus I like underscores +} + + func foo2() { // revive:disable-next-line:var-naming //revive:disable @@ -22,3 +29,10 @@ func foo3() { /* revive:disable-next-line:var-naming */ var invalid_name3 = 0 // MATCH /don't use underscores in Go names; var invalid_name3 should be invalidName3/ } + +func foo2p1() { + //revive:disable Underscores are fine + var invalid_name = 0 + //revive:enable No! Underscores are not nice! + var invalid_name2 = 1 // MATCH /don't use underscores in Go names; var invalid_name2 should be invalidName2/ +} diff --git a/formatter/checkstyle.go b/formatter/checkstyle.go index 6f7e20a..bd20da8 100644 --- a/formatter/checkstyle.go +++ b/formatter/checkstyle.go @@ -28,7 +28,7 @@ type issue struct { } // Format formats the failures gotten from the lint. -func (f *Checkstyle) Format(failures <-chan lint.Failure, config lint.RulesConfig) (string, error) { +func (f *Checkstyle) Format(failures <-chan lint.Failure, config lint.Config) (string, error) { var issues = map[string][]issue{} for failure := range failures { buf := new(bytes.Buffer) diff --git a/formatter/default.go b/formatter/default.go index 415c95c..145e6d5 100644 --- a/formatter/default.go +++ b/formatter/default.go @@ -18,7 +18,7 @@ func (f *Default) Name() string { } // Format formats the failures gotten from the lint. -func (f *Default) Format(failures <-chan lint.Failure, _ lint.RulesConfig) (string, error) { +func (f *Default) Format(failures <-chan lint.Failure, _ lint.Config) (string, error) { for failure := range failures { fmt.Printf("%v: %s\n", failure.Position.Start, failure.Failure) } diff --git a/formatter/friendly.go b/formatter/friendly.go index 01f22c8..a543eeb 100644 --- a/formatter/friendly.go +++ b/formatter/friendly.go @@ -37,7 +37,7 @@ func (f *Friendly) Name() string { } // Format formats the failures gotten from the lint. -func (f *Friendly) Format(failures <-chan lint.Failure, config lint.RulesConfig) (string, error) { +func (f *Friendly) Format(failures <-chan lint.Failure, config lint.Config) (string, error) { errorMap := map[string]int{} warningMap := map[string]int{} totalErrors := 0 diff --git a/formatter/json.go b/formatter/json.go index 74ed585..9c939fa 100644 --- a/formatter/json.go +++ b/formatter/json.go @@ -24,7 +24,7 @@ type jsonObject struct { } // Format formats the failures gotten from the lint. -func (f *JSON) Format(failures <-chan lint.Failure, config lint.RulesConfig) (string, error) { +func (f *JSON) Format(failures <-chan lint.Failure, config lint.Config) (string, error) { var slice []jsonObject for failure := range failures { obj := jsonObject{} diff --git a/formatter/ndjson.go b/formatter/ndjson.go index 7b5ba61..aa2b1d6 100644 --- a/formatter/ndjson.go +++ b/formatter/ndjson.go @@ -19,7 +19,7 @@ func (f *NDJSON) Name() string { } // Format formats the failures gotten from the lint. -func (f *NDJSON) Format(failures <-chan lint.Failure, config lint.RulesConfig) (string, error) { +func (f *NDJSON) Format(failures <-chan lint.Failure, config lint.Config) (string, error) { enc := json.NewEncoder(os.Stdout) for failure := range failures { obj := jsonObject{} diff --git a/formatter/plain.go b/formatter/plain.go index aef9a0c..a854d25 100644 --- a/formatter/plain.go +++ b/formatter/plain.go @@ -18,7 +18,7 @@ func (f *Plain) Name() string { } // Format formats the failures gotten from the lint. -func (f *Plain) Format(failures <-chan lint.Failure, _ lint.RulesConfig) (string, error) { +func (f *Plain) Format(failures <-chan lint.Failure, _ lint.Config) (string, error) { for failure := range failures { fmt.Printf("%v: %s %s\n", failure.Position.Start, failure.Failure, "https://revive.run/r#"+failure.RuleName) } diff --git a/formatter/severity.go b/formatter/severity.go index 06ba082..a43bf31 100644 --- a/formatter/severity.go +++ b/formatter/severity.go @@ -2,8 +2,11 @@ package formatter import "github.com/mgechev/revive/lint" -func severity(config lint.RulesConfig, failure lint.Failure) lint.Severity { - if config, ok := config[failure.RuleName]; ok && config.Severity == lint.SeverityError { +func severity(config lint.Config, failure lint.Failure) lint.Severity { + if config, ok := config.Rules[failure.RuleName]; ok && config.Severity == lint.SeverityError { + return lint.SeverityError + } + if config, ok := config.Directives[failure.RuleName]; ok && config.Severity == lint.SeverityError { return lint.SeverityError } return lint.SeverityWarning diff --git a/formatter/stylish.go b/formatter/stylish.go index dd8e18b..cd81fda 100644 --- a/formatter/stylish.go +++ b/formatter/stylish.go @@ -32,7 +32,7 @@ func formatFailure(failure lint.Failure, severity lint.Severity) []string { } // Format formats the failures gotten from the lint. -func (f *Stylish) Format(failures <-chan lint.Failure, config lint.RulesConfig) (string, error) { +func (f *Stylish) Format(failures <-chan lint.Failure, config lint.Config) (string, error) { var result [][]string var totalErrors = 0 var total = 0 diff --git a/formatter/unix.go b/formatter/unix.go index 849866f..b9ae62d 100644 --- a/formatter/unix.go +++ b/formatter/unix.go @@ -19,7 +19,7 @@ func (f *Unix) Name() string { } // Format formats the failures gotten from the lint. -func (f *Unix) Format(failures <-chan lint.Failure, _ lint.RulesConfig) (string, error) { +func (f *Unix) Format(failures <-chan lint.Failure, _ lint.Config) (string, error) { for failure := range failures { fmt.Printf("%v: [%s] %s\n", failure.Position.Start, failure.RuleName, failure.Failure) } diff --git a/lint/config.go b/lint/config.go index 05d8fae..fe65ace 100644 --- a/lint/config.go +++ b/lint/config.go @@ -12,12 +12,21 @@ type RuleConfig struct { // RulesConfig defines the config for all rules. type RulesConfig = map[string]RuleConfig +// DirectiveConfig is type used for the linter directive configuration. +type DirectiveConfig struct { + Severity Severity +} + +// DirectivesConfig defines the config for all directives. +type DirectivesConfig = map[string]DirectiveConfig + // Config defines the config of the linter. type Config struct { IgnoreGeneratedHeader bool `toml:"ignoreGeneratedHeader"` Confidence float64 Severity Severity - Rules RulesConfig `toml:"rule"` - ErrorCode int `toml:"errorCode"` - WarningCode int `toml:"warningCode"` + Rules RulesConfig `toml:"rule"` + ErrorCode int `toml:"errorCode"` + WarningCode int `toml:"warningCode"` + Directives DirectivesConfig `toml:"directive"` } diff --git a/lint/file.go b/lint/file.go index 99dd69c..8bef9c2 100644 --- a/lint/file.go +++ b/lint/file.go @@ -97,9 +97,12 @@ func (f *File) isMain() bool { return false } +const directiveSpecifyDisableReason = "specify-disable-reason" + func (f *File) lint(rules []Rule, config Config, failures chan Failure) { rulesConfig := config.Rules - disabledIntervals := f.disabledIntervals(rules) + _, mustSpecifyDisableReason := config.Directives[directiveSpecifyDisableReason] + disabledIntervals := f.disabledIntervals(rules, mustSpecifyDisableReason, failures) for _, currentRule := range rules { ruleConfig := rulesConfig[currentRule.Name()] currentFailures := currentRule.Apply(f, ruleConfig.Arguments) @@ -126,9 +129,15 @@ type enableDisableConfig struct { position int } -func (f *File) disabledIntervals(rules []Rule) disabledIntervalsMap { - re := regexp.MustCompile(`^//[\s]*revive:(enable|disable)(?:-(line|next-line))?(?::([^\s]+))?[\s]*$`) +const directiveRE = `^//[\s]*revive:(enable|disable)(?:-(line|next-line))?(?::([^\s]+))?[\s]*(?: (.+))?$` +const directivePos = 1 +const modifierPos = 2 +const rulesPos = 3 +const reasonPos = 4 +var re = regexp.MustCompile(directiveRE) + +func (f *File) disabledIntervals(rules []Rule, mustSpecifyDisableReason bool, failures chan Failure) disabledIntervalsMap { enabledDisabledRulesMap := make(map[string][]enableDisableConfig) getEnabledDisabledIntervals := func() disabledIntervalsMap { @@ -202,16 +211,26 @@ func (f *File) disabledIntervals(rules []Rule) disabledIntervalsMap { } ruleNames := []string{} - if len(match) > 2 { - tempNames := strings.Split(match[3], ",") - for _, name := range tempNames { - name = strings.Trim(name, "\n") - if len(name) > 0 { - ruleNames = append(ruleNames, name) - } + tempNames := strings.Split(match[rulesPos], ",") + for _, name := range tempNames { + name = strings.Trim(name, "\n") + if len(name) > 0 { + ruleNames = append(ruleNames, name) } } + mustCheckDisablingReason := mustSpecifyDisableReason && match[directivePos] == "disable" + if mustCheckDisablingReason && strings.Trim(match[reasonPos], " ") == "" { + failures <- Failure{ + Confidence: 1, + RuleName: directiveSpecifyDisableReason, + Failure: "reason of lint disabling not found", + Position: ToFailurePosition(c.Pos(), c.End(), f), + Node: c, + } + continue // skip this linter disabling directive + } + // TODO: optimize if len(ruleNames) == 0 { for _, rule := range rules { @@ -219,7 +238,7 @@ func (f *File) disabledIntervals(rules []Rule) disabledIntervalsMap { } } - handleRules(filename, match[2], match[1] == "enable", line, ruleNames) + handleRules(filename, match[modifierPos], match[directivePos] == "enable", line, ruleNames) } } diff --git a/lint/formatter.go b/lint/formatter.go index 3d87353..7c19af2 100644 --- a/lint/formatter.go +++ b/lint/formatter.go @@ -9,6 +9,6 @@ type FormatterMetadata struct { // Formatter defines an interface for failure formatters type Formatter interface { - Format(<-chan Failure, RulesConfig) (string, error) + Format(<-chan Failure, Config) (string, error) Name() string } diff --git a/main.go b/main.go index 8498b55..6851c98 100644 --- a/main.go +++ b/main.go @@ -44,7 +44,7 @@ func main() { var output string go (func() { - output, err = formatter.Format(formatChan, config.Rules) + output, err = formatter.Format(formatChan, *config) if err != nil { fail(err.Error()) } @@ -62,6 +62,10 @@ func main() { if c, ok := config.Rules[f.RuleName]; ok && c.Severity == lint.SeverityError { exitCode = config.ErrorCode } + if c, ok := config.Directives[f.RuleName]; ok && c.Severity == lint.SeverityError { + exitCode = config.ErrorCode + } + formatChan <- f } From b8a34fed229e691ba6d1f264b906d2a4af34601f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 2 Aug 2019 08:21:49 -0700 Subject: [PATCH 74/74] chore(deps): update golang.org/x/tools commit hash to e9bb7d3 (#203) --- go.mod | 2 +- go.sum | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 09134be..a069d28 100644 --- a/go.mod +++ b/go.mod @@ -10,5 +10,5 @@ require ( github.com/olekukonko/tablewriter v0.0.1 github.com/pkg/errors v0.8.1 golang.org/x/sys v0.0.0-20190801053355-cbf593c0f2f3 // indirect - golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa + golang.org/x/tools v0.0.0-20190802005412-e9bb7d36c060 ) diff --git a/go.sum b/go.sum index d10bcc7..9519d8b 100644 --- a/go.sum +++ b/go.sum @@ -148,3 +148,5 @@ golang.org/x/tools v0.0.0-20190730215743-ed3277de2799 h1:QDcqPiPMwhOSeNS/65AYJQx golang.org/x/tools v0.0.0-20190730215743-ed3277de2799/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa h1:crSxYKs/4ckOznRS/ORDRJikUnqR5pcExM2Q9fNghbw= golang.org/x/tools v0.0.0-20190731224408-1e85ed8060aa/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI= +golang.org/x/tools v0.0.0-20190802005412-e9bb7d36c060 h1:ixdNsWPlaysKGPShUO+OF5eF/dSQOGTB86mRds+STrY= +golang.org/x/tools v0.0.0-20190802005412-e9bb7d36c060/go.mod h1:jcCCGcm9btYwXyDqrUWc6MKQKKGJCWEQ3AfLSRIbEuI=