go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-07-17 01:12:27 +02:00
Code Issues Releases Activity

fix issue #355 (#356)

Browse Source
This commit is contained in:
SalvadorC
2020-02-26 21:32:47 +01:00
committed by GitHub
parent 90098926eb
commit 8f61c9ad71
2 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
fixtures/modifies-param.go
View File

@ -1,26 +1,25 @@
package fixtures package fixtures
import (
"go/ast"
)
func one(a int) { func one(a int) {
a,b:= 1,2 // MATCH /parameter 'a' seems to be modified/ a, b := 1, 2 // MATCH /parameter 'a' seems to be modified/
a++ // MATCH /parameter 'a' seems to be modified/ a++ // MATCH /parameter 'a' seems to be modified/
} }
func two(b, c float32) { func two(b, c float32) {
if c>0.0 { if c > 0.0 {
b = 1 // MATCH /parameter 'b' seems to be modified/ b = 1 // MATCH /parameter 'b' seems to be modified/
} }
} }
type foo struct { type foo struct {
a string a string
} }
func three(s *foo) { func three(s *foo) {
s.a = "foooooo" s.a = "foooooo"
} }
// non regression test for issue 355
func issue355(_ *foo) {
_ = "foooooo"
}

4
rule/modifies-param.go
View File

@ -37,6 +37,10 @@ func retrieveParamNames(pl []*ast.Field) map[string]bool {
result := make(map[string]bool, len(pl)) result := make(map[string]bool, len(pl))
for _, p := range pl { for _, p := range pl {
for _, n := range p.Names { for _, n := range p.Names {
if n.Name == "_" {
continue
}
result[n.Name] = true result[n.Name] = true
} }
} }