1
0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00

test: re-enable and fix test case for getVersion (#1246)

This commit is contained in:
Oleksandr Redko
2025-02-21 18:33:13 +02:00
committed by GitHub
parent 8cd85e4e6c
commit 9177f5044a
2 changed files with 22 additions and 38 deletions

View File

@@ -12,6 +12,7 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
go-version: go-version:
- 1.22
- oldstable - oldstable
- stable - stable
steps: steps:

View File

@@ -1,6 +1,7 @@
package cli package cli
import ( import (
goversion "go/version"
"os" "os"
"path/filepath" "path/filepath"
"runtime" "runtime"
@@ -96,45 +97,27 @@ func TestXDGConfigDirNoFile(t *testing.T) {
} }
func TestGetVersion(t *testing.T) { func TestGetVersion(t *testing.T) {
tests := []struct { t.Run("Development version", func(t *testing.T) {
name string got := getVersion(defaultBuilder, defaultDate, defaultCommit, defaultVersion)
version string want := "version (devel)\n"
commit string if goversion.Compare(runtime.Version(), "go1.24") < 0 {
date string want = "version \n"
builtBy string }
want string
}{ if got != want {
// TODO re-activate the testcase t.Errorf("getVersion() = %q, want %q", got, want)
/* }
{ })
name: "Development version",
version: defaultVersion, t.Run("Release version", func(t *testing.T) {
commit: defaultCommit, got := getVersion("builder", "2024-11-15 10:52 UTC", "7ee4500e125e2d1b12653b2c8e140fec380919b4", "v1.5.0-12-g7ee4500-dev")
date: defaultDate, want := `Version: v1.5.0-12-g7ee4500-dev
builtBy: defaultBuilder,
want: "version \n",
},
*/
{
name: "Release version",
version: "v1.5.0-12-g7ee4500-dev",
commit: "7ee4500e125e2d1b12653b2c8e140fec380919b4",
date: "2024-11-15 10:52 UTC",
builtBy: "builder",
want: `Version: v1.5.0-12-g7ee4500-dev
Commit: 7ee4500e125e2d1b12653b2c8e140fec380919b4 Commit: 7ee4500e125e2d1b12653b2c8e140fec380919b4
Built 2024-11-15 10:52 UTC by builder Built 2024-11-15 10:52 UTC by builder
`, `
},
}
for _, tt := range tests { if got != want {
t.Run(tt.name, func(t *testing.T) { t.Errorf("getVersion() = %q, want %q", got, want)
got := getVersion(tt.builtBy, tt.date, tt.commit, tt.version) }
})
if got != tt.want {
t.Errorf("getVersion() = %q, want %q", got, tt.want)
}
})
}
} }