go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2024-11-28 08:49:11 +02:00
Code Issues Releases Activity

fix 525 (#526)

Browse Source
This commit is contained in:
SalvadorC 2021-05-26 00:09:05 +02:00 committed by GitHub
parent 052235cc63
commit 97ef50d9f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rule/context-as-argument.go
View File

@ -45,16 +45,19 @@ func (w lintContextArguments) Visit(n ast.Node) ast.Visitor {
} }
// A context.Context should be the first parameter of a function. // A context.Context should be the first parameter of a function.
// Flag any that show up after the first. // Flag any that show up after the first.
previousArgIsCtx := isPkgDot(fn.Type.Params.List[0].Type, "context", "Context")
for _, arg := range fn.Type.Params.List[1:] { for _, arg := range fn.Type.Params.List[1:] {
if isPkgDot(arg.Type, "context", "Context") { argIsCtx := isPkgDot(arg.Type, "context", "Context")
if argIsCtx && !previousArgIsCtx {
w.onFailure(lint.Failure{ w.onFailure(lint.Failure{
Node: fn, Node: arg,
Category: "arg-order", Category: "arg-order",
Failure: "context.Context should be the first parameter of a function", Failure: "context.Context should be the first parameter of a function",
Confidence: 0.9, Confidence: 0.9,
}) })
break // only flag one break // only flag one
} }
previousArgIsCtx = argIsCtx
} }
return w return w
} }

4
testdata/golint/context-as-argument.go vendored
View File

@ -22,3 +22,7 @@ func y(s string, ctx context.Context) { // MATCH /context.Context should be the
// An invalid context.Context location with more than 2 args // An invalid context.Context location with more than 2 args
func y(s string, r int, ctx context.Context, x int) { // MATCH /context.Context should be the first parameter of a function/ func y(s string, r int, ctx context.Context, x int) { // MATCH /context.Context should be the first parameter of a function/
} }
func y(ctx1 context.Context, ctx2 context.Context, x int) {}
func y(ctx1 context.Context, ctx2 context.Context, x int, ctx3 context.Context) {} // MATCH /context.Context should be the first parameter of a function/