go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-29 22:28:23 +02:00
Code Issues Releases Activity

refactor: replace panic with error in rules (#1126)

Browse Source 
Co-authored-by: chavacava <salvadorcavadini+github@gmail.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
This commit is contained in:
Marcin Federowicz
2024-12-11 19:35:58 +01:00
committed by GitHub
parent 10d9697cc2
commit 9b15f3fcb6
35 changed files with 514 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
rule/function_length.go
View File

@@ -17,15 +17,24 @@ type FunctionLength struct {
configureOnce sync.Once
}
func (r *FunctionLength) configure(arguments lint.Arguments) {
maxStmt, maxLines := r.parseArguments(arguments)
func (r *FunctionLength) configure(arguments lint.Arguments) error {
maxStmt, maxLines, err := r.parseArguments(arguments)
if err != nil {
return err
}
r.maxStmt = int(maxStmt)
r.maxLines = int(maxLines)
return nil
}
// Apply applies the rule to given file.
func (r *FunctionLength) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure {
r.configureOnce.Do(func() { r.configure(arguments) })
var configureErr error
r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
if configureErr != nil {
return newInternalFailureError(configureErr)
}
var failures []lint.Failure
for _, decl := range file.AST.Decls {
@@ -74,33 +83,33 @@ func (*FunctionLength) Name() string {
const defaultFuncStmtsLimit = 50
const defaultFuncLinesLimit = 75
func (*FunctionLength) parseArguments(arguments lint.Arguments) (maxStmt, maxLines int64) {
func (*FunctionLength) parseArguments(arguments lint.Arguments) (maxStmt, maxLines int64, err error) {
if len(arguments) == 0 {
return defaultFuncStmtsLimit, defaultFuncLinesLimit
return defaultFuncStmtsLimit, defaultFuncLinesLimit, nil
}
const minArguments = 2
if len(arguments) != minArguments {
panic(fmt.Sprintf(`invalid configuration for "function-length" rule, expected %d arguments but got %d`, minArguments, len(arguments)))
return 0, 0, fmt.Errorf(`invalid configuration for "function-length" rule, expected %d arguments but got %d`, minArguments, len(arguments))
}
maxStmt, maxStmtOk := arguments[0].(int64)
if !maxStmtOk {
panic(fmt.Sprintf(`invalid configuration value for max statements in "function-length" rule; need int64 but got %T`, arguments[0]))
return 0, 0, fmt.Errorf(`invalid configuration value for max statements in "function-length" rule; need int64 but got %T`, arguments[0])
}
if maxStmt < 0 {
panic(fmt.Sprintf(`the configuration value for max statements in "function-length" rule cannot be negative, got %d`, maxStmt))
return 0, 0, fmt.Errorf(`the configuration value for max statements in "function-length" rule cannot be negative, got %d`, maxStmt)
}
maxLines, maxLinesOk := arguments[1].(int64)
if !maxLinesOk {
panic(fmt.Sprintf(`invalid configuration value for max lines in "function-length" rule; need int64 but got %T`, arguments[1]))
return 0, 0, fmt.Errorf(`invalid configuration value for max lines in "function-length" rule; need int64 but got %T`, arguments[1])
}
if maxLines < 0 {
panic(fmt.Sprintf(`the configuration value for max statements in "function-length" rule cannot be negative, got %d`, maxLines))
return 0, 0, fmt.Errorf(`the configuration value for max statements in "function-length" rule cannot be negative, got %d`, maxLines)
}
return maxStmt, maxLines
return maxStmt, maxLines, nil
}
func (*FunctionLength) countLines(b *ast.BlockStmt, file *lint.File) int {