go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Code Issues Releases Activity

refactor: replace panic with error in rules (#1126)

Browse Source 
Co-authored-by: chavacava <salvadorcavadini+github@gmail.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
This commit is contained in:
Marcin Federowicz
2024-12-11 19:35:58 +01:00
committed by GitHub
parent 10d9697cc2
commit 9b15f3fcb6
35 changed files with 514 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
rule/function_result_limit.go
View File

@@ -1,6 +1,7 @@
package rule
import (
"errors"
"fmt"
"go/ast"
"sync"
@@ -17,7 +18,12 @@ type FunctionResultsLimitRule struct {
// Apply applies the rule to given file.
func (r *FunctionResultsLimitRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure {
r.configureOnce.Do(func() { r.configure(arguments) })
var configureErr error
r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
if configureErr != nil {
return newInternalFailureError(configureErr)
}
var failures []lint.Failure
for _, decl := range file.AST.Decls {
@@ -53,19 +59,20 @@ func (*FunctionResultsLimitRule) Name() string {
const defaultResultsLimit = 3
func (r *FunctionResultsLimitRule) configure(arguments lint.Arguments) {
func (r *FunctionResultsLimitRule) configure(arguments lint.Arguments) error {
if len(arguments) < 1 {
r.max = defaultResultsLimit
return
return nil
}
maxResults, ok := arguments[0].(int64) // Alt. non panicking version
if !ok {
panic(fmt.Sprintf(`invalid value passed as return results number to the "function-result-limit" rule; need int64 but got %T`, arguments[0]))
return fmt.Errorf(`invalid value passed as return results number to the "function-result-limit" rule; need int64 but got %T`, arguments[0])
}
if maxResults < 0 {
panic(`the value passed as return results number to the "function-result-limit" rule cannot be negative`)
return errors.New(`the value passed as return results number to the "function-result-limit" rule cannot be negative`)
}
r.max = int(maxResults)
return nil
}