go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-29 22:28:23 +02:00
Code Issues Releases Activity

refactor: replace panic with error in rules (#1126)

Browse Source 
Co-authored-by: chavacava <salvadorcavadini+github@gmail.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
This commit is contained in:
Marcin Federowicz
2024-12-11 19:35:58 +01:00
committed by GitHub
parent 10d9697cc2
commit 9b15f3fcb6
35 changed files with 514 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
rule/struct_tag.go
View File

@@ -18,21 +18,24 @@ type StructTagRule struct {
configureOnce sync.Once
}
func (r *StructTagRule) configure(arguments lint.Arguments) {
func (r *StructTagRule) configure(arguments lint.Arguments) error {
if len(arguments) == 0 {
return
return nil
}
checkNumberOfArguments(1, arguments, r.Name())
err := checkNumberOfArguments(1, arguments, r.Name())
if err != nil {
return err
}
r.userDefined = make(map[string][]string, len(arguments))
for _, arg := range arguments {
item, ok := arg.(string)
if !ok {
panic(fmt.Sprintf("Invalid argument to the %s rule. Expecting a string, got %v (of type %T)", r.Name(), arg, arg))
return fmt.Errorf("invalid argument to the %s rule. Expecting a string, got %v (of type %T)", r.Name(), arg, arg)
}
parts := strings.Split(item, ",")
if len(parts) < 2 {
panic(fmt.Sprintf("Invalid argument to the %s rule. Expecting a string of the form key[,option]+, got %s", r.Name(), item))
return fmt.Errorf("invalid argument to the %s rule. Expecting a string of the form key[,option]+, got %s", r.Name(), item)
}
key := strings.TrimSpace(parts[0])
for i := 1; i < len(parts); i++ {
@@ -40,11 +43,17 @@ func (r *StructTagRule) configure(arguments lint.Arguments) {
r.userDefined[key] = append(r.userDefined[key], option)
}
}
return nil
}
// Apply applies the rule to given file.
func (r *StructTagRule) Apply(file *lint.File, args lint.Arguments) []lint.Failure {
r.configureOnce.Do(func() { r.configure(args) })
func (r *StructTagRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure {
var configureErr error
r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
if configureErr != nil {
return newInternalFailureError(configureErr)
}
var failures []lint.Failure
onFailure := func(failure lint.Failure) {