fixes issue #280 (#282)

fixtures/bare-return.go

@@ -31,3 +31,38 @@ func bare4(a string, b int) string {
 func bare5(a string, b int) {
 	return
 }
+
+// NR tests for issue #280
+func f280_1() (err error) {
+	func() {
+		return
+	}()
+
+	return nil
+}
+
+func f280_2() (err error) {
+	func() (r int) {
+		return // MATCH /avoid using bare returns, please add return expressions/
+	}()
+
+	return nil
+}
+
+func f280_3() (err error) {
+	func() (r int) {
+		return 1
+	}()
+
+	return // MATCH /avoid using bare returns, please add return expressions/
+}
+
+func f280_4() (err error) {
+	func() (r int) {
+		return func() (r int) {
+			return // MATCH /avoid using bare returns, please add return expressions/
+		}()
+	}()
+
+	return nil
+}

rule/bare-return.go

@@ -58,6 +58,13 @@ type bareReturnFinder struct {
 }
 
 func (w bareReturnFinder) Visit(node ast.Node) ast.Visitor {
+	_, ok := node.(*ast.FuncLit)
+	if ok {
+		// skip analysing function literals
+		// they will analyzed by the lintBareReturnRule.Visit method
+		return nil
+	}
+
 	rs, ok := node.(*ast.ReturnStmt)
 	if !ok {
 		return w