go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-07-15 01:04:40 +02:00
Code Issues Releases Activity

Refactoring: removes unused function from modifies-param rule code (#50)

Browse Source
This commit is contained in:
SalvadorC
2018-08-14 00:19:00 +02:00
committed by Minko Gechev
parent 613fd24a3b
commit a2a52e398b
1 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
rule/modifies-param.go
View File

@ -43,23 +43,6 @@ func retrieveParamNames(pl []*ast.Field) map[string]bool {
return result return result
} }
func checkAssign(lhs []ast.Expr, w lintModifiesParamRule) {
for _, e := range lhs {
id, ok := e.(*ast.Ident)
if ok {
if w.params[id.Name] {
w.onFailure(lint.Failure{
Confidence: 0.5,
Node: id,
Category: "bad practice",
URL: "#modifies-parameter",
Failure: fmt.Sprintf("parameter '%s' seems to be a modified", id.Name),
})
}
}
}
}
func (w lintModifiesParamRule) Visit(node ast.Node) ast.Visitor { func (w lintModifiesParamRule) Visit(node ast.Node) ast.Visitor {
switch v := node.(type) { switch v := node.(type) {
case *ast.FuncDecl: case *ast.FuncDecl: