go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Code Issues Releases Activity

simplify: redundant map composite literal (#528)

Browse Source
This commit is contained in:
sina safari
2021-06-01 00:24:58 +04:30
committed by GitHub
parent c4d52d202d
commit b5ff6325c2
6 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
rule/add-constant.go
View File

@@ -2,10 +2,11 @@ package rule
import ( import (
"fmt" "fmt"
"github.com/mgechev/revive/lint"
"go/ast" "go/ast"
"strconv" "strconv"
"strings" "strings"
"github.com/mgechev/revive/lint"
) )
const ( const (
@@ -18,7 +19,7 @@ const (
type whiteList map[string]map[string]bool type whiteList map[string]map[string]bool
func newWhiteList() whiteList { func newWhiteList() whiteList {
return map[string]map[string]bool{kindINT: map[string]bool{}, kindFLOAT: map[string]bool{}, kindSTRING: map[string]bool{}} return map[string]map[string]bool{kindINT: {}, kindFLOAT: {}, kindSTRING: {}}
} }
func (wl whiteList) add(kind string, list string) { func (wl whiteList) add(kind string, list string) {

2
rule/call-to-gc.go
View File

@@ -17,7 +17,7 @@ func (r *CallToGCRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
} }
var gcTriggeringFunctions = map[string]map[string]bool{ var gcTriggeringFunctions = map[string]map[string]bool{
"runtime": map[string]bool{"GC": true}, "runtime": {"GC": true},
} }
w := lintCallToGC{onFailure, gcTriggeringFunctions} w := lintCallToGC{onFailure, gcTriggeringFunctions}

6
rule/deep-exit.go
View File

@@ -18,9 +18,9 @@ func (r *DeepExitRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
} }
var exitFunctions = map[string]map[string]bool{ var exitFunctions = map[string]map[string]bool{
"os": map[string]bool{"Exit": true}, "os": {"Exit": true},
"syscall": map[string]bool{"Exit": true}, "syscall": {"Exit": true},
"log": map[string]bool{ "log": {
"Fatal": true, "Fatal": true,
"Fatalf": true, "Fatalf": true,
"Fatalln": true, "Fatalln": true,

4
rule/superfluous-else.go
View File

@@ -19,8 +19,8 @@ func (r *SuperfluousElseRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
} }
var branchingFunctions = map[string]map[string]bool{ var branchingFunctions = map[string]map[string]bool{
"os": map[string]bool{"Exit": true}, "os": {"Exit": true},
"log": map[string]bool{ "log": {
"Fatal": true, "Fatal": true,
"Fatalf": true, "Fatalf": true,
"Fatalln": true, "Fatalln": true,

6
rule/unconditional-recursion.go
View File

@@ -137,9 +137,9 @@ func (w *lintUnconditionalRecursionRule) updateFuncStatus(node ast.Node) {
} }
var exitFunctions = map[string]map[string]bool{ var exitFunctions = map[string]map[string]bool{
"os": map[string]bool{"Exit": true}, "os": {"Exit": true},
"syscall": map[string]bool{"Exit": true}, "syscall": {"Exit": true},
"log": map[string]bool{ "log": {
"Fatal": true, "Fatal": true,
"Fatalf": true, "Fatalf": true,
"Fatalln": true, "Fatalln": true,

4
rule/unreachable-code.go
View File

@@ -17,8 +17,8 @@ func (r *UnreachableCodeRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
} }
var branchingFunctions = map[string]map[string]bool{ var branchingFunctions = map[string]map[string]bool{
"os": map[string]bool{"Exit": true}, "os": {"Exit": true},
"log": map[string]bool{ "log": {
"Fatal": true, "Fatal": true,
"Fatalf": true, "Fatalf": true,
"Fatalln": true, "Fatalln": true,