go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-02-09 13:37:14 +02:00
Code Issues Releases Activity

fix #622 (Rule 'var-naming' should allow Fuzz_xxx) (#623)

Browse Source
This commit is contained in:
chavacava 2022-01-18 15:26:29 +01:00 committed by GitHub
parent af953e6189
commit b721f69625
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rule/var-naming.go
View File

@ -145,7 +145,12 @@ func (w *lintNames) Visit(n ast.Node) ast.Visitor {
}
}
case *ast.FuncDecl:
if w.file.IsTest() && (strings.HasPrefix(v.Name.Name, "Example") || strings.HasPrefix(v.Name.Name, "Test") || strings.HasPrefix(v.Name.Name, "Benchmark")) {
funcName := v.Name.Name
if w.file.IsTest() &&
(strings.HasPrefix(funcName, "Example") ||
strings.HasPrefix(funcName, "Test") ||
strings.HasPrefix(funcName, "Benchmark") ||
strings.HasPrefix(funcName, "Fuzz")) {
return w
}

2
test/var-naming_test.go
View File

@ -11,4 +11,6 @@ func TestVarNaming(t *testing.T) {
testRule(t, "var-naming", &rule.VarNamingRule{}, &lint.RuleConfig{
Arguments: []interface{}{[]interface{}{"ID"}, []interface{}{"VM"}},
})
testRule(t, "var-naming_test", &rule.VarNamingRule{}, &lint.RuleConfig{})
}

12
testdata/var-naming_test.go vendored Normal file
View File

@ -0,0 +1,12 @@
// Test for name linting.
// Package pkg_with_underscores ...
package varnaming_test
var var_name int // MATCH /don't use underscores in Go names; var var_name should be varName/
func Test_ATest() {}
func Example_AnExample() {}
func Benchmark_ABenchmark() {}
func Fuzz_AFuzz() {}