go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

change: merge code-style with style categories (#1573)

Browse Source 
* change: merge code-style with style categories

* deprecate variable
This commit is contained in:
Oleksandr Redko
2025-11-09 19:18:26 +02:00
committed by GitHub
parent 010d7b28ec
commit b73cca9e66
6 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lint/failure.go
View File

@@ -11,6 +11,8 @@ const (
// FailureCategoryBadPractice indicates bad practice issues. // FailureCategoryBadPractice indicates bad practice issues.
FailureCategoryBadPractice FailureCategory = "bad practice" FailureCategoryBadPractice FailureCategory = "bad practice"
// FailureCategoryCodeStyle indicates code style issues. // FailureCategoryCodeStyle indicates code style issues.
//
// Deprecated: use FailureCategoryStyle instead.
FailureCategoryCodeStyle FailureCategory = "code-style" FailureCategoryCodeStyle FailureCategory = "code-style"
// FailureCategoryComments indicates comment issues. // FailureCategoryComments indicates comment issues.
FailureCategoryComments FailureCategory = "comments" FailureCategoryComments FailureCategory = "comments"

2
rule/file_length_limit.go
View File

@@ -57,7 +57,7 @@ func (r *FileLengthLimitRule) Apply(file *lint.File, _ lint.Arguments) []lint.Fa
return []lint.Failure{ return []lint.Failure{
{ {
Category: lint.FailureCategoryCodeStyle, Category: lint.FailureCategoryStyle,
Confidence: 1, Confidence: 1,
Position: lint.FailurePosition{ Position: lint.FailurePosition{
Start: token.Position{ Start: token.Position{

2
rule/inefficient_map_lookup.go
View File

@@ -99,7 +99,7 @@ func (w *lintInefficientMapLookup) analyzeBlock(b *ast.BlockStmt) {
w.onFailure(lint.Failure{ w.onFailure(lint.Failure{
Confidence: 1, Confidence: 1,
Node: rangeOverMap, Node: rangeOverMap,
Category: lint.FailureCategoryCodeStyle, Category: lint.FailureCategoryStyle,
Failure: "inefficient lookup of map key", Failure: "inefficient lookup of map key",
}) })
} }

2
rule/line_length_limit.go
View File

@@ -76,7 +76,7 @@ func (r lintLineLengthNum) check() {
c := utf8.RuneCountInString(t) c := utf8.RuneCountInString(t)
if c > r.max { if c > r.max {
r.onFailure(lint.Failure{ r.onFailure(lint.Failure{
Category: lint.FailureCategoryCodeStyle, Category: lint.FailureCategoryStyle,
Position: lint.FailurePosition{ Position: lint.FailurePosition{
// Offset not set; it is non-trivial, and doesn't appear to be needed. // Offset not set; it is non-trivial, and doesn't appear to be needed.
Start: token.Position{ Start: token.Position{

2
rule/use_waitgroup_go.go
View File

@@ -113,7 +113,7 @@ func (w *lintUseWaitGroupGo) analyzeBlock(b *ast.BlockStmt) {
w.onFailure(lint.Failure{ w.onFailure(lint.Failure{
Confidence: 1, Confidence: 1,
Node: call, Node: call,
Category: lint.FailureCategoryCodeStyle, Category: lint.FailureCategoryStyle,
Failure: "replace wg.Add()...go {...wg.Done()...} with wg.Go(...)", Failure: "replace wg.Add()...go {...wg.Done()...} with wg.Go(...)",
}) })

2
rule/useless_fallthrough.go
View File

@@ -81,7 +81,7 @@ func (w *lintUselessFallthrough) Visit(node ast.Node) ast.Visitor {
w.onFailure(lint.Failure{ w.onFailure(lint.Failure{
Confidence: confidence, Confidence: confidence,
Node: branchStmt, Node: branchStmt,
Category: lint.FailureCategoryCodeStyle, Category: lint.FailureCategoryStyle,
Failure: `this "fallthrough" can be removed by consolidating this case clause with the next one`, Failure: `this "fallthrough" can be removed by consolidating this case clause with the next one`,
}) })