go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-02-03 13:11:25 +02:00
Code Issues Releases Activity

fix issue [#59] (#70)

Browse Source
This commit is contained in:
SalvadorC 2018-09-21 19:51:01 +02:00 committed by Minko Gechev
parent 0c79a9c405
commit bd4139713d
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lint/package.go
View File

@ -77,7 +77,9 @@ func (p *Package) TypeCheck() error {
anyFile = f anyFile = f
astFiles = append(astFiles, f.AST) astFiles = append(astFiles, f.AST)
} }
typesPkg, err := config.Check(anyFile.AST.Name.Name, p.fset, astFiles, info)
typesPkg, err := check(config, anyFile.AST.Name.Name, p.fset, astFiles, info)
// Remember the typechecking info, even if config.Check failed, // Remember the typechecking info, even if config.Check failed,
// since we will get partial information. // since we will get partial information.
p.TypesPkg = typesPkg p.TypesPkg = typesPkg
@ -86,6 +88,20 @@ func (p *Package) TypeCheck() error {
return err return err
} }
// check function encapsulates the call to go/types.Config.Check method and
// recovers if the called method panics (see issue #59)
func check(config *types.Config, n string, fset *token.FileSet, astFiles []*ast.File, info *types.Info) (p *types.Package, err error) {
defer func() {
if r := recover(); r != nil {
err, _ = r.(error)
p = nil
return
}
}()
return config.Check(n, fset, astFiles, info)
}
// TypeOf returns the type of an expression. // TypeOf returns the type of an expression.
func (p *Package) TypeOf(expr ast.Expr) types.Type { func (p *Package) TypeOf(expr ast.Expr) types.Type {
if p.TypesInfo == nil { if p.TypesInfo == nil {