go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

fixes issue #98 (#99)

Browse Source
This commit is contained in:
SalvadorC
2019-01-18 16:33:40 +01:00
committed by Minko Gechev
parent b4cc152955
commit c878d3090d
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fixtures/line-length-limit.go
View File

@@ -5,3 +5,13 @@ import "fmt"
func foo(a, b int) {
fmt.Printf("single line characters out of limit") // MATCH /line is 105 characters, out of limit 100/
}
// revive:disable-next-line:line-length-limit
// The length of this comment line is over 80 characters, this is bad for readability.
// Warn: the testing framework does not allow to check for failures in comments
func toto() {
// revive:disable-next-line:line-length-limit
fmt.Println("This line is way too long. In my opinion, it should be shortened.")
}

9
lint/file.go
View File

@@ -127,7 +127,7 @@ type enableDisableConfig struct {
}
func (f *File) disabledIntervals(rules []Rule) disabledIntervalsMap {
re := regexp.MustCompile(`^\s*revive:(enable|disable)(?:-(line|next-line))?(:|\s|$)`)
re := regexp.MustCompile(`^\s*revive:(enable|disable)(?:-(line|next-line))?(:)?([^\s]*)?(\s|$)`)
enabledDisabledRulesMap := make(map[string][]enableDisableConfig)
@@ -199,11 +199,10 @@ func (f *File) disabledIntervals(rules []Rule) disabledIntervalsMap {
if len(parts) == 0 {
return
}
str := re.FindString(text)
ruleNamesString := strings.Split(text, str)
ruleNames := []string{}
if len(ruleNamesString) == 2 {
tempNames := strings.Split(ruleNamesString[1], ",")
if len(parts) > 4 {
tempNames := strings.Split(parts[4], ",")
for _, name := range tempNames {
name = strings.Trim(name, "\n")
if len(name) > 0 {