go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Code Issues Releases Activity

feature: package-directory-mismatch - ignore main_test package name (#1545)

Browse Source 
Thanks for the PR @uloamaka !
This commit is contained in:
Godsgift Uloamaka Ebite
2025-10-15 06:24:17 +01:00
committed by GitHub
parent bc38b79980
commit d32d4a008f
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rule/package_directory_mismatch.go
View File

@@ -121,6 +121,10 @@ func (r *PackageDirectoryMismatchRule) Apply(file *lint.File, _ lint.Arguments)
} }
if file.IsTest() { if file.IsTest() {
// treat main_test differently because it's a common package name for tests
if packageName == "main_test" {
return nil
}
// External test package (directory + '_test' suffix) // External test package (directory + '_test' suffix)
if r.semanticallyEqual(packageName, dirName+"_test") { if r.semanticallyEqual(packageName, dirName+"_test") {
return nil return nil

1
test/package_directory_mismatch_test.go
View File

@@ -53,6 +53,7 @@ func TestPackageDirectoryMismatch(t *testing.T) {
testRule(t, "package_directory_mismatch/test/good", &rule.PackageDirectoryMismatchRule{}, config) testRule(t, "package_directory_mismatch/test/good", &rule.PackageDirectoryMismatchRule{}, config)
testRule(t, "package_directory_mismatch/test/bad_test", &rule.PackageDirectoryMismatchRule{}, config) testRule(t, "package_directory_mismatch/test/bad_test", &rule.PackageDirectoryMismatchRule{}, config)
testRule(t, "package_directory_mismatch/test/bad", &rule.PackageDirectoryMismatchRule{}, config) testRule(t, "package_directory_mismatch/test/bad", &rule.PackageDirectoryMismatchRule{}, config)
testRule(t, "package_directory_mismatch/test/main_test", &rule.PackageDirectoryMismatchRule{}, config)
} }
func TestPackageDirectoryMismatchWithDefaultConfig(t *testing.T) { func TestPackageDirectoryMismatchWithDefaultConfig(t *testing.T) {

1
testdata/package_directory_mismatch/test/main_test.go vendored Normal file
View File

@@ -0,0 +1 @@
package main_test