go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

fix binexp complexity logic

Browse Source
This commit is contained in:
chavacava
2019-12-14 16:18:53 +01:00
parent 2eae0cd122
commit d877a0d7e8
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rule/cognitive-complexity.go
View File

@@ -148,17 +148,14 @@ type binExprComplexityCalculator struct {
func (v *binExprComplexityCalculator) Visit(n ast.Node) ast.Visitor { func (v *binExprComplexityCalculator) Visit(n ast.Node) ast.Visitor {
switch n := n.(type) { switch n := n.(type) {
case *ast.UnaryExpr:
// TODO (chavacava): confirm if NOT should be taken into account
if n.Op == token.NOT {
v.complexity++
}
case *ast.BinaryExpr: case *ast.BinaryExpr:
isLogicOp := n.Op == token.LAND || n.Op == token.LOR isLogicOp := n.Op == token.LAND || n.Op == token.LOR
if isLogicOp && n.Op != v.currentOp { if isLogicOp && n.Op != v.currentOp {
v.complexity++ v.complexity++
v.currentOp = n.Op v.currentOp = n.Op
} }
case *ast.ParenExpr:
v.complexity++
} }
return v return v