go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-01-18 03:21:24 +02:00
Code Issues Releases Activity

chore: add missing tests for var-declarations, fix any/interface{} type issue (#1154)

Browse Source 
* chore: add missing tests for var-declarations, fix any/interface{} type issue
This commit is contained in:
Denis Voytyuk 2024-12-02 13:06:52 +01:00 committed by GitHub
parent cb74ccbf44
commit dde83449d7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
rule/var_declarations.go
View File

@ -85,7 +85,7 @@ func (w *lintVarDeclarations) Visit(node ast.Node) ast.Visitor {
// If the RHS is a isZero value, suggest dropping it.
isZero := false
if lit, ok := rhs.(*ast.BasicLit); ok {
isZero = zeroLiteral[lit.Value]
isZero = isZeroValue(lit.Value, v.Type)
} else if isIdent(rhs, "nil") {
isZero = true
}
@ -142,3 +142,16 @@ func validType(t types.Type) bool {
t != types.Typ[types.Invalid] &&
!strings.Contains(t.String(), "invalid type") // good but not foolproof
}
func isZeroValue(litValue string, typ ast.Expr) bool {
switch val := typ.(type) {
case *ast.Ident:
if val.Name == "any" {
return litValue == "nil"
}
case *ast.InterfaceType:
return litValue == "nil"
}
return zeroLiteral[litValue]
}

6
testdata/golint/var_declaration.go vendored
View File

@ -84,3 +84,9 @@ var y string = q(1).String() // MATCH /should omit type string from declaration
type q int
func (q) String() string { return "I'm a q" }
// The only true zero value for any/interface{} is nil. Others will be considered non-zero.
var z1 any = 0 // No warning, zero value for any is nil
var z2 any = nil // MATCH /should drop = nil from declaration of var z2; it is the zero value/
var z3 interface{} = 0 // No warning, zero value for any is nil
var z4 interface{} = nil // MATCH /should drop = nil from declaration of var z4; it is the zero value/