go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

refactor: modifies linting machinery to use Failure as a mean to signal erros in rules application (#1178)

Browse Source
This commit is contained in:
chavacava
2024-12-08 15:56:14 +01:00
committed by GitHub
parent f6a38208af
commit e23fcdb498
7 changed files with 50 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lint/file.go
View File

@@ -2,6 +2,7 @@ package lint
import (
"bytes"
"errors"
"go/ast"
"go/parser"
"go/printer"
@@ -96,7 +97,7 @@ func (f *File) isMain() bool {
const directiveSpecifyDisableReason = "specify-disable-reason"
func (f *File) lint(rules []Rule, config Config, failures chan Failure) {
func (f *File) lint(rules []Rule, config Config, failures chan Failure) error {
rulesConfig := config.Rules
_, mustSpecifyDisableReason := config.Directives[directiveSpecifyDisableReason]
disabledIntervals := f.disabledIntervals(rules, mustSpecifyDisableReason, failures)
@@ -107,6 +108,10 @@ func (f *File) lint(rules []Rule, config Config, failures chan Failure) {
}
currentFailures := currentRule.Apply(f, ruleConfig.Arguments)
for idx, failure := range currentFailures {
if failure.IsInternal() {
return errors.New(failure.Failure)
}
if failure.RuleName == "" {
failure.RuleName = currentRule.Name()
}
@@ -122,6 +127,7 @@ func (f *File) lint(rules []Rule, config Config, failures chan Failure) {
}
}
}
return nil
}
type enableDisableConfig struct {