go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-02-03 13:11:25 +02:00
Code Issues Releases Activity

Fix prefix trimming in struct-tag (#827)

Browse Source 
Fix #813
This commit is contained in:
Minko Gechev 2023-05-16 09:09:20 +03:00 committed by GitHub
parent 6d5bc51b50
commit ed6d9ce652
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rule/struct-tag.go
View File

@ -137,7 +137,7 @@ func (lintStructTagRule) getTagName(tag *structtag.Tag) string {
case keyProtobuf: case keyProtobuf:
for _, option := range tag.Options { for _, option := range tag.Options {
if strings.HasPrefix(option, "name=") { if strings.HasPrefix(option, "name=") {
return strings.TrimLeft(option, "name=") return strings.TrimPrefix(option, "name=")
} }
} }
return "" //protobuf tag lacks 'name' option return "" //protobuf tag lacks 'name' option

2
testdata/struct-tag.go vendored
View File

@ -116,6 +116,8 @@ type Simple struct {
ODouble *float64 `protobuf:"fixed64,014,opt,name=o_double,json=oDouble"` // MATCH /duplicated tag number 14/ ODouble *float64 `protobuf:"fixed64,014,opt,name=o_double,json=oDouble"` // MATCH /duplicated tag number 14/
ODoubleStr *float64 `protobuf:"fixed6,17,opt,name=o_double_str,json=oDoubleStr"` // MATCH /invalid protobuf tag name 'fixed6'/ ODoubleStr *float64 `protobuf:"fixed6,17,opt,name=o_double_str,json=oDoubleStr"` // MATCH /invalid protobuf tag name 'fixed6'/
OString *string `protobuf:"bytes,18,opt,name=o_string,json=oString"` OString *string `protobuf:"bytes,18,opt,name=o_string,json=oString"`
OString2 *string `protobuf:"bytes,name=ameno"`
OString3 *string `protobuf:"bytes,name=ameno"` // MATCH /duplicate tag name: 'ameno'/
XXX_NoUnkeyedLiteral struct{} `json:"-"` XXX_NoUnkeyedLiteral struct{} `json:"-"`
XXX_unrecognized []byte `json:"-"` XXX_unrecognized []byte `json:"-"`
XXX_sizecache int32 `json:"-"` XXX_sizecache int32 `json:"-"`