go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Code Issues Releases Activity

feature: new rule identical-ifelseif-conditions (#1454)

Browse Source
This commit is contained in:
chavacava
2025-08-04 06:58:14 +02:00
committed by GitHub
parent 12d96adfd4
commit f353e4b0e5
6 changed files with 222 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
testdata/identical_ifelseif_conditions.go vendored Normal file
View File

@@ -0,0 +1,53 @@
package fixtures
func identicalBranches() {
// no failure for nested ifs
if true {
if true {
}
} else {
if true {
}
}
// single failure
if a > 0 {
print("something")
} else if a < 0 {
print("something else")
} else if a == 0 {
print("other thing")
} else if a > 0 { // MATCH /"if...else if" chain with identical conditions (lines 14 and 20)/
println()
} else {
print("something")
}
// multiple failures in the same if...else if chain
if a > 0 {
print("something")
} else if a < 0 {
print("something else")
} else if a == 0 {
print("other thing")
} else if a > 0 { // MATCH /"if...else if" chain with identical conditions (lines 27 and 33)/
println()
} else if a == 0 { // MATCH /"if...else if" chain with identical conditions (lines 31 and 35)/
print("other thing")
} else {
print("something")
}
// failures in nested if...else if
if true {
if false {
} else if false { // MATCH /"if...else if" chain with identical conditions (lines 43 and 44)/
}
} else if foo() {
} else {
if false {
} else if false { // MATCH /"if...else if" chain with identical conditions (lines 49 and 50)/
}
}
}