go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-07-05 00:28:53 +02:00
Code Issues Releases Activity

refactor: remove tablewriter dependency (#1351)

Browse Source 
* Rewrite Friendly.table method to replace tablewriter with fmt.Fprintf

* Refactor Stylish formatter to use custom table rendering instead of tablewriter

* Refactor Friendly and Stylish formatters to utilize a new custom table rendering function

* Remove unused dependencies from go.mod and go.sum

* Refactor table formatting by replacing formatTable with a new table function in friendly.go

* Utilize text/tabwriter in fromatting a table

* Refactor table function to use bytes.Buffer for improved performance
This commit is contained in:
Hazhir Derakhshi
2025-05-17 18:33:14 +01:00
committed by GitHub
parent 254bb41730
commit f3f77bb387
5 changed files with 60 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
formatter/friendly.go
View File

@ -7,10 +7,10 @@ import (
"io"
"slices"
"strings"
"text/tabwriter"
"github.com/fatih/color"
"github.com/mgechev/revive/lint"
"github.com/olekukonko/tablewriter"
)
func getErrorEmoji() string {
@ -64,12 +64,12 @@ func (f *Friendly) printFriendlyFailure(sb *strings.Builder, failure lint.Failur
sb.WriteString("\n\n")
}
func (f *Friendly) printHeaderRow(sb *strings.Builder, failure lint.Failure, severity lint.Severity) {
func (*Friendly) printHeaderRow(sb *strings.Builder, failure lint.Failure, severity lint.Severity) {
emoji := getWarningEmoji()
if severity == lint.SeverityError {
emoji = getErrorEmoji()
}
sb.WriteString(f.table([][]string{{emoji, ruleDescriptionURL(failure.RuleName), color.GreenString(failure.Failure)}}))
sb.WriteString(table([][]string{{emoji, ruleDescriptionURL(failure.RuleName), color.GreenString(failure.Failure)}}))
}
func (*Friendly) printFilePosition(sb *strings.Builder, failure lint.Failure) {
@ -109,7 +109,7 @@ func (*Friendly) printSummary(w io.Writer, errors, warnings int) {
}
}
func (f *Friendly) printStatistics(w io.Writer, header string, stats map[string]int) {
func (*Friendly) printStatistics(w io.Writer, header string, stats map[string]int) {
if len(stats) == 0 {
return
}
@ -125,17 +125,19 @@ func (f *Friendly) printStatistics(w io.Writer, header string, stats map[string]
formatted = append(formatted, []string{color.GreenString(fmt.Sprintf("%d", entry.failures)), entry.name})
}
fmt.Fprintln(w, header)
fmt.Fprintln(w, f.table(formatted))
fmt.Fprintln(w, table(formatted))
}
func (*Friendly) table(rows [][]string) string {
buf := new(bytes.Buffer)
table := tablewriter.NewWriter(buf)
table.SetBorder(false)
table.SetColumnSeparator("")
table.SetRowSeparator("")
table.SetAutoWrapText(false)
table.AppendBulk(rows)
table.Render()
func table(rows [][]string) string {
var buf bytes.Buffer
tw := tabwriter.NewWriter(&buf, 0, 0, 2, ' ', 0)
for _, row := range rows {
tw.Write([]byte{'\t'})
for _, col := range row {
tw.Write(append([]byte(col), '\t'))
}
tw.Write([]byte{'\n'})
}
tw.Flush()
return buf.String()
}