go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-11-27 22:18:41 +02:00
Code Issues Releases Activity

Fix package check in error-strings rule (#610) (#611)

Browse Source 
Co-authored-by: SalvadorC <salvadorcavadini+github@gmail.com>
This commit is contained in:
doniacld
2021-10-30 08:45:37 +02:00
committed by GitHub
parent 0fada9d76c
commit faba17a90f
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
rule/error-strings.go
View File

@@ -105,6 +105,9 @@ func (w lintErrorStrings) match(expr *ast.CallExpr) bool {
} }
// retrieve the package // retrieve the package
id, ok := sel.X.(*ast.Ident) id, ok := sel.X.(*ast.Ident)
if !ok {
return false
}
functions, ok := w.errorFunctions[id.Name] functions, ok := w.errorFunctions[id.Name]
if !ok { if !ok {
return false return false

4
testdata/golint/error-strings.go vendored
View File

@@ -16,5 +16,9 @@ func g(x int) error {
err = fmt.Errorf("Newlines are really fun\n") // MATCH /error strings should not be capitalized or end with punctuation or a newline/ err = fmt.Errorf("Newlines are really fun\n") // MATCH /error strings should not be capitalized or end with punctuation or a newline/
err = errors.New(`too much stuff.`) // MATCH /error strings should not be capitalized or end with punctuation or a newline/ err = errors.New(`too much stuff.`) // MATCH /error strings should not be capitalized or end with punctuation or a newline/
err = errors.New("This %d is too low", x) // MATCH /error strings should not be capitalized or end with punctuation or a newline/ err = errors.New("This %d is too low", x) // MATCH /error strings should not be capitalized or end with punctuation or a newline/
// Non-regression test for issue #610
d.stack.Push(from)
return err return err
} }