* prepareSkips: to resolve regexps in excludes
* prepareSkips: to resolve regexps in excludes
* cleanup
* errorf: format
* doublestar/v4: latest version
* refactor: fix thelper issues
test/utils_test.go:19:6 thelper test helper function should start from t.Helper()
test/utils_test.go:42:6 thelper test helper function should start from t.Helper()
test/utils_test.go:63:6 thelper test helper function should start from t.Helper()
test/utils_test.go:146:6 thelper test helper function should start from t.Helper()
* refactor: fix govet issues
rule/error_strings.go:50:21 govet printf: non-constant format string in call to fmt.Errorf
* refactor: fix gosimple issue
rule/bare_return.go:52:9 gosimple S1016: should convert w (type lintBareReturnRule) to bareReturnFinder instead of using struct literal
* refactor: fix errorlint issues
lint/filefilter.go:70:86 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/filefilter.go:113:104 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/filefilter.go:125:89 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/linter.go:166:72 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/linter.go:171:73 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
config/config.go:174:57 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
config/config.go:179:64 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
* refactor: fix revive issue about comment spacing
cli/main.go:31:2 revive comment-spacings: no space between comment delimiter and comment text
* refactor: fix revive issue about unused-receiver
revivelib/core_test.go:77:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
revivelib/core_test.go:81:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/context_as_argument.go:76:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/var_naming.go:73:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/modifies_value_receiver.go:59:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/filename_format.go:43:7 revive unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
* refactor: fix revive issues about unused-parameter
revivelib/core_test.go:81:24 revive unused-parameter: parameter 'file' seems to be unused, consider removing or renaming it as _
revivelib/core_test.go:81:41 revive unused-parameter: parameter 'arguments' seems to be unused, consider removing or renaming it as _
* refactor: fix gocritic issues about commentedOutCode
test/utils_test.go:119:5 gocritic commentedOutCode: may want to remove commented-out code
rule/unreachable_code.go:65:3 gocritic commentedOutCode: may want to remove commented-out code
The `if-return` rule was originally a golint rule which was removed
from their ruleset for being out of scope. Similarly, it was dropped
from revive intentionally as a result of #537. More recently, it was
reintroduced into the default ruleset as a result of #799 due to a
discrepancy in documentation without a discussion of whether this rule
in particular belonged as a part of that default rule set.
While it is no longer a goal of this project to align 100% with the
golint defaults, I believe that this rule gives bad advice often enough
that it should not be enabled by default.
For example, consider the following code:
```go
if err := func1(); err != nil {
return err
}
if err := func2(); err != nil {
return err
}
if err := func3(); err != nil {
return err
}
return nil
```
The `if-return` rule considers this a violation of style, and instead
suggests the following:
```go
if err := func1(); err != nil {
return err
}
if err := func2(); err != nil {
return err
}
return func3()
```
While this is more terse, it has a few shortcomings compared to the
original. In particular, it means extending the size of the diff if
changing the order of checks, adding logic after the call that currently
happens to be last, or choosing to wrap the error. And in that last
case, it can make it less obvious that there is an unwrapped error being
propagated up the call stack.
This in practice has a very similar effect to disabling trailing commas;
while it is not necessarily wrong as a style choice, I don't believe it
warrants a position as part of the default ruleset here.
See-also: https://github.com/golang/lint/issues/363
* Separating lib from cli
* Renamed NewRevive to New
* Added GetLintFailures helper function
* Moved formatter to call to format since that's when it's needed
* makes fields of Revive struct non-public
* minor modifs in tests: remove unnamed constats
* Added lint package management to lint command
* README message for using revive as a library
* README formatting
* Removed unused method
* Slightly improved wording in README
* Handling format errors
* Renaming file to better reflect intent
* Refactoring pattern usage
* README heads
* renames excludePaths into excludePatterns
Co-authored-by: Bernardo Heynemann <bernardo.heynemann@coinbase.com>
Co-authored-by: chavacava <salvadorcavadini+github@gmail.com>
