1
0
mirror of https://github.com/mgechev/revive.git synced 2025-05-21 22:13:14 +02:00

16 Commits

Author SHA1 Message Date
Oleksandr Redko
724a4ca419
chore: remove redundant //revive:disable-line (#1335) 2025-05-02 02:02:31 -07:00
chavacava
d8a47ba18e
var-name checks each package name only once (#1319) 2025-04-24 14:29:39 +02:00
ccoVeille
3d1115dacd
refactor: rule configuration and error management (#1185)
* refactor: avoid running rule once configuration failed

* refactor: remove deep-exit in lint/linter.go
2024-12-13 21:38:46 +01:00
ccoVeille
3421eaecf0
refactor: fix linting issues (#1188)
* refactor: fix thelper issues

test/utils_test.go:19:6   thelper  test helper function should start from t.Helper()
test/utils_test.go:42:6   thelper  test helper function should start from t.Helper()
test/utils_test.go:63:6   thelper  test helper function should start from t.Helper()
test/utils_test.go:146:6  thelper  test helper function should start from t.Helper()

* refactor: fix govet issues

rule/error_strings.go:50:21  govet  printf: non-constant format string in call to fmt.Errorf

* refactor: fix gosimple issue

rule/bare_return.go:52:9  gosimple  S1016: should convert w (type lintBareReturnRule) to bareReturnFinder instead of using struct literal

* refactor: fix errorlint issues

lint/filefilter.go:70:86    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/filefilter.go:113:104  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/filefilter.go:125:89   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/linter.go:166:72       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
lint/linter.go:171:73       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
config/config.go:174:57     errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
config/config.go:179:64     errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors

* refactor: fix revive issue about comment spacing

cli/main.go:31:2 revive comment-spacings: no space between comment delimiter and comment text

* refactor: fix revive issue about unused-receiver

revivelib/core_test.go:77:7                     revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
revivelib/core_test.go:81:7                     revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/context_as_argument.go:76:7                revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/var_naming.go:73:7                         revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/modifies_value_receiver.go:59:7            revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _
rule/filename_format.go:43:7                    revive       unused-receiver: method receiver 'r' is not referenced in method's body, consider removing or renaming it as _

* refactor: fix revive issues about unused-parameter

revivelib/core_test.go:81:24                    revive       unused-parameter: parameter 'file' seems to be unused, consider removing or renaming it as _
revivelib/core_test.go:81:41                    revive       unused-parameter: parameter 'arguments' seems to be unused, consider removing or renaming it as _

* refactor: fix gocritic issues about commentedOutCode

test/utils_test.go:119:5                       gocritic  commentedOutCode: may want to remove commented-out code
rule/unreachable_code.go:65:3                  gocritic  commentedOutCode: may want to remove commented-out code
2024-12-12 08:42:41 +01:00
Oleksandr Redko
0afba4ff15
refactor: enforce map and slice style (#1131) 2024-11-16 18:05:30 +01:00
Oleksandr Redko
6228ba57cf
refactor: simplify tests (#1089) 2024-11-04 09:25:03 -03:00
Oleksandr Redko
9a8587cc49
revive: add revive.toml for linting revive itself (#1094) 2024-11-04 09:18:17 -03:00
Oleksandr Redko
511e4e65ff
fix: extractInstructionFromJSON returns an error (#1082) 2024-10-29 13:33:38 +01:00
Oleksandr Redko
14babf2824
refactor: move lint.Name to name.go file (#1084) 2024-10-28 13:22:36 +01:00
Oleksandr Redko
d29323985f
refactor: add tests for isGenerated in the lint package (#1083) 2024-10-28 08:24:10 -03:00
Oleksandr Redko
599874c773
chore: remove unnecessary empty lines (#1080) 2024-10-26 07:35:02 -03:00
Oleksandr Redko
662e02cd70
refactor: use "filepath" instead of "path" (#1073) 2024-10-25 11:48:41 +02:00
chavacava
a65fb8d1b5
adds tests for specific go versions (#1043)
Co-authored-by: chavacava <salvador.cavadini@gmail.com>
2024-09-20 16:09:24 +02:00
Oleksandr Redko
59131927d3
Move away from deprecated github.com/pkg/errors (#1039) 2024-09-16 09:40:46 +02:00
Oleksandr Redko
8bea739f45
docs: fix typo in comments (#1037) 2024-09-14 21:38:06 +02:00
Oleksandr Redko
2a1701aadb
fix: enable tests in the test/utils.go file (#930) 2023-12-02 12:42:41 +01:00