mirror of
https://github.com/mgechev/revive.git
synced 2025-04-04 22:14:18 +02:00
1da965b65f
* fix issue 386: Incorrectly identifies channel draining as "empty code block" * updates doc of empty-block rule
48 lines
851 B
Go
48 lines
851 B
Go
// Test of empty-blocks.
|
|
|
|
package fixtures
|
|
|
|
func f(x int) {} // Must not match
|
|
|
|
type foo struct{}
|
|
|
|
func (f foo) f(x *int) {} // Must not match
|
|
func (f *foo) g(y *int) {} // Must not match
|
|
|
|
func g(f func() bool) {
|
|
{ // MATCH /this block is empty, you can remove it/
|
|
}
|
|
|
|
_ = func(e error) {} // Must not match
|
|
|
|
if ok := f(); ok { // MATCH /this block is empty, you can remove it/
|
|
// only a comment
|
|
} else {
|
|
println("it's NOT empty!")
|
|
}
|
|
|
|
if ok := f(); ok {
|
|
println("it's NOT empty!")
|
|
} else { // MATCH /this block is empty, you can remove it/
|
|
|
|
}
|
|
|
|
for i := 0; i < 10; i++ { // MATCH /this block is empty, you can remove it/
|
|
|
|
}
|
|
|
|
for { // MATCH /this block is empty, you can remove it/
|
|
|
|
}
|
|
|
|
// issue 386
|
|
var c = make(chan int)
|
|
for range c {
|
|
}
|
|
|
|
var s = "a string"
|
|
for range s { // MATCH /this block is empty, you can remove it/
|
|
}
|
|
|
|
}
|