mirror of
https://github.com/mgechev/revive.git
synced 2025-02-15 13:53:15 +02:00
318db94210
* Separating lib from cli * Renamed NewRevive to New * Added GetLintFailures helper function * Moved formatter to call to format since that's when it's needed * makes fields of Revive struct non-public * minor modifs in tests: remove unnamed constats * Added lint package management to lint command * README message for using revive as a library * README formatting * Removed unused method * Slightly improved wording in README * Handling format errors * Renaming file to better reflect intent * Refactoring pattern usage * README heads * renames excludePaths into excludePatterns Co-authored-by: Bernardo Heynemann <bernardo.heynemann@coinbase.com> Co-authored-by: chavacava <salvadorcavadini+github@gmail.com>
107 lines
2.3 KiB
Go
107 lines
2.3 KiB
Go
package revivelib_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mgechev/revive/config"
|
|
"github.com/mgechev/revive/lint"
|
|
"github.com/mgechev/revive/revivelib"
|
|
)
|
|
|
|
func TestReviveLint(t *testing.T) {
|
|
// ARRANGE
|
|
revive := getMockRevive(t)
|
|
|
|
// ACT
|
|
failures, err := revive.Lint(revivelib.Include("../testdata/if-return.go"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// ASSERT
|
|
failureList := []lint.Failure{}
|
|
|
|
for failure := range failures {
|
|
failureList = append(failureList, failure)
|
|
}
|
|
|
|
const expected = 3
|
|
|
|
got := len(failureList)
|
|
if got != expected {
|
|
t.Fatalf("Expected failures to have %d failures, but it has %d.", expected, got)
|
|
}
|
|
|
|
errmsg := "redundant if ...; err != nil check, just return error instead."
|
|
if failureList[0].Failure != errmsg {
|
|
t.Fatalf("Expected failure[0] to be '%s', but it was '%s'", errmsg, failureList[0].Failure)
|
|
}
|
|
}
|
|
|
|
func TestReviveFormat(t *testing.T) {
|
|
// ARRANGE
|
|
revive := getMockRevive(t)
|
|
|
|
failuresChan, err := revive.Lint(revivelib.Include("../testdata/if-return.go"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// ACT
|
|
failures, exitCode, err := revive.Format("stylish", failuresChan)
|
|
|
|
// ASSERT
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
errorMsgs := []string{
|
|
"(15, 2) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
"(88, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
"(95, 3) https://revive.run/r#if-return redundant if ...; err != nil check, just return error instead.",
|
|
}
|
|
for _, errorMsg := range errorMsgs {
|
|
if !strings.Contains(failures, errorMsg) {
|
|
t.Fatalf("Expected formatted failures '%s' to contain '%s', but it didn't.", failures, errorMsg)
|
|
}
|
|
}
|
|
|
|
const expected = 1
|
|
if exitCode != expected {
|
|
t.Fatalf("Expected exit code to be %d, but it was %d.", expected, exitCode)
|
|
}
|
|
}
|
|
|
|
type mockRule struct {
|
|
}
|
|
|
|
func (r *mockRule) Name() string {
|
|
return "mock-rule"
|
|
}
|
|
|
|
func (r *mockRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Failure {
|
|
return nil
|
|
}
|
|
|
|
func getMockRevive(t *testing.T) *revivelib.Revive {
|
|
t.Helper()
|
|
|
|
conf, err := config.GetConfig("../defaults.toml")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
revive, err := revivelib.New(
|
|
conf,
|
|
true,
|
|
2048,
|
|
revivelib.NewExtraRule(&mockRule{}, lint.RuleConfig{}),
|
|
)
|
|
if err != nil {
|
|
t.Fatal(err.Error())
|
|
}
|
|
|
|
return revive
|
|
}
|