1
0
mirror of https://github.com/mgechev/revive.git synced 2025-11-23 22:04:49 +02:00
Files
revive/rule/superfluous_else_test.go
Oleksandr Redko 9f5f957b33 rule: allow lowercased and kebab-cased options (#1272)
* rule: tests for Configure with named options; fix errors

* rule: refactor and add tests for ifelse rules

* rule: allow lowercased and kebab-cased options

* test: update integration tests with lowercased params

* docs: update rules descriptions

* rule: simplify Configure implementation with one option

* gofmt and fix lint

* review: add isRuleOption, update grammar in doc, simplify regex

Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>

---------

Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
2025-03-28 09:34:20 +01:00

81 lines
1.7 KiB
Go

package rule
import (
"testing"
"github.com/mgechev/revive/lint"
)
func TestSuperfluousElseRule_Configure(t *testing.T) {
tests := []struct {
name string
arguments lint.Arguments
wantErr error
wantPreserveScope bool
}{
{
name: "no arguments",
arguments: lint.Arguments{},
wantErr: nil,
wantPreserveScope: false,
},
{
name: "valid arguments",
arguments: lint.Arguments{
"preserveScope",
},
wantErr: nil,
wantPreserveScope: true,
},
{
name: "valid lowercased arguments",
arguments: lint.Arguments{
"preservescope",
},
wantErr: nil,
wantPreserveScope: true,
},
{
name: "valid kebab-cased arguments",
arguments: lint.Arguments{
"preserve-scope",
},
wantErr: nil,
wantPreserveScope: true,
},
{
name: "invalid arguments",
arguments: lint.Arguments{
"unknown",
},
wantErr: nil,
wantPreserveScope: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var rule SuperfluousElseRule
err := rule.Configure(tt.arguments)
if tt.wantErr != nil {
if err == nil {
t.Errorf("unexpected error: got = nil, want = %v", tt.wantErr)
return
}
if err.Error() != tt.wantErr.Error() {
t.Errorf("unexpected error: got = %v, want = %v", err, tt.wantErr)
}
return
}
if err != nil {
t.Errorf("unexpected error: got = %v, want = nil", err)
}
if rule.preserveScope != tt.wantPreserveScope {
t.Errorf("unexpected preserveScope: got = %v, want = %v", rule.preserveScope, tt.wantPreserveScope)
}
})
}
}