Miles Delahunty 4bb48df5d2 refactor: extract shared code for linting if-else chains (#821) ...

* refactor: extract shared code for linting if-else chains

The rules "early-return", "indent-error-flow" and
"superfluous-else" have a similar structure. This
moves the common logic for classifying if-else chains
to a common package.

A few side benefits:
- "early-return" now handles os.Exit/log.Panicf/etc
- "superfluous-else" now handles (builtin) panic
- "superfluous-else" and "indent-error-flow" now handle if/else
  chains with 2+ "if" branches

* internal/ifelse: style fixes, renames, spelling

2023-05-17 13:51:35 +02:00

..

add-constant.go

fix #751 [rule.add-constant] add ignoreFuncs to exclude constants in … (#756)

2022-10-13 13:23:23 +02:00

argument-limit.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

atomic.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

banned-characters.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

bare-return.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

blank-imports.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

bool-literal-in-expr.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

call-to-gc.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

cognitive-complexity.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

comment-spacings.go

add nolint to default list of acceptable comments for comment-spacings (#822)

2023-05-09 16:20:58 +02:00

confusing-naming.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

confusing-results.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

constant-logical-expr.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

context-as-argument.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

context-keys-type.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

cyclomatic.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

datarace.go

add rule datarace (#683)

2022-04-18 09:45:42 -07:00

deep-exit.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

defer.go

Capture yet more bad defer / recover patterns (#719)

2022-07-24 09:34:16 +02:00

dot-imports.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

duplicated-imports.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

early-return.go

refactor: extract shared code for linting if-else chains (#821)

2023-05-17 13:51:35 +02:00

empty-block.go

Prevent empty-block when looping over call expr

2023-05-01 10:44:48 +02:00

empty-lines.go

fix bug #739: empty-lines false positive (#742)

2022-08-27 13:18:17 +02:00

error-naming.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

error-return.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

error-strings.go

Allow to customize user functions in rule error-strings (#703)

2022-07-05 21:51:50 +02:00

errorf.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

exported.go

fix issue #691 (#700)

2022-06-28 18:14:26 +03:00

file-header.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

flag-param.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

function-length.go

fix bug #736 (#745)

2022-09-10 09:08:17 +02:00

function-result-limit.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

get-return.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

identical-branches.go

speedup branch comparison (#764)

2022-10-24 17:21:48 +02:00

if-return.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

import-shadowing.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

imports-blacklist.go

Fixes issue #619 imports-blacklist support regex (#684)

2022-04-21 16:04:00 +02:00

increment-decrement.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

indent-error-flow.go

refactor: extract shared code for linting if-else chains (#821)

2023-05-17 13:51:35 +02:00

line-length-limit.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

max-public-structs.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

modifies-param.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

modifies-value-receiver.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

nested-structs.go

fix #824 (#829)

2023-05-16 10:31:25 +02:00

optimize-operands-order.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

package-comments.go

refactor: Reduce package-comments output scope (#791)

2023-02-17 21:39:51 +01:00

range-val-address.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

range-val-in-closure.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

range.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

receiver-naming.go

fix(receiver-naming): distinguish types with parameters (#692)

2022-06-18 18:47:53 +02:00

redefines-builtin-id.go

fix issue #792 (#793)

2023-02-18 10:57:06 +01:00

string-format.go

Allows inversing the semantics of string-format rule configurations (#765)

2022-10-24 20:48:41 +02:00

string-of-int.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

struct-tag.go

Fix prefix trimming in struct-tag (#827)

2023-05-16 08:09:20 +02:00

superfluous-else.go

refactor: extract shared code for linting if-else chains (#821)

2023-05-17 13:51:35 +02:00

time-equal.go

add new rule time equal (#584)

2021-10-01 13:55:53 +02:00

time-naming.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

unconditional-recursion.go

fix some typos in repository (#728)

2022-08-08 13:48:59 +02:00

unexported-naming.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

unexported-return.go

fix(receiver-naming): distinguish types with parameters (#692)

2022-06-18 18:47:53 +02:00

unhandled-error.go

fix #754 [rule.unhandled-error] change arguments to regexp (#757)

2022-11-09 13:13:52 +01:00

unnecessary-stmt.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

unreachable-code.go

add testing.FailNow and related function to unreachable check (#711)

2022-07-20 15:41:31 -07:00

unused-param.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

unused-receiver.go

Add revive linting action and fix linting errors (#455)

2020-08-15 00:50:13 +03:00

use-any.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

useless-break.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

utils.go

fix(receiver-naming): distinguish types with parameters (#692)

2022-06-18 18:47:53 +02:00

var-declarations.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00

var-naming.go

add golint's package name MixedCaps rule as in 83fdc39ff7/lint.go (L561-L563) (#797)

2023-02-27 19:56:30 +01:00

waitgroup-by-value.go

Lint cleanup (#679)

2022-04-10 11:55:13 +02:00