mirror of
https://github.com/mgechev/revive.git
synced 2024-11-28 08:49:11 +02:00
fbefad8558
* Adds rule superfluous-else (an extension of indent-error-flow) * Fix superfluous-else rule struct namming. * Adds superfuous-else rule to the rules table * Adds confusing-naming rule * adds multifile test * clean-up * fix config.go * clean master * new ADS rule: newerr * ADS-print working version * ads-print final version * ads-lost-err working version * adds duplicated-imports rule * adds duplicated-imports rule
40 lines
821 B
Go
40 lines
821 B
Go
package rule
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/mgechev/revive/lint"
|
|
)
|
|
|
|
// DuplicatedImportsRule lints given else constructs.
|
|
type DuplicatedImportsRule struct{}
|
|
|
|
// Apply applies the rule to given file.
|
|
func (r *DuplicatedImportsRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
|
|
var failures []lint.Failure
|
|
|
|
impPaths := map[string]struct{}{}
|
|
for _, imp := range file.AST.Imports {
|
|
path := imp.Path.Value
|
|
_, ok := impPaths[path]
|
|
if ok {
|
|
failures = append(failures, lint.Failure{
|
|
Confidence: 1,
|
|
Failure: fmt.Sprintf("Package %s already imported", path),
|
|
Node: imp,
|
|
Category: "imports",
|
|
})
|
|
continue
|
|
}
|
|
|
|
impPaths[path] = struct{}{}
|
|
}
|
|
|
|
return failures
|
|
}
|
|
|
|
// Name returns the rule name.
|
|
func (r *DuplicatedImportsRule) Name() string {
|
|
return "duplicated-imports"
|
|
}
|