1
0
mirror of https://github.com/mgechev/revive.git synced 2025-11-25 22:12:38 +02:00
Files
revive/rule/comment_spacings.go
Oleksandr Redko 395f7902d3 refactor: replace failure Category raw string with constant (#1196)
* refactor: replace Category raw strings with constants

* Add type FailureCategory; add comments for constants
2025-01-18 12:16:19 +01:00

82 lines
1.9 KiB
Go

package rule
import (
"fmt"
"strings"
"github.com/mgechev/revive/lint"
)
// CommentSpacingsRule check whether there is a space between
// the comment symbol( // ) and the start of the comment text
type CommentSpacingsRule struct {
allowList []string
}
// Configure validates the rule configuration, and configures the rule accordingly.
//
// Configuration implements the [lint.ConfigurableRule] interface.
func (r *CommentSpacingsRule) Configure(arguments lint.Arguments) error {
r.allowList = []string{}
for _, arg := range arguments {
allow, ok := arg.(string) // Alt. non panicking version
if !ok {
return fmt.Errorf("invalid argument %v for %s; expected string but got %T", arg, r.Name(), arg)
}
r.allowList = append(r.allowList, `//`+allow)
}
return nil
}
// Apply the rule.
func (r *CommentSpacingsRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
var failures []lint.Failure
for _, cg := range file.AST.Comments {
for _, comment := range cg.List {
commentLine := comment.Text
if len(commentLine) < 3 {
continue // nothing to do
}
isMultiLineComment := commentLine[1] == '*'
isOK := commentLine[2] == '\n'
if isMultiLineComment && isOK {
continue
}
isOK = (commentLine[2] == ' ') || (commentLine[2] == '\t')
if isOK {
continue
}
if r.isAllowed(commentLine) {
continue
}
failures = append(failures, lint.Failure{
Node: comment,
Confidence: 1,
Category: lint.FailureCategoryStyle,
Failure: "no space between comment delimiter and comment text",
})
}
}
return failures
}
// Name yields this rule name.
func (*CommentSpacingsRule) Name() string {
return "comment-spacings"
}
func (r *CommentSpacingsRule) isAllowed(line string) bool {
for _, allow := range r.allowList {
if strings.HasPrefix(line, allow) {
return true
}
}
return isDirectiveComment(line)
}