From 347c79666287b9e1694fe6a1bb9f49a25dc9eca8 Mon Sep 17 00:00:00 2001
From: Kevin Ard <kevin@therealkevinard.com>
Date: Fri, 13 Nov 2020 16:24:34 -0500
Subject: [PATCH] add tests to previous

---
 task_test.go                          | 50 ++++++++++++++++++++++++++-
 testdata/list_mixed_desc/Taskfile.yml | 12 +++++++
 2 files changed, 61 insertions(+), 1 deletion(-)
 create mode 100644 testdata/list_mixed_desc/Taskfile.yml

diff --git a/task_test.go b/task_test.go
index 31710445..f5ead40c 100644
--- a/task_test.go
+++ b/task_test.go
@@ -474,10 +474,58 @@ func TestLabelInList(t *testing.T) {
 		Stderr: &buff,
 	}
 	assert.NoError(t, e.Setup())
-	e.PrintTasksHelp()
+	e.PrintTasksHelp(false)
 	assert.Contains(t, buff.String(), "foobar")
 }
 
+// task -al case 1: listAll list all tasks
+func TestListAllShowsNoDesc(t *testing.T) {
+	const dir = "testdata/list_mixed_desc"
+
+	var buff bytes.Buffer
+	e := task.Executor{
+		Dir:    dir,
+		Stdout: &buff,
+		Stderr: &buff,
+	}
+
+	assert.NoError(t, e.Setup())
+
+	var title string
+	e.PrintTasksHelp(true)
+	for _, title = range []string{
+		"foo",
+		"voo",
+		"doo",
+	} {
+		assert.Contains(t, buff.String(), title)
+	}
+}
+
+// task -al case 2: !listAll list some tasks (only those with desc)
+func TestListCanListDescOnly(t *testing.T) {
+	const dir = "testdata/list_mixed_desc"
+
+	var buff bytes.Buffer
+	e := task.Executor{
+		Dir:    dir,
+		Stdout: &buff,
+		Stderr: &buff,
+	}
+
+	assert.NoError(t, e.Setup())
+	e.PrintTasksHelp(false)
+
+	var title string
+	assert.Contains(t, buff.String(), "foo")
+	for _, title = range []string{
+		"voo",
+		"doo",
+	} {
+		assert.NotContains(t, buff.String(), title)
+	}
+}
+
 func TestStatusVariables(t *testing.T) {
 	const dir = "testdata/status_vars"
 
diff --git a/testdata/list_mixed_desc/Taskfile.yml b/testdata/list_mixed_desc/Taskfile.yml
new file mode 100644
index 00000000..72997d73
--- /dev/null
+++ b/testdata/list_mixed_desc/Taskfile.yml
@@ -0,0 +1,12 @@
+version: '3'
+
+tasks:
+  foo:
+    label: "foobar"
+    desc: "foo has desc and label"
+
+  voo:
+    label: "voo has no desc"
+
+  doo:
+    label: "doo has desc, no label"