go/task
go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-03-19 21:17:46 +02:00
Code Issues Releases Activity

chore(requires): skip unneeded variable evaluation for requires (#1976)

Browse Source
This commit is contained in:
Andrey Nering 2024-12-30 18:27:16 -03:00 committed by GitHub
parent f27daea5c9
commit 43f3dcea05
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
requires.go
View File

@ -7,20 +7,15 @@ import (
"github.com/go-task/task/v3/taskfile/ast" "github.com/go-task/task/v3/taskfile/ast"
) )
func (e *Executor) areTaskRequiredVarsSet(t *ast.Task, call *ast.Call) error { func (e *Executor) areTaskRequiredVarsSet(t *ast.Task) error {
if t.Requires == nil || len(t.Requires.Vars) == 0 { if t.Requires == nil || len(t.Requires.Vars) == 0 {
return nil return nil
} }
vars, err := e.Compiler.GetVariables(t, call)
if err != nil {
return err
}
var missingVars []string var missingVars []string
var notAllowedValuesVars []errors.NotAllowedVar var notAllowedValuesVars []errors.NotAllowedVar
for _, requiredVar := range t.Requires.Vars { for _, requiredVar := range t.Requires.Vars {
value, ok := vars.Get(requiredVar.Name) value, ok := t.Vars.Get(requiredVar.Name)
if !ok { if !ok {
missingVars = append(missingVars, requiredVar.Name) missingVars = append(missingVars, requiredVar.Name)
} else { } else {

2
task.go
View File

@ -176,7 +176,7 @@ func (e *Executor) RunTask(ctx context.Context, call *ast.Call) error {
return nil return nil
} }
if err := e.areTaskRequiredVarsSet(t, call); err != nil { if err := e.areTaskRequiredVarsSet(t); err != nil {
return err return err
} }