Fixes to Taskfile including:

- Disallow recursive Taskfile including (i.e. included Taskfile including other Taskfiles)
- Write test for included a file instead of a directory

internal/taskfile/read/taskfile.go

@@ -1,6 +1,7 @@
 package read
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -11,6 +12,9 @@ import (
 	"gopkg.in/yaml.v2"
 )
 
+// ErrIncludedTaskfilesCantHaveIncludes is returned when a included Taskfile contains includes
+var ErrIncludedTaskfilesCantHaveIncludes = errors.New("task: Included Taskfiles can't have includes. Please, move the include to the main Taskfile")
+
 // Taskfile reads a Taskfile for a given directory
 func Taskfile(dir string) (*taskfile.Taskfile, error) {
 	path := filepath.Join(dir, "Taskfile.yml")
@@ -35,6 +39,9 @@ func Taskfile(dir string) (*taskfile.Taskfile, error) {
 		if err != nil {
 			return nil, err
 		}
+		if len(includedTaskfile.Includes) > 0 {
+			return nil, ErrIncludedTaskfilesCantHaveIncludes
+		}
 		if err = taskfile.Merge(t, includedTaskfile, namespace); err != nil {
 			return nil, err
 		}

task_test.go

@@ -478,7 +478,8 @@ func TestIncludes(t *testing.T) {
 		TrimSpace: true,
 		Files: map[string]string{
 			"main.txt":               "main",
-			"included.txt": "included",
+			"included_directory.txt": "included_directory",
+			"included_taskfile.txt":  "included_taskfile",
 		},
 	}
 	tt.Run(t)

testdata/includes/Taskfile.yml

@@ -2,12 +2,14 @@ version: '2'
 
 includes:
   included: ./included
+  included_taskfile: ./Taskfile2.yml
 
 tasks:
   default:
     cmds:
       - task: gen
       - task: included:gen
+      - task: included_taskfile:gen
 
   gen:
     cmds:

testdata/includes/Taskfile2.yml

@@ -0,0 +1,6 @@
+version: '2'
+
+tasks:
+  gen:
+    cmds:
+      - echo included_taskfile > included_taskfile.txt

testdata/includes/included/Taskfile.yml

@@ -3,4 +3,4 @@ version: '2'
 tasks:
   gen:
     cmds:
-      - echo included > included.txt
+      - echo included_directory > included_directory.txt