go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-11-23 22:24:45 +02:00
Code Issues Releases Activity

fix: special variable type errors in vars with no task context (#2107)

Browse Source 
* fix: stop dotenv trying to fetch variables when no dotenv specified

* fix: set special variables to "" when they can't be calculated
This commit is contained in:
Pete Davison
2025-03-10 11:46:07 +00:00
committed by GitHub
parent 6ee1053c96
commit 6604b9a8cc
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
compiler.go
View File

@@ -209,9 +209,16 @@ func (c *Compiler) getSpecialVars(t *ast.Task, call *Call) (map[string]string, e
allVars["TASK_DIR"] = filepathext.SmartJoin(c.Dir, t.Dir) allVars["TASK_DIR"] = filepathext.SmartJoin(c.Dir, t.Dir)
allVars["TASKFILE"] = t.Location.Taskfile allVars["TASKFILE"] = t.Location.Taskfile
allVars["TASKFILE_DIR"] = filepath.Dir(t.Location.Taskfile) allVars["TASKFILE_DIR"] = filepath.Dir(t.Location.Taskfile)
} else {
allVars["TASK"] = ""
allVars["TASK_DIR"] = ""
allVars["TASKFILE"] = ""
allVars["TASKFILE_DIR"] = ""
} }
if call != nil { if call != nil {
allVars["ALIAS"] = call.Task allVars["ALIAS"] = call.Task
} else {
allVars["ALIAS"] = ""
} }
return allVars, nil return allVars, nil

4
setup.go
View File

@@ -209,6 +209,10 @@ func (e *Executor) setupCompiler() error {
} }
func (e *Executor) readDotEnvFiles() error { func (e *Executor) readDotEnvFiles() error {
if e.Taskfile == nil || len(e.Taskfile.Dotenv) == 0 {
return nil
}
if e.Taskfile.Version.LessThan(ast.V3) { if e.Taskfile.Version.LessThan(ast.V3) {
return nil return nil
} }

4
taskfile/dotenv.go
View File

@@ -12,10 +12,6 @@ import (
) )
func Dotenv(vars *ast.Vars, tf *ast.Taskfile, dir string) (*ast.Vars, error) { func Dotenv(vars *ast.Vars, tf *ast.Taskfile, dir string) (*ast.Vars, error) {
if len(tf.Dotenv) == 0 {
return nil, nil
}
env := ast.NewVars() env := ast.NewVars()
cache := &templater.Cache{Vars: vars} cache := &templater.Cache{Vars: vars}