go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-08-10 22:42:19 +02:00
Code Issues Releases Activity

fix: checksum variable in status is incorrect (#1080)

Browse Source 
* fix: checksum variable in status is incorrect

* chore: changelog
This commit is contained in:
Pete Davison
2023-03-23 21:09:16 +00:00
committed by GitHub
parent 34f15a4976
commit 738ffde962
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/fingerprint/sources_checksum.go
View File

@@ -37,12 +37,7 @@ func (checker *ChecksumChecker) IsUpToDate(t *taskfile.Task) (bool, error) {
data, _ := os.ReadFile(checksumFile)
oldMd5 := strings.TrimSpace(string(data))
sources, err := globs(t.Dir, t.Sources)
if err != nil {
return false, err
}
newMd5, err := checker.checksum(sources...)
newMd5, err := checker.checksum(t)
if err != nil {
return false, nil
}
@@ -74,7 +69,7 @@ func (checker *ChecksumChecker) IsUpToDate(t *taskfile.Task) (bool, error) {
}
func (checker *ChecksumChecker) Value(t *taskfile.Task) (interface{}, error) {
return checker.checksum()
return checker.checksum(t)
}
func (checker *ChecksumChecker) OnError(t *taskfile.Task) error {
@@ -88,10 +83,14 @@ func (*ChecksumChecker) Kind() string {
return "checksum"
}
func (c *ChecksumChecker) checksum(files ...string) (string, error) {
h := md5.New()
func (c *ChecksumChecker) checksum(t *taskfile.Task) (string, error) {
sources, err := globs(t.Dir, t.Sources)
if err != nil {
return "", err
}
for _, f := range files {
h := md5.New()
for _, f := range sources {
// also sum the filename, so checksum changes for renaming a file
if _, err := io.Copy(h, strings.NewReader(filepath.Base(f))); err != nil {
return "", err