go/task
go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-02-03 13:22:11 +02:00
Code Issues Releases Activity

rename method for summary/summaries

Browse Source
This commit is contained in:
jaedle 2019-03-04 13:03:13 +01:00
parent db90e87d10
commit 9cfac1642a
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/summary/summary.go
View File

@ -7,14 +7,14 @@ import (
"github.com/go-task/task/v2/internal/taskfile"
)
func PrintAll(l *logger.Logger, t *taskfile.Taskfile, c []taskfile.Call) {
func PrintTasks(l *logger.Logger, t *taskfile.Taskfile, c []taskfile.Call) {
for i, call := range c {
printSpaceBetweenSummaries(i, l)
Print(l, t.Tasks[call.Task])
printSpaceBetweenSummaries(l, i)
PrintTask(l, t.Tasks[call.Task])
}
}
func printSpaceBetweenSummaries(i int, l *logger.Logger) {
func printSpaceBetweenSummaries(l *logger.Logger, i int) {
spaceRequired := i > 0
if !spaceRequired {
return
@ -24,7 +24,7 @@ func printSpaceBetweenSummaries(i int, l *logger.Logger) {
l.Outf("")
}
func Print(l *logger.Logger, t *taskfile.Task) {
func PrintTask(l *logger.Logger, t *taskfile.Task) {
printTaskName(l, t)
if hasSummary(t) {
printTaskSummary(l, t)

20
internal/summary/summary_test.go
View File

@ -22,7 +22,7 @@ func TestPrintsDependenciesIfPresent(t *testing.T) {
},
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.Contains(t, buffer.String(), "\ndependencies:\n - dep1\n - dep2\n - dep3\n")
}
@ -43,7 +43,7 @@ func TestDoesNotPrintDependenciesIfMissing(t *testing.T) {
Deps: []*taskfile.Dep{},
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.NotContains(t, buffer.String(), "dependencies:")
}
@ -54,7 +54,7 @@ func TestPrintTaskName(t *testing.T) {
Task: "my-task-name",
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.Contains(t, buffer.String(), "task: my-task-name\n")
}
@ -69,7 +69,7 @@ func TestPrintTaskCommandsIfPresent(t *testing.T) {
},
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.Contains(t, buffer.String(), "\ncommands:\n")
assert.Contains(t, buffer.String(), "\n - command-1\n")
@ -83,7 +83,7 @@ func TestDoesNotPrintCommandIfMissing(t *testing.T) {
Cmds: []*taskfile.Cmd{},
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.NotContains(t, buffer.String(), "commands")
}
@ -101,7 +101,7 @@ func TestLayout(t *testing.T) {
},
}
summary.Print(&l, task)
summary.PrintTask(&l, task)
assert.Equal(t, expectedOutput(), buffer.String())
}
@ -134,17 +134,17 @@ func TestPrintDescriptionAsFallback(t *testing.T) {
}
taskWithoutSummaryOrDescription := &taskfile.Task{}
summary.Print(&l, taskWithoutSummary)
summary.PrintTask(&l, taskWithoutSummary)
assert.Contains(t, buffer.String(), "description")
buffer.Reset()
summary.Print(&l, taskWithSummary)
summary.PrintTask(&l, taskWithSummary)
assert.NotContains(t, buffer.String(), "description")
buffer.Reset()
summary.Print(&l, taskWithoutSummaryOrDescription)
summary.PrintTask(&l, taskWithoutSummaryOrDescription)
assert.Contains(t, buffer.String(), "\n(task does not have description or summary)\n")
@ -162,7 +162,7 @@ func TestPrintAllWithSpaces(t *testing.T) {
tasks["t2"] = t2
tasks["t3"] = t3
summary.PrintAll(&l,
summary.PrintTasks(&l,
&taskfile.Taskfile{Tasks: tasks},
[]taskfile.Call{{Task: "t1"}, {Task: "t2"}, {Task: "t3"}})

2
task.go
View File

@ -65,7 +65,7 @@ func (e *Executor) Run(ctx context.Context, calls ...taskfile.Call) error {
}
if e.Summary {
summary.PrintAll(e.Logger, e.Taskfile, calls)
summary.PrintTasks(e.Logger, e.Taskfile, calls)
return nil
}