From b9a5d1c573c7e8b1df63b810d47c80ed3306e827 Mon Sep 17 00:00:00 2001 From: christiandins <145166933+christiandins@users.noreply.github.com> Date: Thu, 12 Dec 2024 01:42:04 +0100 Subject: [PATCH] lint: add linter noctx (#1898) --- .golangci.yml | 1 + taskfile/taskfile.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index fec3baa8..efbba41d 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -10,6 +10,7 @@ linters: - gofmt - gofumpt - misspell + - noctx linters-settings: depguard: diff --git a/taskfile/taskfile.go b/taskfile/taskfile.go index 9e62a0f4..d14b7603 100644 --- a/taskfile/taskfile.go +++ b/taskfile/taskfile.go @@ -43,13 +43,13 @@ var ( // found, an error will be returned. func RemoteExists(ctx context.Context, l *logger.Logger, u *url.URL, timeout time.Duration) (*url.URL, error) { // Create a new HEAD request for the given URL to check if the resource exists - req, err := http.NewRequest("HEAD", u.String(), nil) + req, err := http.NewRequestWithContext(ctx, "HEAD", u.String(), nil) if err != nil { return nil, errors.TaskfileFetchFailedError{URI: u.String()} } // Request the given URL - resp, err := http.DefaultClient.Do(req.WithContext(ctx)) + resp, err := http.DefaultClient.Do(req) if err != nil { if errors.Is(ctx.Err(), context.DeadlineExceeded) { return nil, &errors.TaskfileNetworkTimeoutError{URI: u.String(), Timeout: timeout}