go/task
go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-05-29 23:17:53 +02:00
Code Issues Releases Activity

fix: unexport HTTPNode.url

Browse Source
This commit is contained in:
Pete Davison 2025-05-20 20:30:01 +00:00
parent d47bad9071
commit d025392e8c
No known key found for this signature in database
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
taskfile/node_http.go
View File

@ -17,7 +17,7 @@ import (
// An HTTPNode is a node that reads a Taskfile from a remote location via HTTP. // An HTTPNode is a node that reads a Taskfile from a remote location via HTTP.
type HTTPNode struct { type HTTPNode struct {
*baseNode *baseNode
URL *url.URL // stores url pointing actual remote file. (e.g. with Taskfile.yml) url *url.URL // stores url pointing actual remote file. (e.g. with Taskfile.yml)
} }
func NewHTTPNode( func NewHTTPNode(
@ -36,12 +36,12 @@ func NewHTTPNode(
} }
return &HTTPNode{ return &HTTPNode{
baseNode: base, baseNode: base,
URL: url, url: url,
}, nil }, nil
} }
func (node *HTTPNode) Location() string { func (node *HTTPNode) Location() string {
return node.URL.Redacted() return node.url.Redacted()
} }
func (node *HTTPNode) Read() ([]byte, error) { func (node *HTTPNode) Read() ([]byte, error) {
@ -49,7 +49,7 @@ func (node *HTTPNode) Read() ([]byte, error) {
} }
func (node *HTTPNode) ReadContext(ctx context.Context) ([]byte, error) { func (node *HTTPNode) ReadContext(ctx context.Context) ([]byte, error) {
url, err := RemoteExists(ctx, *node.URL) url, err := RemoteExists(ctx, *node.url)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -87,7 +87,7 @@ func (node *HTTPNode) ResolveEntrypoint(entrypoint string) (string, error) {
if err != nil { if err != nil {
return "", err return "", err
} }
return node.URL.ResolveReference(ref).String(), nil return node.url.ResolveReference(ref).String(), nil
} }
func (node *HTTPNode) ResolveDir(dir string) (string, error) { func (node *HTTPNode) ResolveDir(dir string) (string, error) {
@ -112,12 +112,12 @@ func (node *HTTPNode) ResolveDir(dir string) (string, error) {
func (node *HTTPNode) CacheKey() string { func (node *HTTPNode) CacheKey() string {
checksum := strings.TrimRight(checksum([]byte(node.Location())), "=") checksum := strings.TrimRight(checksum([]byte(node.Location())), "=")
dir, filename := filepath.Split(node.URL.Path) dir, filename := filepath.Split(node.url.Path)
lastDir := filepath.Base(dir) lastDir := filepath.Base(dir)
prefix := filename prefix := filename
// Means it's not "", nor "." nor "/", so it's a valid directory // Means it's not "", nor "." nor "/", so it's a valid directory
if len(lastDir) > 1 { if len(lastDir) > 1 {
prefix = fmt.Sprintf("%s.%s", lastDir, filename) prefix = fmt.Sprintf("%s.%s", lastDir, filename)
} }
return fmt.Sprintf("http.%s.%s.%s", node.URL.Host, prefix, checksum) return fmt.Sprintf("http.%s.%s.%s", node.url.Host, prefix, checksum)
} }