1
0
mirror of https://github.com/go-task/task.git synced 2025-03-17 21:08:01 +02:00

Fix typos per review

This commit is contained in:
Stephen Prater 2019-06-11 11:46:22 -07:00
parent 12ab01d5e6
commit d1463b3e24
5 changed files with 9 additions and 13 deletions

View File

@ -346,7 +346,7 @@ the tasks are not up-to-date.
If you need a certain set of conditions to be _true_ you can use the
`preconditions` stanza. `preconditions` are very similar to `status`
lines except they support `sh` expansion and they SHOULD all return 0
lines except they support `sh` expansion and they SHOULD all return 0.
```yaml
version: '2'
@ -373,7 +373,7 @@ executed with a failing precondition will not run unless `--force` is
given.
Unlike `status` which will skip a task if it is up to date, and continue
executing tasks that depenend on it a `precondition` will fail a task, along
executing tasks that depend on it, a `precondition` will fail a task, along
with any other tasks that depend on it.
```yaml
@ -384,13 +384,13 @@ tasks:
- sh: "exit 1"
task_will_also_fail:
deps:
- task_will_fail
deps:
- task_will_fail
task_will_still_fail:
cmds:
- task: task_will_fail
- echo "I will not run"
cmds:
- task: task_will_fail
- echo "I will not run"
```
## Variables

View File

@ -7,7 +7,7 @@ import (
var (
// ErrCantUnmarshalPrecondition is returned for invalid precond YAML.
ErrCantUnmarshalPrecondition = errors.New("task: can't unmarshal precondition value")
ErrCantUnmarshalPrecondition = errors.New("task: Can't unmarshal precondition value")
)
// Precondition represents a precondition necessary for a task to run

View File

@ -1,4 +1,3 @@
// Package task provides ...
package task
import (
@ -23,7 +22,7 @@ func (e *Executor) areTaskPreconditionsMet(ctx context.Context, t *taskfile.Task
})
if err != nil {
e.Logger.Outf(p.Msg)
e.Logger.Outf("task: %s", p.Msg)
return false, ErrPreconditionFailed
}
}

View File

@ -233,7 +233,6 @@ func (e *Executor) runDeps(ctx context.Context, t *taskfile.Task) error {
g.Go(func() error {
err := e.RunTask(ctx, taskfile.Call{Task: d.Task, Vars: d.Vars})
if err != nil {
e.Logger.Errf("%s", err)
return err
}
return nil
@ -250,7 +249,6 @@ func (e *Executor) runCommand(ctx context.Context, t *taskfile.Task, call taskfi
case cmd.Task != "":
err := e.RunTask(ctx, taskfile.Call{Task: cmd.Task, Vars: cmd.Vars})
if err != nil {
e.Logger.Errf("%s", err)
return err
}
return nil

View File

@ -281,7 +281,6 @@ func TestPrecondition(t *testing.T) {
Dir: dir,
Stdout: &buff,
Stderr: &buff,
Silent: false,
}
// A precondition that has been met