From fe2da74ea3e325ec17546944f020a5b14c6665ba Mon Sep 17 00:00:00 2001
From: Max Mizikar <79100640+maxmzkrcensys@users.noreply.github.com>
Date: Wed, 9 Jul 2025 13:36:40 -0400
Subject: [PATCH] fix: don't suggest internal tasks (#2323)

Co-authored-by: Max Mizikar <maxmzkr@gmail.com>
---
 executor_test.go                                         | 9 +++++++++
 setup.go                                                 | 3 +++
 testdata/fuzzy/Taskfile.yml                              | 5 +++++
 .../fuzzy/testdata/TestFuzzyModel-intern-err-run.golden  | 1 +
 testdata/fuzzy/testdata/TestFuzzyModel-intern.golden     | 1 +
 5 files changed, 19 insertions(+)
 create mode 100644 testdata/fuzzy/testdata/TestFuzzyModel-intern-err-run.golden
 create mode 100644 testdata/fuzzy/testdata/TestFuzzyModel-intern.golden

diff --git a/executor_test.go b/executor_test.go
index 4d1677db..8c3bd193 100644
--- a/executor_test.go
+++ b/executor_test.go
@@ -957,6 +957,15 @@ func TestFuzzyModel(t *testing.T) {
 		),
 		WithTask("install"),
 	)
+
+	NewExecutorTest(t,
+		WithName("intern"),
+		WithExecutorOptions(
+			task.WithDir("testdata/fuzzy"),
+		),
+		WithTask("intern"),
+		WithRunError(),
+	)
 }
 
 func TestIncludeChecksum(t *testing.T) {
diff --git a/setup.go b/setup.go
index 0e94f3e6..b4926f2d 100644
--- a/setup.go
+++ b/setup.go
@@ -104,6 +104,9 @@ func (e *Executor) setupFuzzyModel() {
 
 	var words []string
 	for name, task := range e.Taskfile.Tasks.All(nil) {
+		if task.Internal {
+			continue
+		}
 		words = append(words, name)
 		words = slices.Concat(words, task.Aliases)
 	}
diff --git a/testdata/fuzzy/Taskfile.yml b/testdata/fuzzy/Taskfile.yml
index a05ed02e..8b1073ac 100644
--- a/testdata/fuzzy/Taskfile.yml
+++ b/testdata/fuzzy/Taskfile.yml
@@ -2,3 +2,8 @@ version: 3
 
 tasks:
   install: echo 'install'
+
+  internal:
+    internal: true
+    cmds:
+      - echo "internal"
diff --git a/testdata/fuzzy/testdata/TestFuzzyModel-intern-err-run.golden b/testdata/fuzzy/testdata/TestFuzzyModel-intern-err-run.golden
new file mode 100644
index 00000000..6ef102dd
--- /dev/null
+++ b/testdata/fuzzy/testdata/TestFuzzyModel-intern-err-run.golden
@@ -0,0 +1 @@
+task: Task "intern" does not exist
\ No newline at end of file
diff --git a/testdata/fuzzy/testdata/TestFuzzyModel-intern.golden b/testdata/fuzzy/testdata/TestFuzzyModel-intern.golden
new file mode 100644
index 00000000..56e8128e
--- /dev/null
+++ b/testdata/fuzzy/testdata/TestFuzzyModel-intern.golden
@@ -0,0 +1 @@
+task: No tasks with description available. Try --list-all to list all tasks